Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/marsshooter.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/marsshooter-0.7.5-1.20140507gitc855d04.fc21.src.rpm Description: It is a game for two players, flying with ships in a two-dimensional space setting, governed by the laws of gravity. It features: * awesome 2D-graphics with an unique style * a stunning amount of particles * single- and multiplayer-support * an artificial intelligence using an aggro-system, which reacts differentlyupon varying situations * many impressive weapons * customizable ships * a very sexy GUI * several game modes: Sacceball, TeamDeathmatch, Cannonkeep, Deathmatch, Grave-Itation Pit Fedora Account System Username: martinkg %changelog * Wed Dec 31 2014 Martin Gansser <martinkg> - 0.7.5-1.20140507gitc855d04 - initial build for Fedora rpmlint marsshooter-0.7.5-1.20140507gitc855d04.fc21.x86_64.rpm marsshooter.x86_64: W: spelling-error %description -l en_US multiplayer -> multiplier, multiplexer marsshooter.x86_64: W: spelling-error %description -l en_US differentlyupon -> differently upon, differently-upon, differentiation marsshooter.x86_64: W: spelling-error %description -l en_US customizable -> customization marsshooter.x86_64: W: spelling-error %description -l en_US Sacceball -> Baseball marsshooter.x86_64: W: no-manual-page-for-binary marsshooter 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
Hi Martin. Review swap? https://bugzilla.redhat.com/show_bug.cgi?id=1177926
desktop-file-utils is missing among BR packages.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/marsshooter.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/marsshooter-0.7.5-2.20140507gitc855d04.fc21.src.rpm %changelog * Thu Jan 01 2015 Martin Gansser <martinkg> - 0.7.5-2.20140507gitc855d04 - added BR desktop-file-utils
- %{_datadir}/marsshooter directory is not owned Just need to change in %{_datadir}/%{name}/ - %{_datadir}/icons/hicolor/512x512/ %{_datadir}/icons/hicolor/512x512/apps/ These directories are owned by hicolor-icon-theme package that should be included in the RPM chain of system. - Please, use %license to list license.txt. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v3 or later)", "GPL (v3 or later)". Detailed output of licensecheck in /home/sagitter/marsshooter/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/marsshooter [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor, /usr/share/marsshooter, /usr/share/icons/hicolor/scalable [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor/512x512/apps(hicolor-icon-theme), /usr/share/icons/hicolor/512x512(hicolor-icon-theme) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in marsshooter [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. Note: Test run failed [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [x]: Packages must not store files under /srv, /opt or /usr/local Note: Test run failed [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Test run failed [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: marsshooter-0.7.5-2.20140507gitc855d04.fc22.i686.rpm marsshooter-0.7.5-2.20140507gitc855d04.fc22.src.rpm marsshooter.i686: W: spelling-error %description -l en_US multiplayer -> multiplier, multiplexer marsshooter.i686: W: spelling-error %description -l en_US differentlyupon -> differently upon, differently-upon, differentiation marsshooter.i686: W: spelling-error %description -l en_US customizable -> customization marsshooter.i686: W: spelling-error %description -l en_US Sacceball -> Baseball marsshooter.i686: W: no-manual-page-for-binary marsshooter marsshooter.src: W: spelling-error %description -l en_US multiplayer -> multiplier, multiplexer marsshooter.src: W: spelling-error %description -l en_US differentlyupon -> differently upon, differently-upon, differentiation marsshooter.src: W: spelling-error %description -l en_US customizable -> customization marsshooter.src: W: spelling-error %description -l en_US Sacceball -> Baseball 2 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@localhost /]# rpmlint marsshooter marsshooter.i686: W: spelling-error %description -l en_US multiplayer -> multiplier, multiplexer marsshooter.i686: W: spelling-error %description -l en_US differentlyupon -> differently upon, differently-upon, differentiation marsshooter.i686: W: spelling-error %description -l en_US customizable -> customization marsshooter.i686: W: spelling-error %description -l en_US Sacceball -> Baseball marsshooter.i686: W: no-manual-page-for-binary marsshooter 1 packages and 0 specfiles checked; 0 errors, 5 warnings. ]0;<mock-chroot><mock-chroot>[root@localhost /]# echo 'rpmlint-done:' Requires -------- marsshooter (rpmlib, GLIBC filtered): /bin/sh libGL.so.1 libGLU.so.1 libX11.so.6 libXext.so.6 libc.so.6 libfribidi.so.0 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libsfml-audio.so.2 libsfml-graphics.so.2 libsfml-system.so.2 libsfml-window.so.2 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libtag.so.1 rtld(GNU_HASH) Provides -------- marsshooter: application() application(marsshooter.desktop) marsshooter marsshooter(x86-32) Source checksums ---------------- https://github.com/thelaui/M.A.R.S./archive/c855d044094a1d92317e38935d81ba938946132e/marsshooter-0.7.5-c855d04.tar.gz : CHECKSUM(SHA256) this package : 283b406d7a365c1411ae13b03a0ffab630cf613cd0ffadef98244ed1589572b2 CHECKSUM(SHA256) upstream package : 283b406d7a365c1411ae13b03a0ffab630cf613cd0ffadef98244ed1589572b2 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-i386 -rn marsshooter-0.7.5-2.20140507gitc855d04.fc21.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
new upload: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/marsshooter.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/marsshooter-0.7.5-3.20140507gitc855d04.fc21.src.rpm %changelog * Fri Jan 02 2015 Martin Gansser <martinkg> - 0.7.5-3.20140507gitc855d04 - added %%{_datadir}/%{name}/ - removed %%{_datadir}/icons/hicolor owned by hicolor-icon-theme - added license.txt to %%license
This game runs fine but it's difficult if user plays with a keyboard. Probably a joypad is better. Some other fixes. Please, follow as possible Fedora Games Packaging guidelines (https://fedoraproject.org/wiki/SIGs/Games/Packaging).
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/marsshooter.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/marsshooter-0.7.5-4.20140507gitc855d04.fc21.src.rpm %changelog * Fri Jan 02 2015 Martin Gansser <martinkg> - 0.7.5-4.20140507gitc855d04 - added Group tag - package game files and data files separately - fixed desktop file
Package approved.
@Antonio many thanks for the review. New Package SCM Request ======================= Package Name: marsshooter Short Description: M.A.R.S. - A Ridiculous Shooter Owners: martinkg Branches: f20 f21 rawhide InitialCC:
Git done (by process-git-requests).
marsshooter-0.7.5-5.20140507gitc855d04.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/marsshooter-0.7.5-5.20140507gitc855d04.fc21
marsshooter has been built successfully on f20, f21 and rawhide.
marsshooter-0.7.5-5.20140507gitc855d04.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/marsshooter-0.7.5-5.20140507gitc855d04.fc20
marsshooter-0.7.5-5.20140507gitc855d04.fc20 has been pushed to the Fedora 20 stable repository.
marsshooter-0.7.5-5.20140507gitc855d04.fc21 has been pushed to the Fedora 21 stable repository.
*** Bug 1295138 has been marked as a duplicate of this bug. ***