+++ This bug was initially created as a clone of Bug #1149809 +++ Description of problem: Looking into the code, this verification was done with all disks, while it should have been done with only plugged disks. Run a VM as stateless with and without plugged disks, and with and without storage space for new disks. No plugged disks - CDA should pass - even when there's low storage space. plugged disks - CDA should fail when there's not enough space for the plugged disks only. | File Domain | Block Domain -----|-----------------------------------------|------------- qcow | 1M (header size) | 1G -----|-----------------------------------------|------------- raw | preallocated: disk capacity (getSize()) | disk capacity | thin (sparse): 1M | (there is no raw sparse on block domains) ------------------------------------------------------------------------------- This bug is a RHEV tracker for the QE team to verify against RHEVM 3.5.0
As per description: No plugged disks - CDA should pass - even when there's low storage space. plugged disks - CDA should fail when there's not enough space for the plugged disks only. Using nfs thin and preallocated disks. >>>> The CDA did not pass with unplugged disks and low space. Moving to Assigned. Tested on: rhevm-3.5.0-0.27.el6ev.noarch vdsm-4.16.8.1-4.1.el6ev.x86_64 2015-01-07 15:58:16,542 WARN [org.ovirt.engine.core.bll.CreateAllSnapshotsFromVmCommand] (ajp-/127.0.0.1:8702-12) CanDoAction of action CreateAllSnapshotsFromVm failed. Reasons:VAR__ACTION__CREATE,VAR__TYPE__SNAPSHOT,ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN,$storageName nfs 2015-01-07 16:01:08,698 WARN [org.ovirt.engine.core.bll.CreateAllSnapshotsFromVmCommand] (ajp-/127.0.0.1:8702-17) CanDoAction of action CreateAllSnapshotsFromVm failed. Reasons:VAR__ACTION__CREATE,VAR__TYPE__SNAPSHOT,ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN,$storageName nfs [root@kevin-rhevm ~]# Timeout, server not responding.
Created attachment 977430 [details] engine vdsm and server logs Adding logs
RunVm as stateless validation indeed validate only the plugged disks. The the commands execute calls CreateAllSnapshotsFromVmCommand, which in turn calls its CDA. In this CDA all the disks, plugged and unplugged, are validated for snapshot-space, as all will later be allocated in the command's execute method. After further consideration, this is actually the wanted behaviour, since if there are no snapshot for unplugged disks, and any of these disks are later plugged during the stateless running of the VM, data will actually be written to the disk (and not to the snapshot, to be deleted later on). Closing-not a bug. Will open a new bug to monitor better, non-redundant storage allocation validation in this flow.
(In reply to Vered Volansky from comment #3) > Will open a new bug to monitor better, non-redundant > storage allocation validation in this flow. This is bug 1181133, right?
Opened bz1181133 in order to monitor issue in comment #3.