Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Exporter-Tidy/perl-Exporter-Tidy.spec SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Exporter-Tidy/perl-Exporter-Tidy-0.07-1.fc21.src.rpm Description: This module serves as an easy, clean alternative to Exporter. Unlike Exporter, it is not subclassed, but it simply exports a custom import() into your namespace. Fedora Account System Username: psabata
URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: 27734cb4972921824d3cc98428628e81887efa6e97eb4c0cb628a9225fb7f160). Ok. Summary verified from Tidy.pm. Ok. Description verified from Tidy.pm. Ok. TODO: Insert some statement into the description that this is about Perl. E.g. "This Perl module serves". TODO: Remove bundled Test::More and Test::Builder from t/lib to use system ones when running tests. FIX: The README states "public domain", but the Tidy.pm stats: > Pick your favourite OSI approved license :) > http://www.opensource.org/licenses/alphabetical These two contradicts (Public Domain is not on the list). You need to add the Tidy.pm's license to the License tag. Either list all OSI-approved licenses, or get a new Tidy.pm without the statement from the author. No XS code, noarch BuildArch is Ok. FIX: Do not build-require Test::More, or remove the bundled module and do not build-require its dependencies. All tests pass. Ok. $ rpmlint perl-Exporter-Tidy.spec ../SRPMS/perl-Exporter-Tidy-0.07-1.fc22.src.rpm ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm perl-Exporter-Tidy.src: W: spelling-error %description -l en_US subclassed -> sub classed, sub-classed, subclass ed perl-Exporter-Tidy.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace perl-Exporter-Tidy.noarch: W: spelling-error %description -l en_US subclassed -> sub classed, sub-classed, subclass ed perl-Exporter-Tidy.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Jan 6 07:11 /usr/share/doc/perl-Exporter-Tidy -rw-r--r-- 1 root root 308 Sep 14 2007 /usr/share/doc/perl-Exporter-Tidy/Changes -rw-r--r-- 1 root root 4953 Mar 30 2003 /usr/share/doc/perl-Exporter-Tidy/README -rw-r--r-- 1 root root 3134 Jan 6 07:11 /usr/share/man/man3/Exporter::Tidy.3pm.gz drwxr-xr-x 2 root root 0 Jan 6 07:11 /usr/share/perl5/vendor_perl/Exporter -rw-r--r-- 1 root root 6426 Sep 14 2007 /usr/share/perl5/vendor_perl/Exporter/Tidy.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(Carp) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Exporter::Tidy) = 0.07 1 perl-Exporter-Tidy = 0.07-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8537319). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixinf `TODO' items, and provide a new spec file. Resolution: Package NOT approved.
(In reply to Petr Pisar from comment #1) > TODO: Insert some statement into the description that this is about Perl. > E.g. "This Perl module serves". Nack; I think this is rather obvious from the package name. > TODO: Remove bundled Test::More and Test::Builder from t/lib to use system > ones when running tests. Nack; I usually keep the bundled modules used for build only and will keep these too. However, I removed the erroneus Test::More BR as pointed out further below. > FIX: The README states "public domain", but the Tidy.pm stats: > > > Pick your favourite OSI approved license :) > > http://www.opensource.org/licenses/alphabetical > > These two contradicts (Public Domain is not on the list). > > You need to add the Tidy.pm's license to the License tag. Either list all > OSI-approved licenses, or get a new Tidy.pm without the statement from the > author. Hmm, listing all the licenses would still conflict with the Public domain statement. I've emailed the author asking for clarification. > FIX: Do not build-require Test::More, or remove the bundled module and do > not build-require its dependencies. Removed. I'll post an updated package once I receive some response from upstream regarding the licensing terms.
Upstream released a new version which uses "approved OSI licenses" only. Updated for 0.08: SPEC: https://psabata.fedorapeople.org/pkgs/perl-Exporter-Tidy/perl-Exporter-Tidy.spec SRPM: https://psabata.fedorapeople.org/pkgs/perl-Exporter-Tidy/perl-Exporter-Tidy-0.08-1.fc21.src.rpm The script used to generate the value for the License tag is here: https://psabata.fedorapeople.org/pkgs/perl-Exporter-Tidy/licenses.pl It will be in the package's git repo.
Source file is original (SHA-256: 7e8472c32b1e47d0d90dfb517c039281246c3a52be3022e3cfd57a9fb9e4e58b). There are no changes in the source except $VERSION bump, README, META files, and MANIFEST. SPEC file changes: --- perl-Exporter-Tidy.spec.old 2015-01-05 17:56:12.000000000 +0100 +++ perl-Exporter-Tidy.spec 2015-01-06 14:52:23.000000000 +0100 @@ -1,8 +1,9 @@ Name: perl-Exporter-Tidy -Version: 0.07 +Version: 0.08 Release: 1%{?dist} Summary: Another way of exporting symbols -License: Public Domain +# Generated with licenses.pl +License: AAL or AFL or AGPLv3 or APSL 2.0 or ASL 2.0 or Artistic 2.0 or BSD or Boost or CATOSL or CDDL or CNRI or CPAL or CeCILL or ECL 2.0 or EFL 2.0 or EPL or EU Datagrid or EUPL 1.1 or Entessa or Fair or GPLv2 or GPLv3 or IBM or IPA or ISC or LGPLv2 or LGPLv3 or LPL or LPPL or MIT or MPLv1.1 or MPLv2.0 or MS-PL or MS-RL or MirOS or Motosoto or NCSA or NGPL or Naumen or Nokia or OFL or OSL 3.0 or PHP or PostgreSQL or Python or QPL or RPSL or SPL or Sleepycat or VSL or W3C or ZPLv2.0 or zlib URL: http://search.cpan.org/dist/Exporter-Tidy/ Source0: http://www.cpan.org/authors/id/J/JU/JUERD/Exporter-Tidy-%{version}.tar.gz BuildArch: noarch @@ -16,7 +17,6 @@ BuildRequires: perl(Exporter) BuildRequires: perl(lib) BuildRequires: perl(strict) -BuildRequires: perl(Test::More) BuildRequires: perl(threads) BuildRequires: perl(threads::shared) BuildRequires: perl(vars) @@ -48,5 +48,8 @@ %{_mandir}/man3/* %changelog -* Mon Jan 05 2015 Petr Šabata <contyk> 0.07-1 +* Tue Jan 06 2015 Petr Šabata <contyk> - 0.08-1 +- 0.08 bump + +* Mon Jan 05 2015 Petr Šabata <contyk> - 0.07-1 - Initial packaging > TODO: Insert some statement into the description that this is about Perl. > E.g. "This Perl module serves". Not addressed. Ok. > TODO: Remove bundled Test::More and Test::Builder from t/lib to use system > ones when running tests. Not addressed. Ok. > FIX: The README states "public domain", but the Tidy.pm stats: README and License tag fixed. Ok. > FIX: Do not build-require Test::More, or remove the bundled module and do > not build-require its dependencies. -BuildRequires: perl(Test::More) Ok. $ rpmlint perl-Exporter-Tidy.spec ../SRPMS/perl-Exporter-Tidy-0.08-1.fc22.src.rpm ../RPMS/noarch/perl-Exporter-Tidy-0.08-1.fc22.noarch.rpm perl-Exporter-Tidy.src: W: spelling-error %description -l en_US subclassed -> sub classed, sub-classed, subclass ed perl-Exporter-Tidy.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace perl-Exporter-Tidy.noarch: W: spelling-error %description -l en_US subclassed -> sub classed, sub-classed, subclass ed perl-Exporter-Tidy.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8540391). Ok. Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-Exporter-Tidy Short Description: Another way of exporting symbols Upstream URL: http://search.cpan.org/dist/Exporter-Tidy/ Owners: psabata jplesnik ppisar Branches: f21 InitialCC: perl-sig
Git done (by process-git-requests).
Thanks.
perl-Exporter-Tidy-0.08-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Exporter-Tidy-0.08-1.fc21
perl-Exporter-Tidy-0.08-1.fc21 has been pushed to the Fedora 21 stable repository.