Spec URL: https://git.fedorahosted.org/cgit/python-pytest-multihost.git/plain/python-pytest-multihost.spec SRPM URL: https://fedorapeople.org/~pviktori/srpms/python-pytest-multihost-0.5-1.fc21.src.rpm COPR: https://copr.fedoraproject.org/coprs/pviktori/pytest-plugins/ Fedora Account System Username: pviktori Description: Allows pytest tests to run commands on several machines. The machines to run on are described on the command line, the tests specify how many machines they need and commands/checks to run on them.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== Issues ==== - Use %license instead of %doc for COPYING. This will ensure that it's still installed, even if someone uses --nodocs with RPM (to maintain legal requirements. Also, in the future, RPM will treat %license as a hardlink opportunity to avoid duplicating licenses on the disk. - Upstream tarball contains tests but they are not run in %check If they cannot be run in %check, a comment to that effect should be provided. ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 20 files have unknown license. Detailed output of licensecheck in /dev/shm/reviews/1179336-python-pytest- multihost/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 4 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -pytest-multihost [?]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-pytest-multihost-0.5-1.fc22.noarch.rpm python3-pytest-multihost-0.5-1.fc22.noarch.rpm python-pytest-multihost-0.5-1.fc22.src.rpm python-pytest-multihost.noarch: W: spelling-error Summary(en_US) multi -> mulch, mufti python3-pytest-multihost.noarch: W: spelling-error Summary(en_US) multi -> mulch, mufti python-pytest-multihost.src: W: spelling-error Summary(en_US) multi -> mulch, mufti 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python-pytest-multihost (rpmlib, GLIBC filtered): PyYAML pytest python python(abi) python-paramiko python3-pytest-multihost (rpmlib, GLIBC filtered): python(abi) python3 python3-pytest Provides -------- python-pytest-multihost: python-pytest-multihost python3-pytest-multihost: python3-pytest-multihost Source checksums ---------------- https://github.com/encukou/pytest-multihost/archive/v0.5.tar.gz#/pytest-multihost-0.5.tar.gz : CHECKSUM(SHA256) this package : ec17a6a6553d6dce1b2171b101e3f0e5b7eba509677b2e8b474b73f7d06a937d CHECKSUM(SHA256) upstream package : ec17a6a6553d6dce1b2171b101e3f0e5b7eba509677b2e8b474b73f7d06a937d Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1179336 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thanks for the review! SRPM URL: https://fedorapeople.org/~pviktori/srpms/python-pytest-multihost-0.6-1.fc21.src.rpm And these are just updated (same URL): Spec URL: https://git.fedorahosted.org/cgit/python-pytest-multihost.git/plain/python-pytest-multihost.spec COPR: https://copr.fedoraproject.org/coprs/pviktori/pytest-plugins/
Oops, forgot to change the license for both Pythons SRPM URL: https://fedorapeople.org/~pviktori/srpms/python-pytest-multihost-0.6-2.fc21.src.rpm Spec URL: https://git.fedorahosted.org/cgit/python-pytest-multihost.git/plain/python-pytest-multihost.spec
Review approved
New Package SCM Request ======================= Package Name: python-pytest-multihost Short Description: Utility for writing multi-host tests for pytest Upstream URL: https://git.fedorahosted.org/cgit/python-pytest-multihost.git Owners: pviktori Branches: f22 f21 InitialCC:
Git done (by process-git-requests).
python-pytest-multihost-0.6-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-pytest-multihost-0.6-2.fc21
Thanks for the review, and for the repo creation!
python-pytest-multihost-0.6-2.fc21 has been pushed to the Fedora 21 stable repository.