Created attachment 977192 [details]
libvirtd+qemu logs on source and destination hosts.

Description of problem:
when migrate a vm with --copy-storage-all or --copy-storage-inc to a host with insufficient disk space, no error message produced.




Version-Release number of selected component (if applicable):
libvirt-1.2.8-11.el7.x86_64
qemu-kvm-rhev-2.1.2-17.el7.x86_64
kernel-3.10.0-220.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. prepare 2 hosts (hostA is migration source and hostB is migration destination)
2. On hostA, prepare a qcow2 image with a OS installed inside (Let's say /home/img/rhel7.qcow2), which is 9.0GB in size.  
   [root@hostA ~]# qemu-img info /home/img/rhel7.qcow2
   image: /home/img/r7.qcow2
   file format: qcow2
   virtual size: 9.0G (9663676416 bytes)
   disk size: 9.0G
   cluster_size: 65536
   Format specific information:
       compat: 1.1
       lazy refcounts: true
3. On hostB, you can follow 3.1 OR 3.2 in this step.
   3.1 prepare a 10GB blank image in the corresponding dir. But make sure hostB has no enough disk space to receive a 9GB file.  
        [root@hostB ~]# df -h
         Filesystem                                Size  Used Avail Use% Mounted on
         dev/sda1                                  40G   35G  2.4G  94% /
   3.2 prepare a 5GB blank image in the corresonding dir in hostB.
        [root@hostB]# qemu-img create -f qcow2 /home/img/rhel7.qcow2 5G
        Formatting '/home/img/rhel7.qcow2', fmt=qcow2 size=5368709120 encryption=off cluster_size=65536 lazy_refcounts=off

4. On hostA Create VM (name=r7) with following xml and start it
#virsh create r7.xml
#virsh define r7.xml
#virsh start r7

cat r7.xml
   <domain type='kvm'>
  <name>r7</name>
  <uuid>7d5a69ad-cf68-49b8-a94a-c8b7dca6afbd</uuid>
  <memory unit='KiB'>1048576</memory>
  <currentMemory unit='KiB'>1048576</currentMemory>
  <vcpu placement='static'>1</vcpu>
  <os>
    <type arch='x86_64' machine='rhel6.2.0'>hvm</type>
    <boot dev='hd'/>
  </os>
  <features>
    <acpi/>
    <apic/>
    <pae/>
  </features>
  <clock offset='utc'>
    <timer name='rtc' tickpolicy='catchup'/>
    <timer name='pit' tickpolicy='delay'/>
    <timer name='hpet' present='no'/>
  </clock>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>restart</on_reboot>
  <on_crash>restart</on_crash>
  <pm>
    <suspend-to-mem enabled='no'/>
    <suspend-to-disk enabled='no'/>
  </pm>
  <devices>
    <emulator>/usr/libexec/qemu-kvm</emulator>
    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2'/>
      <source file='/home/img/rhel7.qcow2'/>
      <target dev='hda' bus='ide'/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
    </disk>
    <controller type='usb' index='0' model='ich9-ehci1'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x7'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci1'>
      <master startport='0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0' multifunction='on'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci2'>
      <master startport='2'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x1'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci3'>
      <master startport='4'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x2'/>
    </controller>
    <controller type='pci' index='0' model='pci-root'/>
    <controller type='ide' index='0'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
    </controller>
    <controller type='virtio-serial' index='0'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
    </controller>
    <interface type='network'>
      <mac address='52:54:00:1a:9f:14'/>
      <source network='default'/>
      <model type='rtl8139'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </interface>
    <serial type='pty'>
      <target port='0'/>
    </serial>
    <console type='pty'>
      <target type='serial' port='0'/>
    </console>
    <channel type='spicevmc'>
      <target type='virtio' name='com.redhat.spice.0'/>
      <address type='virtio-serial' controller='0' bus='0' port='1'/>
    </channel>
    <input type='mouse' bus='ps2'/>
    <input type='keyboard' bus='ps2'/>
    <graphics type='spice' autoport='yes'/>
    <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'>
      <listen type='address' address='0.0.0.0'/>
    </graphics>
    <sound model='ich6'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
    </sound>
    <video>
      <model type='qxl' ram='65536' vram='65536' vgamem='8192' heads='1'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
    </video>
    <redirdev bus='usb' type='spicevmc'>
    </redirdev>
    <redirdev bus='usb' type='spicevmc'>
    </redirdev>
    <redirdev bus='usb' type='spicevmc'>
    </redirdev>
    <redirdev bus='usb' type='spicevmc'>
    </redirdev>
    <memballoon model='virtio'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
    </memballoon>
  </devices>
</domain>

5. On hostA Start migration process, either --copy-storage-all or --copy-storage-inc parameter can reproduce this issue.
  5.1 [root@hostA ~]#virsh migrate --live r7 qemu+ssh://<hostB's IP>/system --verbose --copy-storage-all
  5.2 [root@hostA ~]#virsh migrate --live r7 qemu+ssh://<hostB's IP>/system --verbose --copy-storage-inc

6. On hostB, Waiting for migration ends, and check info of /home/img/rhel7.qcow2
  [root@hostB ~]# ll /home/img -h | grep rhel7.qcow2
  -rw-r--r--. 1 qemu qemu 5.0G Jan  6 17:15 rhel7.qcow2

Actual Results:
1. No error message popped up to indicate that the "--copy-storage-all"/"--copy-storage-inc" failed.
2. Bad VM r7 is running on hostB and good VM r7 on hostA was shutoff.

Expected Results:
1. Error message produced in source host terminal such as "copy storage failed, there is no enough disk space in /home/img/rhel7.qcow2"
2. When copy failed, source vm on hostA should not be shutdown, and destination vm on hostB should not be turned on. System should always rollback to previous "good" state after failure. 

Additional info:
In dest host's qemu log, we can see：
...
nbd.c:nbd_trip():L1142: writing to file failed
block I/O error in device 'drive-ide0-0-0': No space left on device (28)

All source and dest hosts logs attached. Please check if required.