Bug 1179804 - Review Request: python-nine - Python 2 / 3 compatibility, like six, but favouring Python 3
Summary: Review Request: python-nine - Python 2 / 3 compatibility, like six, but favou...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1179551
TreeView+ depends on / blocked
 
Reported: 2015-01-07 15:14 UTC by Ralph Bean
Modified: 2015-02-03 19:31 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-12 17:58:17 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ralph Bean 2015-01-07 15:14:53 UTC
Spec URL: http://ralph.fedorapeople.org//python-nine.spec
SRPM URL: http://ralph.fedorapeople.org//python-nine-0.3.4-1.fc21.src.rpm

Description:
Let's write Python 3 right now!

When the best Python 2/Python 3 compatibility modules -- especially the
famous `*six* library invented by Benjamin Peterson
<https://pypi.python.org/pypi/six>`_ -- were created, they were written
from the point of view of a Python 2 programmer starting to grok Python 3.

When thou writeth Python, thou shalt write Python 3 and, just for a while,
ensure that the thing worketh on Python 2.7 and, possibly, even 2.6.

Just before Python 2 is finally phased out, thine codebase shall look more
like 3 than like 2.

nine facilitates this new point of view. You can write code that is as
3ish as possible while still supporting 2.6. Very comfortable for writing
new projects.

Comment 1 Ralph Bean 2015-01-07 15:14:54 UTC
This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=8547362

Comment 2 Parag AN(पराग) 2015-01-10 09:44:00 UTC
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
python3-nine.x86_64: W: spelling-error Summary(en_US) favouring -> favoring, flavoring
python3-nine.x86_64: W: spelling-error %description -l en_US https -> HTTP
python3-nine.x86_64: W: spelling-error %description -l en_US pypi -> typify
python3-nine.x86_64: W: spelling-error %description -l en_US writeth -> writhe, writer, write
python3-nine.x86_64: W: spelling-error %description -l en_US worketh -> worksheet
python3-nine.x86_64: W: spelling-error %description -l en_US codebase -> co debase, co-debase, code base
python-nine.src: W: spelling-error Summary(en_US) favouring -> favoring, flavoring
python-nine.src: W: spelling-error %description -l en_US https -> HTTP
python-nine.src: W: spelling-error %description -l en_US pypi -> typify
python-nine.src: W: spelling-error %description -l en_US writeth -> writhe, writer, write
python-nine.src: W: spelling-error %description -l en_US worketh -> worksheet
python-nine.src: W: spelling-error %description -l en_US codebase -> co debase, co-debase, code base
python-nine.x86_64: W: spelling-error Summary(en_US) favouring -> favoring, flavoring
python-nine.x86_64: W: spelling-error %description -l en_US https -> HTTP
python-nine.x86_64: W: spelling-error %description -l en_US pypi -> typify
python-nine.x86_64: W: spelling-error %description -l en_US writeth -> writhe, writer, write
python-nine.x86_64: W: spelling-error %description -l en_US worketh -> worksheet
python-nine.x86_64: W: spelling-error %description -l en_US codebase -> co debase, co-debase, code base
python-nine.x86_64: E: no-binary
python-nine-debuginfo.x86_64: E: empty-debuginfo-package
4 packages and 0 specfiles checked; 2 errors, 18 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball     : fe1723ca5d3db5cb28a861dca9da1a4a0ce3614057fb07279ddb4905415d3aff
upstream tarball : fe1723ca5d3db5cb28a861dca9da1a4a0ce3614057fb07279ddb4905415d3aff

+ License "Public Domain" is valid and included in LICENSE.rst file

Suggestions:
1) This package is a noarch package please add
BuildArch:      noarch

2) Group tag is not needed even on EPEL6 so if you are not planning this package for el5, you can safely remove it though its not mandatory to remove.

3) as this is noarch package you can remove CFLAGS in %build

Rest looks simple and fine :)

Comment 3 Ralph Bean 2015-01-11 00:27:50 UTC
Thanks Parag.  :)  Changes made here:

Spec URL: http://threebean.org/rpm/SPECS/python-nine.spec
SRPM URL: http://threebean.org/rpm/SRPMS/python-nine-0.3.4-2.fc21.src.rpm

Comment 4 Parag AN(पराग) 2015-01-11 01:27:41 UTC
Looks good now.

APPROVED.

Comment 5 Ralph Bean 2015-01-12 14:16:10 UTC
Thanks again Parag!

New Package SCM Request
=======================
Package Name: python-nine
Short Description: Python 2 / 3 compatibility, like six, but favouring Python 3
Upstream URL: https://pypi.python.org/pypi/nine
Owners: ralph
Branches: f21 f20 epel7 el6
InitialCC:

Comment 6 Gwyn Ciesla 2015-01-12 16:56:07 UTC
Git done (by process-git-requests).

Comment 7 Ralph Bean 2015-01-12 17:58:17 UTC
Built for rawhide:  http://koji.fedoraproject.org/koji/taskinfo?taskID=8593315

Comment 8 Fedora Update System 2015-01-12 19:09:16 UTC
python-nine-0.3.4-4.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-nine-0.3.4-4.el7

Comment 9 Fedora Update System 2015-01-12 19:10:42 UTC
python-nine-0.3.4-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-nine-0.3.4-4.el6

Comment 10 Fedora Update System 2015-01-12 19:11:07 UTC
python-nine-0.3.4-4.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-nine-0.3.4-4.fc21

Comment 11 Fedora Update System 2015-01-12 19:11:30 UTC
python-nine-0.3.4-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-nine-0.3.4-4.fc20

Comment 12 Fedora Update System 2015-02-03 11:59:32 UTC
python-nine-0.3.4-4.fc20 has been pushed to the Fedora 20 stable repository.

Comment 13 Fedora Update System 2015-02-03 12:05:02 UTC
python-nine-0.3.4-4.fc21 has been pushed to the Fedora 21 stable repository.

Comment 14 Fedora Update System 2015-02-03 19:30:50 UTC
python-nine-0.3.4-4.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 15 Fedora Update System 2015-02-03 19:31:01 UTC
python-nine-0.3.4-4.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.