Spec URL: https://robyduck.fedorapeople.org/packages/SPECS/python-parsley.spec SRPM URL: https://robyduck.fedorapeople.org/packages/SRPMS/python-parsley-1.2-1.fc20.src.rpm Description: A parser generator library based on OMeta, and other useful parsing tools. Parsley is a parsing library for people who find parsers scary or annoying. I wrote it because I wanted to parse a programming language, and tools like PLY or ANTLR or Bison were very hard to understand and integrate into my Python code. Most parser generators are based on LL or LR parsing algorithms that compile to big state machine tables. It was like I had to wake up a different section of my brain to understand or work on grammar rules. Parsley, like pyparsing and ZestyParser, uses the PEG algorithm, so each expression in the grammar rules works like a Python expression. In particular, alternatives are evaluated in order, unlike table-driven parsers such as yacc, bison or PLY. Parsley is an implementation of OMeta, an object-oriented pattern-matching language developed by Alessandro Warth at thesis, which provides a detailed description of OMeta: http://www.vpri.org/pdf/tr2008003_experimenting.pdf Fedora Account System Username: robyduck
Hi Robert, some comments. - in terml/test/test_terml.py file there are an import: from twisted.trial import unittest so, you will need python-twisted for running these tests. - The package contains tests is good practice, running it. - The package contains documentation, please build with python-sphinx. - Don't use wildcards listing the files or trailing slash, just list directly the directory %{python2_sitelib}/ometa instead %{python2_sitelib}/ometa/* -Don't ship eggs directly from the code, rebuild it. (Just remove the bundled egg in %prep section)
Eduardo thank you (also for the fedora-review flag). I applied your comments to the spec file and rebuilt it (I'm on a F21 here now). Spec URL: https://robyduck.fedorapeople.org/packages/SPECS/python-parsley.spec SRPM URL: https://robyduck.fedorapeople.org/packages/SRPMS/python-parsley-1.2-2.fc21.src.rpm
Let's see this rpmlint output python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/terml 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/ometa 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/terml/_generated 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/ometa/_generated 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/terml/test 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/share/doc/python-parsley 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/ometa/test 02755L I will take like example te directory ometa. On the pristine source if we make: stat -c "%a %n" ometa the output is 755 ometa <= this is OK No, we will take the rpm rpm2cpio python-parsley-1.2-2.fc22.noarch.rpm | cpio -idmv stat -c "%a %n" ometa 2755 ometa <= this is not OK Try to investigate why the installed source is taking these permissions, or simply change the permissions of the directory to the correct value in %files section. Maybe this problem does not ocurred when you did ometa/* because the wilcard declare all files within a directory to be owned by the package.I don't make it. Because you has to be carefull with the directories that are shared by other packages. If you want back to the latest behaviour and that resolves this problem. Don't hesitate to do it. - in %check section, is not running any test. + cd /builddir/build/BUILD + cd Parsley-1.2 + /usr/bin/python2 terml/test/test_terml.py + exit 0 Due to that this is a unittest, I think you can run python -m unittest Export $PYTHONPATH first. if the test cannot be run for some reason, just put a comment in %check, explaining why Please, fix the permissions and consider the package approved, after that. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 60 files have unknown license. Detailed output of licensecheck in /home/echevemaster/test-packages/1179947-python- parsley/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present.x[ ]: Requires correct, justified where necessary. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [!]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-parsley-1.2-2.fc22.noarch.rpm python-parsley-1.2-2.fc22.src.rpm python-parsley.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers python-parsley.noarch: W: spelling-error %description -l en_US pyparsing -> sparring python-parsley.noarch: W: spelling-error %description -l en_US yacc -> yak, Yacc, ya cc python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/terml 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/ometa 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/terml/_generated 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/ometa/_generated 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/terml/test 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/share/doc/python-parsley 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/ometa/test 02755L python-parsley.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers python-parsley.src: W: spelling-error %description -l en_US pyparsing -> sparring python-parsley.src: W: spelling-error %description -l en_US yacc -> yak, Yacc, ya cc 2 packages and 0 specfiles checked; 7 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@localhost /]# rpmlint python-parsley python-parsley.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers python-parsley.noarch: W: spelling-error %description -l en_US pyparsing -> parsing python-parsley.noarch: W: spelling-error %description -l en_US yacc -> yak, Yacc, ya cc python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/terml 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/ometa 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/terml/_generated 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/ometa/_generated 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/terml/test 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/share/doc/python-parsley 02755L python-parsley.noarch: E: non-standard-dir-perm /usr/lib/python2.7/site-packages/ometa/test 02755L 1 packages and 0 specfiles checked; 7 errors, 3 warnings. ]0;<mock-chroot><mock-chroot>[root@localhost /]# echo 'rpmlint-done:' Requires -------- python-parsley (rpmlib, GLIBC filtered): python(abi) Provides -------- python-parsley: python-parsley
Thank you, changes applied here: Spec URL: https://robyduck.fedorapeople.org/packages/SPECS/python-parsley.spec SRPM URL: https://robyduck.fedorapeople.org/packages/SRPMS/python-parsley-1.2-3.fc21.src.rpm
Ok tests not ready for now. Please check with upstream [echevemaster@localhost ~]$ rpmlint -vi python-parsley-1.2-3.fc22.noarch.rpm python-parsley.noarch: I: checking python-parsley.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers The value of this tag appears to be misspelled. Please double-check. python-parsley.noarch: W: spelling-error %description -l en_US pyparsing -> sparring The value of this tag appears to be misspelled. Please double-check. python-parsley.noarch: W: spelling-error %description -l en_US yacc -> yak, Yacc, ya cc The value of this tag appears to be misspelled. Please double-check. python-parsley.noarch: I: checking-url https://launchpad.net/parsley (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 3 warnings. APPROVED
New Package SCM Request ======================= Package Name: python-parsley Short Description: Parsing and pattern matching made easy Upstream URL: https://launchpad.net/parsley Owners: robyduck Branches: f20 f21
Git done (by process-git-requests).
python-parsley-1.2-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-parsley-1.2-3.fc20
python-parsley-1.2-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-parsley-1.2-3.fc21
python-parsley-1.2-3.fc20 has been pushed to the Fedora 20 testing repository.
python-parsley-1.2-3.fc21 has been pushed to the Fedora 21 stable repository.
python-parsley-1.2-3.fc20 has been pushed to the Fedora 20 stable repository.