Bug 1180058 (plasma-nm) - Review Request: plasma-nm - Plasma applet for managing network connections
Summary: Review Request: plasma-nm - Plasma applet for managing network connections
Keywords:
Status: CLOSED RAWHIDE
Alias: plasma-nm
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
Rex Dieter
URL:
Whiteboard:
Depends On:
Blocks: plasma5
TreeView+ depends on / blocked
 
Reported: 2015-01-08 09:17 UTC by Jan Grulich
Modified: 2015-01-20 13:44 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-01-20 13:44:05 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jan Grulich 2015-01-08 09:17:38 UTC
Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-nm.spec
SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-nm-5.1.2-2.fc21.src.rpm
Description: Plasma applet for managing network connections
Fedora Account System Username: jgrulich

Comment 1 Rex Dieter 2015-01-12 13:21:44 UTC
A rename review of existing kde-plasma-nm package, so should be pretty straight-forward.

sources: ok
85bcbb4dc40ff020a566413a209858ca  plasma-nm-5.1.2.tar.xz


Upgrade path: ok
Obsoletes: kde-plasma-networkmanagement < 1:0.9.1.0
Obsoletes: kde-plasma-networkmanagement-libs < 1:0.9.1.0
Obsoletes: kde-plasma-nm < 5.0.0-1

1.  SHOULD consider adding Provides: at least for kde-plasma-nm, e.g.
Provides = kde-plasma-nm = %{version}-%{release}

2.  SHOULD re-add this snippet in -mobile pkg from kde-plasma-nm:
%if 0%{?fedora} > 20
Requires:  NetworkManager-wwan >= 0.9.8
%endif


Otherwise, looks good, APPROVED

Comment 2 Daniel Vrátil 2015-01-16 11:21:28 UTC
Jan, ping?

Comment 3 Jan Grulich 2015-01-16 12:20:09 UTC
New Package SCM Request
=======================
Package Name: plasma-nm
Short Description: Plasma applet for managing network connections
Upstream URL: https://projects.kde.org/projects/kde/workspace/plasma-nm
Owners: group::kde-sig
Branches: f20 f21
InitialCC:

Comment 4 Gwyn Ciesla 2015-01-16 13:15:54 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.