Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
When the fs pool target has been mounted, the inactive fs pool always autostarts while libvirtd starts up. It does not check whether the source /proc/mounts matches the source device in fs pool xml. The pool starts up even though using null as the source device in fs pool config xml.
Version-Release number of selected component (if applicable):
libvirt-1.2.8-12.el7.x86_64
How reproducible:
100%
Steps to Reproduce:
1. Prepare an inactive fs pool
# virsh pool-list --all
Name State Autostart
-------------------------------------------
fs inactive no
2. # virsh pool-dumpxml fs
<pool type='fs'>
<name>fs</name>
<uuid>93709095-8f44-45ad-a2c9-15fc5e2cd410</uuid>
<capacity unit='bytes'>75125227520</capacity>
<allocation unit='bytes'>58557726720</allocation>
<available unit='bytes'>16567500800</available>
<source>
<device path='/dev/sdc'/> OR <device path=''/>----> here using null as device
<format type='xfs'/>
</source>
<target>
<path>/tmp/fs</path>
<permissions>
<mode>0755</mode>
<owner>-1</owner>
<group>-1</group>
</permissions>
</target>
</pool>
3. mount a nfs server to /tmp/fs
# mount $ip:/var/lib/libvirt/images/ /tmp/fs
#mount
$ip:/var/lib/libvirt/images on /tmp/fs type nfs4 (rw,relatime,vers=4.0,
rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,
retrans=2,sec=sys,clientaddr=$ip,local_lock=none,addr=$ip)
4. restart libvirtd
# service libvirtd restart
Redirecting to /bin/systemctl restart libvirtd.service
# virsh pool-list --all
Name State Autostart
-------------------------------------------
fs active no
Actual Results:
the fs pool always starts up while libvirtd starts
Expected results:
Additional info:
Following info from Daniel,
that sounds like libvirt needs todo strict validation before
marking the pool as active. I guess we only check whether the
target directory is present in /proc/mounts. We'll need to add
a check on the source in /proc/mounts too.
Description of problem: When the fs pool target has been mounted, the inactive fs pool always autostarts while libvirtd starts up. It does not check whether the source /proc/mounts matches the source device in fs pool xml. The pool starts up even though using null as the source device in fs pool config xml. Version-Release number of selected component (if applicable): libvirt-1.2.8-12.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1. Prepare an inactive fs pool # virsh pool-list --all Name State Autostart ------------------------------------------- fs inactive no 2. # virsh pool-dumpxml fs <pool type='fs'> <name>fs</name> <uuid>93709095-8f44-45ad-a2c9-15fc5e2cd410</uuid> <capacity unit='bytes'>75125227520</capacity> <allocation unit='bytes'>58557726720</allocation> <available unit='bytes'>16567500800</available> <source> <device path='/dev/sdc'/> OR <device path=''/>----> here using null as device <format type='xfs'/> </source> <target> <path>/tmp/fs</path> <permissions> <mode>0755</mode> <owner>-1</owner> <group>-1</group> </permissions> </target> </pool> 3. mount a nfs server to /tmp/fs # mount $ip:/var/lib/libvirt/images/ /tmp/fs #mount $ip:/var/lib/libvirt/images on /tmp/fs type nfs4 (rw,relatime,vers=4.0, rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600, retrans=2,sec=sys,clientaddr=$ip,local_lock=none,addr=$ip) 4. restart libvirtd # service libvirtd restart Redirecting to /bin/systemctl restart libvirtd.service # virsh pool-list --all Name State Autostart ------------------------------------------- fs active no Actual Results: the fs pool always starts up while libvirtd starts Expected results: Additional info: Following info from Daniel, that sounds like libvirt needs todo strict validation before marking the pool as active. I guess we only check whether the target directory is present in /proc/mounts. We'll need to add a check on the source in /proc/mounts too.