RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1180201 - neutron-netns-cleanup.service needs RemainAfterExit=yes and PrivateTmp=false
Summary: neutron-netns-cleanup.service needs RemainAfterExit=yes and PrivateTmp=false
Keywords:
Status: CLOSED EOL
Alias: None
Product: RDO
Classification: Community
Component: openstack-neutron
Version: trunk
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: Juno
Assignee: lpeer
QA Contact: Ofer Blaut
URL:
Whiteboard:
Depends On: 1147153
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-08 15:38 UTC by Miguel Angel Ajo
Modified: 2016-05-19 15:31 UTC (History)
7 users (show)

Fixed In Version:
Clone Of: 1147153
Environment:
Last Closed: 2016-05-19 15:31:16 UTC
Embargoed:


Attachments (Terms of Use)

Description Miguel Angel Ajo 2015-01-08 15:38:23 UTC
We need to patch the service file like this, 
so the service remains active after started, and so that
stop cleans up forced.

commit 8a6c398f55aa74ea7c8b8d1d59db1acb65996c9e
Author: Miguel Angel Ajo <mangelajo>
Date:   Thu Jan 8 16:21:11 2015 +0100

    Fix the network namespace cleanup script to match the OCF resource
    
    start cleans up, stop cleans up forced, and it remains
    active as a service (even if it's not) in between. rhbz#1147153
    
    Set PrivateTmp in neutron-netns-cleanup-service as false, true
    prevents the cleanup script from working correctly.
    
    Resolves: rhbz#1147153
    
    Change-Id: I15839088c0089c644ae44d393ac485decbb930a8

diff --git a/neutron-netns-cleanup.service b/neutron-netns-cleanup.service
index e097cce..f56f595 100644
--- a/neutron-netns-cleanup.service
+++ b/neutron-netns-cleanup.service
@@ -7,7 +7,9 @@ Before=neutron-openvswitch-agent.service neutron-dhcp-agent.service neutron-l3-a
 Type=oneshot
 User=neutron
 ExecStart=/usr/bin/neutron-netns-cleanup --config-file /usr/share/neutron/neutron-dist.conf --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/dhcp_agent.ini --log-file /var/log/neutron/netns-cleanup.log
-PrivateTmp=true
+ExecStop=/usr/bin/neutron-netns-cleanup --config-file /usr/share/neutron/neutron-dist.conf --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/dhcp_agent.ini --log-file /var/log/neutron/netns-cleanup.log --force
+
+PrivateTmp=false
 
 [Install]
 WantedBy=multi-user.target
diff --git a/openstack-neutron.spec b/openstack-neutron.spec
index f5e9d43..d34ac77 100644
--- a/openstack-neutron.spec
+++ b/openstack-neutron.spec
@@ -2,7 +2,7 @@
 
 Name:		openstack-neutron
 Version:	2014.1.3
-Release:	13%{?dist}
+Release:	14%{?dist}
 Provides:	openstack-quantum = %{version}-%{release}
 Obsoletes:	openstack-quantum < 2013.2-0.4.b3
 Summary:	OpenStack Networking Service
@@ -1097,6 +1097,13 @@ fi
 
 
 %changelog
+* Thu Jan 8 2015 Miguel Ángel Ajo <mangelajo> 2014.1.3-14
+- Fix neutron-netns-cleanup service to match the OCF resource
+  behavior, start cleans up, stop cleans up forced, and it remains
+  active as a service (even if it's not) in between. rhbz#1147153
+- Set PrivateTmp in neutron-netns-cleanup-service as false, true
+  prevents the cleanup script from working correctly.
+
 * Wed Jan 7 2015 Miguel Ángel Ajo <mangelajo> 2014.1.3-13
 - Enable process monitor for dhcp-agent and l3-agent by default.
   rhbz#1172054

Comment 1 Chandan Kumar 2016-05-19 15:31:16 UTC
This bug is against a Version which has reached End of Life.
If it's still present in supported release (http://releases.openstack.org), please update Version and reopen.


Note You need to log in before you can comment on or make changes to this bug.