Spec URL: http://petersen.fedorapeople.org//ghc-JuicyPixels.spec SRPM URL: http://petersen.fedorapeople.org//ghc-JuicyPixels-3.2.1-1.fc21.src.rpm Description: This library can load and store images in PNG, Bitmap, Jpeg, Radiance, Tiff and Gif images.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8568111
There is a newer 3.2.2 release but it is just for ghc-7.10 warnings. http://hdiff.luite.com/cgit/JuicyPixels/diff/changelog?id=ede304035db0c6d800ae7668bec4c95bc697ea03
APPROVED, with two things to fix on import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= ghc-JuicyPixels.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ghc-JuicyPixels/LICENSE [!]: Latest version is packaged. (Please fix these on import.) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Haskell: [x]: This should never happen ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3594240 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-JuicyPixels-3.2.1-1.fc21.x86_64.rpm ghc-JuicyPixels-devel-3.2.1-1.fc21.x86_64.rpm ghc-JuicyPixels-3.2.1-1.fc21.src.rpm ghc-JuicyPixels.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ghc-JuicyPixels/LICENSE 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- <mock-chroot>[root@t520 /]# rpmlint ghc-JuicyPixels ghc-JuicyPixels-devel ghc-JuicyPixels.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ghc-JuicyPixels/LICENSE 2 packages and 0 specfiles checked; 0 errors, 1 warnings. <mock-chroot>[root@t520 /]# echo 'rpmlint-done:' Requires -------- ghc-JuicyPixels (rpmlib, GLIBC filtered): ghc(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc(binary-0.5.1.1-72ed744c57c32286a49da6dda4f660b7) ghc(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f) ghc(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2) ghc(deepseq-1.3.0.1-5cc4cd89bdc2e8f6db1833d95ec36926) ghc(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b) ghc(primitive-0.5.0.1-8e5f40b409f7bb31ae1acfb125279700) ghc(transformers-0.3.0.0-387c76a892254b0b8fe4d66f4780ad17) ghc(vector-0.10.0.1-869166d5d49db46ce6c328ea5f8defbf) ghc(zlib-0.5.4.1-13ba81ac0d7e6f3bdf1ee5ddce4e9aab) libHSarray-0.4.0.1-ghc7.6.3.so()(64bit) libHSbase-4.6.0.1-ghc7.6.3.so()(64bit) libHSbinary-0.5.1.1-ghc7.6.3.so()(64bit) libHSbytestring-0.10.0.2-ghc7.6.3.so()(64bit) libHScontainers-0.5.0.0-ghc7.6.3.so()(64bit) libHSdeepseq-1.3.0.1-ghc7.6.3.so()(64bit) libHSghc-prim-0.3.0.0-ghc7.6.3.so()(64bit) libHSinteger-gmp-0.5.0.0-ghc7.6.3.so()(64bit) libHSmtl-2.1.2-ghc7.6.3.so()(64bit) libHSprimitive-0.5.0.1-ghc7.6.3.so()(64bit) libHStransformers-0.3.0.0-ghc7.6.3.so()(64bit) libHSvector-0.10.0.1-ghc7.6.3.so()(64bit) libHSzlib-0.5.4.1-ghc7.6.3.so()(64bit) libc.so.6()(64bit) libgmp.so.10()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) ghc-JuicyPixels-devel (rpmlib, GLIBC filtered): /bin/sh ghc(JuicyPixels-3.2.1-45935135f0b9d9efdff428b1938cef3b) ghc-JuicyPixels(x86-64) ghc-compiler ghc-devel(base-4.6.0.1-8aa5d403c45ea59dcd2c39f123e27d57) ghc-devel(binary-0.5.1.1-72ed744c57c32286a49da6dda4f660b7) ghc-devel(bytestring-0.10.0.2-4f93248f75667c2c3321a7a6761b576f) ghc-devel(containers-0.5.0.0-ab1dae9a94cd3cc84e7b2805636ebfa2) ghc-devel(deepseq-1.3.0.1-5cc4cd89bdc2e8f6db1833d95ec36926) ghc-devel(mtl-2.1.2-82086cac9073862cbe01e44b81ec8b9b) ghc-devel(primitive-0.5.0.1-8e5f40b409f7bb31ae1acfb125279700) ghc-devel(transformers-0.3.0.0-387c76a892254b0b8fe4d66f4780ad17) ghc-devel(vector-0.10.0.1-869166d5d49db46ce6c328ea5f8defbf) ghc-devel(zlib-0.5.4.1-13ba81ac0d7e6f3bdf1ee5ddce4e9aab) Provides -------- ghc-JuicyPixels: ghc(JuicyPixels-3.2.1-45935135f0b9d9efdff428b1938cef3b) ghc-JuicyPixels ghc-JuicyPixels(x86-64) libHSJuicyPixels-3.2.1-ghc7.6.3.so()(64bit) ghc-JuicyPixels-devel: ghc-JuicyPixels-devel ghc-JuicyPixels-devel(x86-64) ghc-JuicyPixels-static ghc-devel(JuicyPixels-3.2.1-45935135f0b9d9efdff428b1938cef3b) Unversioned so-files -------------------- ghc-JuicyPixels: /usr/lib64/ghc-7.6.3/JuicyPixels-3.2.1/libHSJuicyPixels-3.2.1-ghc7.6.3.so Source checksums ---------------- https://hackage.haskell.org/package/JuicyPixels-3.2.1/JuicyPixels-3.2.1.tar.gz : CHECKSUM(SHA256) this package : 30976e462dd14a1fb4cefbc9841c612f7621445ac1107dd37c7ce5d54a9d002b CHECKSUM(SHA256) upstream package : 30976e462dd14a1fb4cefbc9841c612f7621445ac1107dd37c7ce5d54a9d002b Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1180460 Buildroot used: fedora-21-x86_64 Active plugins: Generic, Haskell, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thank for reviewing the package: I will fix the points you mentioned at import. New Package SCM Request ======================= Package Name: ghc-JuicyPixels Short Description: Picture loading and serialization Upstream URL: https://hackage.haskell.org/package/JuicyPixels Owners: petersen codeblock Branches: f21 f20 epel7 InitialCC: haskell-sig
Git done (by process-git-requests).
ghc-JuicyPixels-3.2.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/ghc-JuicyPixels-3.2.2-1.fc21
ghc-JuicyPixels-3.2.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-JuicyPixels-3.2.2-1.fc20
ghc-JuicyPixels-3.2.2-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-JuicyPixels-3.2.2-1.el7
Currently leaving the rawhide build for f22-ghc.
ghc-JuicyPixels-3.2.2-1.fc20 has been pushed to the Fedora 20 testing repository.
ghc-JuicyPixels-3.2.2-1.fc21 has been pushed to the Fedora 21 stable repository.
ghc-JuicyPixels-3.2.2-1.fc20 has been pushed to the Fedora 20 stable repository.
ghc-JuicyPixels-3.2.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository.