Bug 1181365 - Review Request: ice - ZeroC Object-Oriented middleware (un-retire)
Summary: Review Request: ice - ZeroC Object-Oriented middleware (un-retire)
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Sergio Durigan Junior
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: FE-DEADREVIEW 1181366 mumble
TreeView+ depends on / blocked
 
Reported: 2015-01-13 02:01 UTC by Carlos O'Donell
Modified: 2015-11-24 16:56 UTC (History)
15 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2015-11-24 16:56:36 UTC


Attachments (Terms of Use)
ice.spec (32.03 KB, text/x-matlab)
2015-01-14 01:50 UTC, Carlos O'Donell
no flags Details
ice-3.5.1-14.fc22.src.rpm (4.60 MB, application/x-rpm)
2015-01-14 01:51 UTC, Carlos O'Donell
no flags Details

Description Carlos O'Donell 2015-01-13 02:01:08 UTC
https://admin.fedoraproject.org/pkgdb/package/ice/
Fedora Account System Username: codonell

This is a package review request to un-retire Ice. I need Ice to build and support mumble in Fedora 21 and Fedora Rawhide. I have already patched Ice to build on F21.

I have emailed devel [1] to determine why Ice was orphaned. Mumble was orphaned and retired because without ice-devel it doesn't build (well it might if you removed the dependencies on Ice, but that's harder to do).

[1] https://lists.fedoraproject.org/pipermail/devel/2015-January/206378.html

Comment 1 Christian Krause 2015-01-13 20:56:42 UTC
Please can you provide the updated spec file and the srpm for the review?

Comment 2 Carlos O'Donell 2015-01-13 21:46:05 UTC
(In reply to Christian Krause from comment #1)
> Please can you provide the updated spec file and the srpm for the review?

It looks like Dan Horák already has f22 and f21 builds of the package with lots more fixes than I have:

https://koji.fedoraproject.org/koji/buildinfo?buildID=582314
https://koji.fedoraproject.org/koji/buildinfo?buildID=582315

What I don't understand is why is the package still orpahned and why are Dan's build not accessible?

Dan, What's the status?

Comment 3 Carlos O'Donell 2015-01-14 01:49:51 UTC
(In reply to Carlos O'Donell from comment #2)
> (In reply to Christian Krause from comment #1)
> > Please can you provide the updated spec file and the srpm for the review?
> 
> It looks like Dan Horák already has f22 and f21 builds of the package with
> lots more fixes than I have:
> 
> https://koji.fedoraproject.org/koji/buildinfo?buildID=582314
> https://koji.fedoraproject.org/koji/buildinfo?buildID=582315
> 
> What I don't understand is why is the package still orpahned and why are
> Dan's build not accessible?
> 
> Dan, What's the status?

Looks like just mass rebuilds.

Comment 4 Carlos O'Donell 2015-01-14 01:50:25 UTC
Created attachment 979823 [details]
ice.spec

Comment 5 Carlos O'Donell 2015-01-14 01:51:46 UTC
Created attachment 979824 [details]
ice-3.5.1-14.fc22.src.rpm

Comment 6 Carlos O'Donell 2015-01-14 01:54:04 UTC
(In reply to Christian Krause from comment #1)
> Please can you provide the updated spec file and the srpm for the review?

Updated spec and srpm attached for f22.

Comment 7 Haïkel Guémar 2015-01-18 15:47:33 UTC
@Carlos: I retired Ice because of an irrespectful individual from ARM SIG.
Before retiring the package, I offered my fellow co-maintainers and mumble co-maintainers to pick up Ice, since I didn't get any answers, I orphaned it.

If you want to blame someone, blame people insulting maintainers who maintains packages on their *free time* on irc.

Comment 8 Carlos O'Donell 2015-01-19 14:31:51 UTC
(In reply to Haïkel Guémar from comment #7)
> @Carlos: I retired Ice because of an irrespectful individual from ARM SIG.
> Before retiring the package, I offered my fellow co-maintainers and mumble
> co-maintainers to pick up Ice, since I didn't get any answers, I orphaned it.

I'm sorry to hear that you were not treated in a respectful and professional manner.
 
> If you want to blame someone, blame people insulting maintainers who
> maintains packages on their *free time* on irc.

I'm not looking to blame anyone. I appreciate you coming forward to explain why Ice was orphaned. Your explanation is important becuase it indicates that Ice was not orphaned for any serious technical issues which would be difficult to overcome.

I appreciate your work on Fedora, and my submission to revive Ice is simply becuase I have an interest in keeping mumble working.

Thank you for your time.

Comment 9 Andrew Dunn 2015-02-03 15:42:17 UTC
I'd like to voice support for Carlos as I would like to see mumble working in the fedora repositories. I've installed mumble from this repository in the meantime: https://copr.fedoraproject.org/coprs/lkiesow/mumble/

Comment 10 Sergio Durigan Junior 2015-03-05 23:51:29 UTC
FWIW I took the liberty of running fedora-review against the provided SRPM, and I found some things there.  This is not an official review, btw.

Package Review
==============
 
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
 
 
Issues:
=======
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in icegrid-gui
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- This seems like a Java package, please install fedora-review-plugin-java to
  get additional checks
- Package do not use a name that already exist
  Note: A package already exist with this name, please check
  https://admin.fedoraproject.org/pkgdb/acls/name/ice
  See:
  https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'
- Package uses hardened build flags if required to.
  Note: Systemd files (daemon?): glacier2router.service, icegridnode.service,
  icegridregistry.service and not %global _hardened_build
  See:
  http://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags
 
 
===== MUST items =====
 
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
 
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (3 clause)", "GPL (v3 or later)", "Unknown or generated",
     "zlib/libpng". 3351 files have unknown license. Detailed output of
     licensecheck in /tmp/ice-review/ice/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/48x48/apps,
     /lib/systemd, /usr/share/java, /lib/systemd/system
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 133120 bytes in 5 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
     file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
 
Python:
[ ]: Python eggs must not download any dependencies during the build process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
 
===== SHOULD items =====
 
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[ ]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ice-devel ,
     ice-java-devel , icegrid-gui , ice-csharp-devel , ice-ruby-devel , ice-
     python-devel , ice-php-devel
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[ ]: Scriptlets must be sane, if used.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
 
===== EXTRA items =====
 
Generic:
[ ]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Arch-ed rpms have a total of 5775360 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
 
 
Rpmlint
-------
Checking: ice-3.5.1-14.fc21.x86_64.rpm
          ice-servers-3.5.1-14.fc21.x86_64.rpm
          ice-devel-3.5.1-14.fc21.x86_64.rpm
          ice-java-3.5.1-14.fc21.x86_64.rpm
          ice-java-devel-3.5.1-14.fc21.x86_64.rpm
          icegrid-gui-3.5.1-14.fc21.x86_64.rpm
          ice-csharp-3.5.1-14.fc21.x86_64.rpm
          ice-csharp-devel-3.5.1-14.fc21.x86_64.rpm
          ice-ruby-3.5.1-14.fc21.x86_64.rpm
          ice-ruby-devel-3.5.1-14.fc21.x86_64.rpm
          ice-python-3.5.1-14.fc21.x86_64.rpm
          ice-python-devel-3.5.1-14.fc21.x86_64.rpm
          ice-php-3.5.1-14.fc21.x86_64.rpm
          ice-php-devel-3.5.1-14.fc21.x86_64.rpm
          ice-3.5.1-14.fc21.src.rpm
ice.x86_64: W: spelling-error Summary(en_US) ZeroC -> Zero C, Zero, Zeros
ice.x86_64: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
ice.x86_64: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
ice.x86_64: W: shared-lib-calls-exit /usr/lib64/libSlice.so.35 exit@GLIBC_2.2.5
ice.x86_64: W: shared-lib-calls-exit /usr/lib64/libSlice.so.3.5.1 exit@GLIBC_2.2.5
ice.x86_64: W: manual-page-warning /usr/share/man/man1/icegridadmin.1.gz 48: a special character is not allowed in a name
ice.x86_64: W: manual-page-warning /usr/share/man/man1/transformdb.1.gz 9: warning: macro `p' not defined
ice-servers.x86_64: W: no-documentation
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceStormFreezeDB.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceGridFreezeDB.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceStormService.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceGrid.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceBox.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libGlacier2.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceStorm.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIcePatch2.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIce.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceSSL.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libFreeze.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libSlice.so
ice-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libSlice.so exit@GLIBC_2.2.5
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceDB.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceXML.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceUtil.so
ice-java.x86_64: E: explicit-lib-dependency libdb4-java(x86-64)
ice-java.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-java.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-java.x86_64: W: no-documentation
icegrid-gui.x86_64: W: no-documentation
icegrid-gui.x86_64: W: no-manual-page-for-binary icegridgui
icegrid-gui.x86_64: W: class-path-in-manifest /usr/share/java/IceGridGUI.jar
ice-csharp.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-csharp.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-csharp.x86_64: W: only-non-binary-in-usr-lib
ice-csharp.x86_64: W: no-manual-page-for-binary iceboxnet.exe
ice-csharp-devel.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice-csharp-devel.x86_64: W: only-non-binary-in-usr-lib
ice-ruby.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-ruby.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-ruby.x86_64: W: no-documentation
ice-ruby-devel.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice-python.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-python.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-python.x86_64: W: no-documentation
ice-python-devel.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice-php.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-php.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice-php.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-php.x86_64: W: no-documentation
ice-php-devel.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice.src: W: spelling-error Summary(en_US) ZeroC -> Zero C, Zero, Zeros
ice.src: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
ice.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
ice.src:1: E: hardcoded-library-path in /lib/systemd/system
ice.src:241: E: hardcoded-library-path in %{_prefix}/lib
ice.src:245: E: hardcoded-library-path in %{buildroot}/lib/*.jar
ice.src:284: E: hardcoded-library-path in %{buildroot}/lib/pkgconfig/*.pc
ice.src:290: E: hardcoded-library-path in %{buildroot}/lib/ImportKey.class
ice.src:291: E: hardcoded-library-path in %{buildroot}/lib
ice.src:303: E: hardcoded-library-path in %{buildroot}/usr/lib/mono/$f/$f.xml
ice.src:304: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/$f/%{version}.*/
ice.src:306: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/$f/%{version}.*/*.xml
ice.src:481: E: hardcoded-library-path in %{_prefix}/lib/mono/Glacier2/
ice.src:482: E: hardcoded-library-path in %{_prefix}/lib/mono/Ice/
ice.src:483: E: hardcoded-library-path in %{_prefix}/lib/mono/IceBox/
ice.src:484: E: hardcoded-library-path in %{_prefix}/lib/mono/IceGrid/
ice.src:485: E: hardcoded-library-path in %{_prefix}/lib/mono/IcePatch2/
ice.src:486: E: hardcoded-library-path in %{_prefix}/lib/mono/IceStorm/
ice.src:487: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/Glacier2
ice.src:488: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/Ice
ice.src:489: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/IceBox
ice.src:490: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/IceGrid
ice.src:491: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/IcePatch2
ice.src:492: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/IceStorm
ice.src:493: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/policy.*
ice.src:43: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 43)
15 packages and 0 specfiles checked; 38 errors, 38 warnings.
 
 
 
 
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
 
 
Requires
--------
ice-ruby (rpmlib, GLIBC filtered):
    ice(x86-64)
    libIce.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libruby.so.2.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)
    ruby(release)
 
ice-devel (rpmlib, GLIBC filtered):
    ice
    libFreeze.so.35()(64bit)
    libGlacier2.so.35()(64bit)
    libIce.so.35()(64bit)
    libIceBox.so.35()(64bit)
    libIceDB.so.35()(64bit)
    libIceGrid.so.35()(64bit)
    libIceStorm.so.35()(64bit)
    libIceStormService.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libbz2.so.1()(64bit)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libdb_cxx-4.8.so()(64bit)
    libdl.so.2()(64bit)
    libexpat.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmcpp.so.0()(64bit)
    libpthread.so.0()(64bit)
    librt.so.1()(64bit)
    libssl.so.10()(64bit)
    libssl.so.10(libssl.so.10)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)
 
ice-python (rpmlib, GLIBC filtered):
    ice(x86-64)
    libIce.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    python
    python(abi)
    rtld(GNU_HASH)
 
ice-php (rpmlib, GLIBC filtered):
    config(ice-php)
    ice(x86-64)
    libIce.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    php(api)
    php(zend-abi)
    rtld(GNU_HASH)
 
ice-php-devel (rpmlib, GLIBC filtered):
    ice-php(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)
 
ice-java (rpmlib, GLIBC filtered):
    ice(x86-64)
    java-headless
    libdb4-java(x86-64)
 
ice-ruby-devel (rpmlib, GLIBC filtered):
    ice-ruby(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)
 
ice (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    /usr/bin/env
    libFreeze.so.35()(64bit)
    libGlacier2.so.35()(64bit)
    libIce.so.35()(64bit)
    libIceBox.so.35()(64bit)
    libIceDB.so.35()(64bit)
    libIceGrid.so.35()(64bit)
    libIcePatch2.so.35()(64bit)
    libIceSSL.so.35()(64bit)
    libIceStorm.so.35()(64bit)
    libIceStormService.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libIceXML.so.35()(64bit)
    libSlice.so.35()(64bit)
    libbz2.so.1()(64bit)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libdb_cxx-4.8.so()(64bit)
    libdl.so.2()(64bit)
    libexpat.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmcpp.so.0()(64bit)
    libpthread.so.0()(64bit)
    librt.so.1()(64bit)
    libssl.so.10()(64bit)
    libssl.so.10(libssl.so.10)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)
 
ice-python-devel (rpmlib, GLIBC filtered):
    ice-python(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)
 
ice-servers (rpmlib, GLIBC filtered):
    /bin/sh
    config(ice-servers)
    ice(x86-64)
    shadow-utils
    systemd
 
ice-java-devel (rpmlib, GLIBC filtered):
    ice-java(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)
 
ice-csharp-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    ice-csharp(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    pkgconfig(Ice)
    rtld(GNU_HASH)
 
icegrid-gui (rpmlib, GLIBC filtered):
    /bin/sh
    ice-java(x86-64)
    java
    jgoodies-common
    jgoodies-forms
    jgoodies-looks
    jpackage-utils
 
ice-csharp (rpmlib, GLIBC filtered):
    ice(x86-64)
    mono(Glacier2)
    mono(Ice)
    mono(IceBox)
    mono(System)
    mono(System.Core)
    mono(mscorlib)
    mono-core(x86-64)
 
 
 
Provides
--------
ice-ruby:
    ice-ruby
    ice-ruby(x86-64)
 
ice-devel:
    ice-c++-devel
    ice-devel
    ice-devel(x86-64)
    libFreeze.so.35()(64bit)
    libGlacier2.so.35()(64bit)
    libIce.so.35()(64bit)
    libIceBox.so.35()(64bit)
    libIceDB.so.35()(64bit)
    libIceGrid.so.35()(64bit)
    libIceGridFreezeDB.so.35()(64bit)
    libIcePatch2.so.35()(64bit)
    libIceSSL.so.35()(64bit)
    libIceStorm.so.35()(64bit)
    libIceStormFreezeDB.so.35()(64bit)
    libIceStormService.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libIceXML.so.35()(64bit)
    libSlice.so.35()(64bit)
 
ice-python:
    ice-python
    ice-python(x86-64)
 
ice-php:
    config(ice-php)
    ice-php
    ice-php(x86-64)
    php-ice
    php-ice(x86-64)
 
ice-php-devel:
    ice-php-devel
    ice-php-devel(x86-64)
 
ice-java:
    ice-java
    ice-java(x86-64)
 
ice-ruby-devel:
    ice-ruby-devel
    ice-ruby-devel(x86-64)
 
ice:
    ice
    ice(x86-64)
    libFreeze.so.35()(64bit)
    libGlacier2.so.35()(64bit)
    libIce.so.35()(64bit)
    libIceBox.so.35()(64bit)
    libIceDB.so.35()(64bit)
    libIceGrid.so.35()(64bit)
    libIceGridFreezeDB.so.35()(64bit)
    libIcePatch2.so.35()(64bit)
    libIceSSL.so.35()(64bit)
    libIceStorm.so.35()(64bit)
    libIceStormFreezeDB.so.35()(64bit)
    libIceStormService.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libIceXML.so.35()(64bit)
    libSlice.so.35()(64bit)
 
ice-python-devel:
    ice-python-devel
    ice-python-devel(x86-64)
 
ice-servers:
    config(ice-servers)
    ice-servers
    ice-servers(x86-64)
 
ice-java-devel:
    ice-java-devel
    ice-java-devel(x86-64)
 
ice-csharp-devel:
    ice-csharp-devel
    ice-csharp-devel(x86-64)
    pkgconfig(Glacier2)
    pkgconfig(Ice)
    pkgconfig(IceBox)
    pkgconfig(IceGrid)
    pkgconfig(IcePatch2)
    pkgconfig(IceStorm)
 
icegrid-gui:
    application()
    application(IceGridAdmin.desktop)
    icegrid-gui
    icegrid-gui(x86-64)
 
ice-csharp:
    ice-csharp
    ice-csharp(x86-64)
    ice-dotnet
    mono(Glacier2)
    mono(Ice)
    mono(IceBox)
    mono(IceGrid)
    mono(IcePatch2)
    mono(IceStorm)
    mono(iceboxnet)
    mono(policy.3.5.Glacier2)
    mono(policy.3.5.Ice)
    mono(policy.3.5.IceBox)
    mono(policy.3.5.IceGrid)
    mono(policy.3.5.IcePatch2)
    mono(policy.3.5.IceStorm)
 
 
 
Unversioned so-files
--------------------
ice-ruby: /usr/lib64/ruby/vendor_ruby/IceRuby.so
ice-python: /usr/lib64/python2.7/site-packages/Ice/IcePy.so
ice-php: /usr/lib64/php/modules/IcePHP.so
 
Source checksums
----------------
http://zeroc.com/download/Ice/3.5/Ice-3.5.1.tar.gz :
  CHECKSUM(SHA256) this package     : 989e51194c6adadbd156da3288e37bad847b93b3b876502e83033b70493af392
  CHECKSUM(SHA256) upstream package : 989e51194c6adadbd156da3288e37bad847b93b3b876502e83033b70493af392
 
 
Jar and class files in source
-----------------------------
./Ice-3.5.1/cpp/src/ca/ImportKey.class
./Ice-3.5.1/certs/ImportKey.class
./Ice-3.5.1/java/test/Ice/timeout/timeout.jar
 
 
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/bin/fedora-review -rn ./ice-3.5.1-14.fc22.src.rpm
Buildroot used: fedora-21-x86_64
Active plugins: Python, Shell-api, Generic, Java, C/C++
Disabled plugins: fonts, SugarActivity, Ocaml, Haskell, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 11 Sergio Durigan Junior 2015-03-29 06:49:27 UTC
Right, so here's an almost-full package review.  Few items have been marked as "?" because I did not investigate them deeper (so I feel uncomfortable in marking them as a pass).  I don't see any real issue with this package, just a few things that need to/could be improved.  Other than that, I am willing to mark it as fedora-review+ when we address the issues.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in icegrid-gui
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'
- Package uses hardened build flags if required to.
  Note: Systemd files (daemon?): glacier2router.service, icegridnode.service,
  icegridregistry.service and not %global _hardened_build
  See:
  http://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

     COMMENT: I believe one should revisit the code to install the libraries,
     it seems strange (too mechanical) to me, but I did not investigate
     deeper.

[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (3 clause)", "GPL (v3 or later)", "Unknown or generated",
     "zlib/libpng". 3351 files have unknown license. Detailed output of
     licensecheck in /tmp/ice-review/ice/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/48x48/apps,
     /lib/systemd, /usr/share/java, /lib/systemd/system
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 133120 bytes in 5 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
     file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[?]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ice-devel ,
     ice-java-devel , icegrid-gui , ice-csharp-devel , ice-ruby-devel , ice-
     python-devel , ice-php-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
     Note: Arch-ed rpms have a total of 5765120 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: ice-3.5.1-14.fc21.x86_64.rpm
          ice-servers-3.5.1-14.fc21.x86_64.rpm
          ice-devel-3.5.1-14.fc21.x86_64.rpm
          ice-java-3.5.1-14.fc21.x86_64.rpm
          ice-java-devel-3.5.1-14.fc21.x86_64.rpm
          icegrid-gui-3.5.1-14.fc21.x86_64.rpm
          ice-csharp-3.5.1-14.fc21.x86_64.rpm
          ice-csharp-devel-3.5.1-14.fc21.x86_64.rpm
          ice-ruby-3.5.1-14.fc21.x86_64.rpm
          ice-ruby-devel-3.5.1-14.fc21.x86_64.rpm
          ice-python-3.5.1-14.fc21.x86_64.rpm
          ice-python-devel-3.5.1-14.fc21.x86_64.rpm
          ice-php-3.5.1-14.fc21.x86_64.rpm
          ice-php-devel-3.5.1-14.fc21.x86_64.rpm
          ice-3.5.1-14.fc21.src.rpm
ice.x86_64: W: spelling-error Summary(en_US) ZeroC -> Zero C, Zero, Zeros
ice.x86_64: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
ice.x86_64: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
ice.x86_64: W: shared-lib-calls-exit /usr/lib64/libSlice.so.35 exit@GLIBC_2.2.5
ice.x86_64: W: shared-lib-calls-exit /usr/lib64/libSlice.so.3.5.1 exit@GLIBC_2.2.5
ice.x86_64: W: manual-page-warning /usr/share/man/man1/icegridadmin.1.gz 48: a special character is not allowed in a name
ice.x86_64: W: manual-page-warning /usr/share/man/man1/transformdb.1.gz 9: warning: macro `p' not defined
ice-servers.x86_64: W: no-documentation
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceStormFreezeDB.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceGridFreezeDB.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceStormService.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceGrid.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceBox.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libGlacier2.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceStorm.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIcePatch2.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIce.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceSSL.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libFreeze.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libSlice.so
ice-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libSlice.so exit@GLIBC_2.2.5
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceDB.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceXML.so
ice-devel.x86_64: E: no-ldconfig-symlink /usr/lib64/libIceUtil.so
ice-java.x86_64: E: explicit-lib-dependency libdb4-java(x86-64)
ice-java.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-java.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-java.x86_64: W: no-documentation
icegrid-gui.x86_64: W: no-documentation
icegrid-gui.x86_64: W: no-manual-page-for-binary icegridgui
icegrid-gui.x86_64: W: class-path-in-manifest /usr/share/java/IceGridGUI.jar
ice-csharp.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-csharp.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-csharp.x86_64: W: only-non-binary-in-usr-lib
ice-csharp.x86_64: W: no-manual-page-for-binary iceboxnet.exe
ice-csharp-devel.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice-csharp-devel.x86_64: W: only-non-binary-in-usr-lib
ice-ruby.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-ruby.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-ruby.x86_64: W: no-documentation
ice-ruby-devel.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice-python.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-python.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-python.x86_64: W: no-documentation
ice-python-devel.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice-php.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment
ice-php.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice-php.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
ice-php.x86_64: W: no-documentation
ice-php-devel.x86_64: W: spelling-error Summary(en_US) developping -> developing, develop ping, develop-ping
ice.src: W: spelling-error Summary(en_US) ZeroC -> Zero C, Zero, Zeros
ice.src: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
ice.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
ice.src:1: E: hardcoded-library-path in /lib/systemd/system
ice.src:241: E: hardcoded-library-path in %{_prefix}/lib
ice.src:245: E: hardcoded-library-path in %{buildroot}/lib/*.jar
ice.src:284: E: hardcoded-library-path in %{buildroot}/lib/pkgconfig/*.pc
ice.src:290: E: hardcoded-library-path in %{buildroot}/lib/ImportKey.class
ice.src:291: E: hardcoded-library-path in %{buildroot}/lib
ice.src:303: E: hardcoded-library-path in %{buildroot}/usr/lib/mono/$f/$f.xml
ice.src:304: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/$f/%{version}.*/
ice.src:306: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/$f/%{version}.*/*.xml
ice.src:481: E: hardcoded-library-path in %{_prefix}/lib/mono/Glacier2/
ice.src:482: E: hardcoded-library-path in %{_prefix}/lib/mono/Ice/
ice.src:483: E: hardcoded-library-path in %{_prefix}/lib/mono/IceBox/
ice.src:484: E: hardcoded-library-path in %{_prefix}/lib/mono/IceGrid/
ice.src:485: E: hardcoded-library-path in %{_prefix}/lib/mono/IcePatch2/
ice.src:486: E: hardcoded-library-path in %{_prefix}/lib/mono/IceStorm/
ice.src:487: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/Glacier2
ice.src:488: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/Ice
ice.src:489: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/IceBox
ice.src:490: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/IceGrid
ice.src:491: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/IcePatch2
ice.src:492: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/IceStorm
ice.src:493: E: hardcoded-library-path in %{_prefix}/lib/mono/gac/policy.*
ice.src:43: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 43)
15 packages and 0 specfiles checked; 38 errors, 38 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
ice-ruby (rpmlib, GLIBC filtered):
    ice(x86-64)
    libIce.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libruby.so.2.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)
    ruby(release)

ice-devel (rpmlib, GLIBC filtered):
    ice
    libFreeze.so.35()(64bit)
    libGlacier2.so.35()(64bit)
    libIce.so.35()(64bit)
    libIceBox.so.35()(64bit)
    libIceDB.so.35()(64bit)
    libIceGrid.so.35()(64bit)
    libIceStorm.so.35()(64bit)
    libIceStormService.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libbz2.so.1()(64bit)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libdb_cxx-4.8.so()(64bit)
    libdl.so.2()(64bit)
    libexpat.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmcpp.so.0()(64bit)
    libpthread.so.0()(64bit)
    librt.so.1()(64bit)
    libssl.so.10()(64bit)
    libssl.so.10(libssl.so.10)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

ice-python (rpmlib, GLIBC filtered):
    ice(x86-64)
    libIce.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    python
    python(abi)
    rtld(GNU_HASH)

ice-php (rpmlib, GLIBC filtered):
    config(ice-php)
    ice(x86-64)
    libIce.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    php(api)
    php(zend-abi)
    rtld(GNU_HASH)

ice-php-devel (rpmlib, GLIBC filtered):
    ice-php(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

ice-java (rpmlib, GLIBC filtered):
    ice(x86-64)
    java-headless
    libdb4-java(x86-64)

ice-ruby-devel (rpmlib, GLIBC filtered):
    ice-ruby(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

ice (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    /usr/bin/env
    libFreeze.so.35()(64bit)
    libGlacier2.so.35()(64bit)
    libIce.so.35()(64bit)
    libIceBox.so.35()(64bit)
    libIceDB.so.35()(64bit)
    libIceGrid.so.35()(64bit)
    libIcePatch2.so.35()(64bit)
    libIceSSL.so.35()(64bit)
    libIceStorm.so.35()(64bit)
    libIceStormService.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libIceXML.so.35()(64bit)
    libSlice.so.35()(64bit)
    libbz2.so.1()(64bit)
    libc.so.6()(64bit)
    libcrypto.so.10()(64bit)
    libcrypto.so.10(libcrypto.so.10)(64bit)
    libdb_cxx-4.8.so()(64bit)
    libdl.so.2()(64bit)
    libexpat.so.1()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libmcpp.so.0()(64bit)
    libpthread.so.0()(64bit)
    librt.so.1()(64bit)
    libssl.so.10()(64bit)
    libssl.so.10(libssl.so.10)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

ice-python-devel (rpmlib, GLIBC filtered):
    ice-python(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

ice-servers (rpmlib, GLIBC filtered):
    /bin/sh
    config(ice-servers)
    ice(x86-64)
    shadow-utils
    systemd

ice-java-devel (rpmlib, GLIBC filtered):
    ice-java(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

ice-csharp-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    ice-csharp(x86-64)
    libIceUtil.so.35()(64bit)
    libSlice.so.35()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    pkgconfig(Ice)
    rtld(GNU_HASH)

icegrid-gui (rpmlib, GLIBC filtered):
    /bin/sh
    ice-java(x86-64)
    java
    jgoodies-common
    jgoodies-forms
    jgoodies-looks
    jpackage-utils

ice-csharp (rpmlib, GLIBC filtered):
    ice(x86-64)
    mono(Glacier2)
    mono(Ice)
    mono(IceBox)
    mono(System)
    mono(System.Core)
    mono(mscorlib)
    mono-core(x86-64)



Provides
--------
ice-ruby:
    ice-ruby
    ice-ruby(x86-64)

ice-devel:
    ice-c++-devel
    ice-devel
    ice-devel(x86-64)
    libFreeze.so.35()(64bit)
    libGlacier2.so.35()(64bit)
    libIce.so.35()(64bit)
    libIceBox.so.35()(64bit)
    libIceDB.so.35()(64bit)
    libIceGrid.so.35()(64bit)
    libIceGridFreezeDB.so.35()(64bit)
    libIcePatch2.so.35()(64bit)
    libIceSSL.so.35()(64bit)
    libIceStorm.so.35()(64bit)
    libIceStormFreezeDB.so.35()(64bit)
    libIceStormService.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libIceXML.so.35()(64bit)
    libSlice.so.35()(64bit)

ice-python:
    ice-python
    ice-python(x86-64)

ice-php:
    config(ice-php)
    ice-php
    ice-php(x86-64)
    php-ice
    php-ice(x86-64)

ice-php-devel:
    ice-php-devel
    ice-php-devel(x86-64)

ice-java:
    ice-java
    ice-java(x86-64)

ice-ruby-devel:
    ice-ruby-devel
    ice-ruby-devel(x86-64)

ice:
    ice
    ice(x86-64)
    libFreeze.so.35()(64bit)
    libGlacier2.so.35()(64bit)
    libIce.so.35()(64bit)
    libIceBox.so.35()(64bit)
    libIceDB.so.35()(64bit)
    libIceGrid.so.35()(64bit)
    libIceGridFreezeDB.so.35()(64bit)
    libIcePatch2.so.35()(64bit)
    libIceSSL.so.35()(64bit)
    libIceStorm.so.35()(64bit)
    libIceStormFreezeDB.so.35()(64bit)
    libIceStormService.so.35()(64bit)
    libIceUtil.so.35()(64bit)
    libIceXML.so.35()(64bit)
    libSlice.so.35()(64bit)

ice-python-devel:
    ice-python-devel
    ice-python-devel(x86-64)

ice-servers:
    config(ice-servers)
    ice-servers
    ice-servers(x86-64)

ice-java-devel:
    ice-java-devel
    ice-java-devel(x86-64)

ice-csharp-devel:
    ice-csharp-devel
    ice-csharp-devel(x86-64)
    pkgconfig(Glacier2)
    pkgconfig(Ice)
    pkgconfig(IceBox)
    pkgconfig(IceGrid)
    pkgconfig(IcePatch2)
    pkgconfig(IceStorm)

icegrid-gui:
    application()
    application(IceGridAdmin.desktop)
    icegrid-gui
    icegrid-gui(x86-64)

ice-csharp:
    ice-csharp
    ice-csharp(x86-64)
    ice-dotnet
    mono(Glacier2)
    mono(Ice)
    mono(IceBox)
    mono(IceGrid)
    mono(IcePatch2)
    mono(IceStorm)
    mono(iceboxnet)
    mono(policy.3.5.Glacier2)
    mono(policy.3.5.Ice)
    mono(policy.3.5.IceBox)
    mono(policy.3.5.IceGrid)
    mono(policy.3.5.IcePatch2)
    mono(policy.3.5.IceStorm)



Unversioned so-files
--------------------
ice-ruby: /usr/lib64/ruby/vendor_ruby/IceRuby.so
ice-python: /usr/lib64/python2.7/site-packages/Ice/IcePy.so
ice-php: /usr/lib64/php/modules/IcePHP.so

Source checksums
----------------
http://zeroc.com/download/Ice/3.5/Ice-3.5.1.tar.gz :
  CHECKSUM(SHA256) this package     : 989e51194c6adadbd156da3288e37bad847b93b3b876502e83033b70493af392
  CHECKSUM(SHA256) upstream package : 989e51194c6adadbd156da3288e37bad847b93b3b876502e83033b70493af392


Jar and class files in source
-----------------------------
./Ice-3.5.1/cpp/src/ca/ImportKey.class
./Ice-3.5.1/certs/ImportKey.class
./Ice-3.5.1/java/test/Ice/timeout/timeout.jar


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/bin/fedora-review -rn ./ice-3.5.1-14.fc22.src.rpm
Buildroot used: fedora-21-x86_64
Active plugins: Python, Shell-api, Generic, Java, C/C++
Disabled plugins: fonts, SugarActivity, Ocaml, Haskell, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 12 Justin W. Flory 2015-06-24 09:48:11 UTC
Given the context of the above review, it would be nice to see Ice maintained in newer releases of Fedora, especially for use with the Mumble VOIP client, as this is one of the leading FOSS VOIP clients, and it was a great benefit for users of Fedora 20. I just would like to chime in and say that from a user's perspective, it would be great to see this again.

Comment 13 Sergio Monteiro Basto 2015-07-15 04:19:11 UTC
(In reply to Sergio Durigan Junior from comment #10)
Sergio Durigan Junior , why you copy all review.txt to bug report ? , makes bug report unreadable (in my point of view) . Please use attach files for long texts .

Comment 14 John 2015-09-17 04:26:07 UTC
The srpm posted will break due to ruby-2.2.0 no longer having RBIGNUM in the header.

Comment 15 Andrew Dunn 2015-09-17 12:04:18 UTC
Also wanted to chime in and say that it'd be fantastic to get mumble back in mainline repositories.

Comment 16 Kevin Fenzi 2015-09-20 15:52:46 UTC
So, this looks like a stalled review per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Carlos: can you try and look at this in the next week? 

Otherwise, perhaps some other interested party could open a new review?

Comment 17 Rex Dieter 2015-11-24 16:56:36 UTC
per comment #16, marking as dead review.

Feel free to re-open, if submitter is still interested in pursuing this.


Note You need to log in before you can comment on or make changes to this bug.