Bug 1181646 - VdsmError does not contain missing member info
Summary: VdsmError does not contain missing member info
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: 4.16.7
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-3.6.0-rc
: 4.17.0
Assignee: Oved Ourfali
QA Contact: Jiri Belka
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-13 14:21 UTC by Nir Soffer
Modified: 2016-02-10 19:06 UTC (History)
11 users (show)

Fixed In Version: vdsm-4.17.0-632.git19a83a2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-01-13 14:39:32 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-3.6.0+
ylavi: planning_ack+
rule-engine: devel_ack+
pstehlik: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 37015 0 master MERGED bridge: Make VdsmError more verbose Never

Description Nir Soffer 2015-01-13 14:21:22 UTC 
Description of problem:

When showing a traceback of VdsmError, there is no info about the 
nature of the error, making debugging impossible.

Thread-14492::ERROR::2015-01-13 12:21:09,717::__init__::491::jsonrpc.JsonRpcServer::(_serveRequest) Internal server error
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/yajsonrpc/__init__.py", line 486, in _serveRequest
    res = method(**params)
  File "/usr/share/vdsm/rpc/Bridge.py", line 285, in _dynamicMethod
    ret = self._getResult(result, retfield)
  File "/usr/share/vdsm/rpc/Bridge.py", line 103, in _getResult
    raise VdsmError(5, "Response is missing '%s' member" % member)
VdsmError

Version-Release number of selected component (if applicable):
vdsm-4.16.7-1.gitdb83943.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Try to extend block domain with bad LUN

Actual results:
VdsmError

Expected results:
VdsmError: Response is missing 'membername' member
Comment 1 Nir Soffer 2015-01-13 14:23:21 UTC 
Should be trivial change (implement __str__ properly or fix the error handler), and will make it possible to debug such failures.
Comment 3 Red Hat Bugzilla Rules Engine 2015-10-18 08:34:06 UTC 
Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA.
Comment 4 Nir Soffer 2016-01-06 22:41:27 UTC 
Jiri, I don't have any information about reproducing this, only what you see in
the bug description.

Basically this is code change that make it easier to debug errors, not a user
visible feature, so I don't think we should waste too much time on this bug.
Comment 5 Jiri Belka 2016-01-07 09:31:32 UTC 
ok, codechange flag - vdsm-4.17.15-0.el7ev

no strange behaviour observed.
Comment 6 Sandro Bonazzola 2016-01-13 14:39:32 UTC 
oVirt 3.6.0 has been released, closing current release
Note You need to log in before you can comment on or make changes to this bug.