Bug 1182088 - Add pyflakes and pep8 as external projects to vdsm
Summary: Add pyflakes and pep8 as external projects to vdsm
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.1.0-alpha
: ---
Assignee: Yaniv Bronhaim
QA Contact: Jiri Belka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-14 12:22 UTC by Yaniv Bronhaim
Modified: 2017-02-15 15:02 UTC (History)
17 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-15 15:02:04 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
oourfali: devel_ack+
pstehlik: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 44928 0 master ABANDONED makefile: Run pep8/pyflakes inside virtualenv 2016-03-08 09:16:25 UTC
oVirt gerrit 49952 0 master MERGED Makefile: use tox to run make pep8 and pyflakes 2016-05-17 10:49:06 UTC

Description Yaniv Bronhaim 2015-01-14 12:22:55 UTC
To restrict the version vdsm uses to validate the code by pep8 and pyflakes we might able to run those checks manually instead of using installed version. For that we might able to attach specific pyflakes and pep8 branch as external repository to vdsm and use that code to check vdsm.

Comment 1 Sandro Bonazzola 2015-02-25 14:26:48 UTC
Please be sure to not package them with VDSM as per 
http://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_of_multiple_projects

Comment 2 Yedidyah Bar David 2015-02-25 14:39:35 UTC
You can also provide a tox.ini file if needed, filtering out specific errors.

Comment 4 Yaniv Lavi 2015-10-29 12:11:36 UTC
In oVirt testing is done on single release by default. Therefore I'm removing the 4.0 flag. If you think this bug must be tested in 4.0 as well, please re-add the flag. Please note we might not have testing resources to handle the 4.0 clone.

Comment 5 Pavel Stehlik 2016-02-08 13:07:53 UTC
CodeChange? Or please provide steps for testing, thank you.

Comment 6 Yaniv Bronhaim 2016-02-08 15:10:15 UTC
Its not done yet... and it should force the pep8 and pylakes check to be with specific version. the test should be to have installed newer pep8 version than the one that vdsm is using, and see that make check uses the one that vdsm aligns to

Comment 7 Mike McCune 2016-03-28 23:46:50 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 8 Yaniv Bronhaim 2016-04-18 10:57:12 UTC
still in progress. but it might miss 4.0, hope to get asap but for now I move to 4.1

Comment 9 Red Hat Bugzilla Rules Engine 2016-04-18 10:58:00 UTC
This request has been proposed for two releases. This is invalid flag usage. The ovirt-future release flag has been cleared. If you wish to change the release flag, you must clear one release flag and then set the other release flag to ?.

Comment 10 Sandro Bonazzola 2016-12-12 14:01:07 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 11 Jiri Belka 2016-12-19 11:16:48 UTC
ok, not a change for end-user. it's not seen even in src rpm file.


Note You need to log in before you can comment on or make changes to this bug.