(In reply to Kevin Alon Goldblatt from comment #0)
> Expected results:
> The operation should either have rolled back
It's a delete operation - it cannot be rolled back.
> or been prevented if there were
> space considerations
This is the proper fix.
Vered, don't we already have a BZ for this?
(In reply to Allon Mureinik from comment #1)
>
> Vered, don't we already have a BZ for this?
It's storage allocation for merging a snapshot, bz1178010.
Created attachment 980101 [details] screenshots, server and vdsm logs Description of problem: When deleting a snapshot of a VM with BLOCK disks and minimal space available, the operation fails with Cannot create logical volume Version-Release number of selected component (if applicable): How reproducible Happened once Steps to Reproduce: 1.Create VM with 3 disks (2 block preallocated 4g each and 1 block thin 4g) 2.Create 2 snapshots sb1 and sb2 3.Select to delete sb1 >>>>> Fails with: -- Message: VDSGenericException: VDSErrorException: Failed to HSMGetAllTasksStatusesVDS, error = Cannot create Logical Volume, code = 550, -- Exception: VDSGenericException: VDSErrorException: Failed to HSMGetAllTasksStatusesVDS, error = Cannot create Logical Volume, code = 550 Actual results: Snapshot was only partially deleted - only 1 out of 2 disks were deleted Expected results: The operation should either have rolled back or been prevented if there were space considerations Additional info: 2015-01-14 16:20:08,447 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,447 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,447 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,447 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,447 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,448 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:08,449 INFO [org.ovirt.engine.core.bll.tasks.SPMAsyncTask] (DefaultQuartzScheduler_Worker-12) [4a34c3db] SPMAsyncTask::PollTask: Polling task c04f9e0c-ffab-46d8-a172-55283b6bf1ac (Parent Command RemoveSnapshot, Paramete rs Type org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters) returned status running. 2015-01-14 16:20:08,449 INFO [org.ovirt.engine.core.bll.tasks.SPMAsyncTask] (DefaultQuartzScheduler_Worker-12) [4a34c3db] SPMAsyncTask::PollTask: Polling task 0174e75b-647f-4438-8bfe-59b430e12b56 (Parent Command RemoveSnapshot, Paramete rs Type org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters) returned status running. 2015-01-14 16:20:08,449 INFO [org.ovirt.engine.core.bll.tasks.SPMAsyncTask] (DefaultQuartzScheduler_Worker-12) [4a34c3db] SPMAsyncTask::PollTask: Polling task 63f8f0de-281b-4b38-8edd-ae5c9b321432 (Parent Command RemoveSnapshot, Paramete rs Type org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters) returned status running. 2015-01-14 16:20:08,449 INFO [org.ovirt.engine.core.bll.tasks.AsyncTaskManager] (DefaultQuartzScheduler_Worker-12) [4a34c3db] Finished polling Tasks, will poll again in 10 seconds. 2015-01-14 16:20:11,384 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (DefaultQuartzScheduler_Worker-69) [3fe31137] Correlation ID: null, Call Stack: null, Custom Event ID: -1, Message: Critical, Low disk s pace. block domain has 3 GB of free space 2015-01-14 16:20:18,466 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,466 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,466 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,466 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,466 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,466 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,466 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,466 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,467 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,468 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,468 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.HSMGetAllTasksStatusesVDSCommand] (DefaultQuartzScheduler_Worker-71) [2186f7ed] Failed in HSMGetAllTasksStatusesVDS method 2015-01-14 16:20:18,468 INFO [org.ovirt.engine.core.bll.tasks.SPMAsyncTask] (DefaultQuartzScheduler_Worker-71) [2186f7ed] SPMAsyncTask::PollTask: Polling task 0174e75b-647f-4438-8bfe-59b430e12b56 (Parent Command RemoveSnapshot, Paramete rs Type org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters) returned status finished, result 'cleanSuccess'. 2015-01-14 16:20:18,473 ERROR [org.ovirt.engine.core.bll.tasks.SPMAsyncTask] (DefaultQuartzScheduler_Worker-71) [2186f7ed] BaseAsyncTask::logEndTaskFailure: Task 0174e75b-647f-4438-8bfe-59b430e12b56 (Parent Command RemoveSnapshot, Parame ters Type org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters) ended with failure: -- Result: cleanSuccess -- Message: VDSGenericException: VDSErrorException: Failed to HSMGetAllTasksStatusesVDS, error = Cannot create Logical Volume, code = 550, -- Exception: VDSGenericException: VDSErrorException: Failed to HSMGetAllTasksStatusesVDS, error = Cannot create Logical Volume, code = 550 . . . Due to partial snapshot removal, Snapshot 'sb1' of VM 'vm_block' now contains only the following disks: 'vm_block_Disk2'.