Bug 1182267 - compile warnings with gcc 5.0
Summary: compile warnings with gcc 5.0
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: disperse
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Xavi Hernandez
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-14 18:27 UTC by Kaleb KEITHLEY
Modified: 2015-12-01 16:45 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 17:29:00 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaleb KEITHLEY 2015-01-14 18:27:21 UTC
Description of problem:

compiling xlator/cluster/ec/... with gcc-5 emits warnings not seen with gcc-4.x

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Making all in ec
Making all in src
  CC       ec.lo
In file included from ec.c:16:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-data.lo
In file included from ec-data.c:12:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-helpers.lo
  CC       ec-common.lo
In file included from ec-common.c:15:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-generic.lo
In file included from ec-generic.c:14:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-locks.lo
In file included from ec-locks.c:14:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-dir-read.lo
In file included from ec-dir-read.c:14:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-dir-write.lo
In file included from ec-dir-write.c:14:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-inode-read.lo
In file included from ec-inode-read.c:14:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-inode-write.lo
In file included from ec-inode-write.c:14:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-combine.lo
In file included from ec-combine.c:17:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       ec-gf.lo
  CC       ec-method.lo
  CC       ec-heal.lo
In file included from ec-heal.c:15:0:
ec-helpers.h:56:1: warning: inline function 'ec_is_internal_xattr' declared but never defined
 ec_is_internal_xattr (dict_t *dict, char *key, data_t *value, void *data);
 ^
  CC       libxlator.lo
  CCLD     ec.la

Comment 1 Anand Avati 2015-01-15 08:41:12 UTC
REVIEW: http://review.gluster.org/9452 (ec: Remove unneeded 'inline' for ec_is_internal_xattr()) posted (#1) for review on master by Xavier Hernandez (xhernandez)

Comment 2 Anand Avati 2015-01-19 06:01:23 UTC
COMMIT: http://review.gluster.org/9452 committed in master by Vijay Bellur (vbellur) 
------
commit 63dc6e1942dffcddd99c5048a498ca00eead8baa
Author: Xavier Hernandez <xhernandez>
Date:   Thu Jan 15 09:38:04 2015 +0100

    ec: Remove unneeded 'inline' for ec_is_internal_xattr()
    
    An incorrectly placed 'inline' keyword caused compilation warnings
    with gcc 5.
    
    Change-Id: I2bf8c39b1514ea7dac13e82eb3b6ff4b98e62c79
    BUG: 1182267
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/9452
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2015-05-14 17:29:00 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:48 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:10 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:45:37 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.