Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kdecoration.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kdecoration-5.1.95-1.beta.fc21.src.rpm Description: Plugin-based library to create window decorations Fedora Account System Username: dvratil
> sed -i "s/set(KDECORATION2_INCLUDEDIR \"\${CMAKE_INSTALL_INCLUDEDIR}\/KDecoration2\")//" CMakeLists.txt > sed -i "s/\${KDECORATION2_INCLUDEDIR}/\${KF5_INCLUDE_INSTALL_DIR}\/KDecoration2/g" src/CMakeLists.txt src/private/CMakeLists.txt Why not simply: sed -i "s/set(KDECORATION2_INCLUDEDIR \"\${CMAKE_INSTALL_INCLUDEDIR}\/KDecoration2\")/set(KDECORATION2_INCLUDEDIR \"\${KF5_INCLUDE_INSTALL_DIR}\/KDecoration2\")/" CMakeLists.txt ?
Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kdecoration.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kdecoration-5.1.95-2.beta.fc21.src.rpm Simplified the sed replacement, thanks Kevin.
Rpmlint ------- Checking: kdecoration-5.1.95-2.beta.fc20.x86_64.rpm kdecoration-devel-5.1.95-2.beta.fc20.x86_64.rpm kdecoration-5.1.95-2.beta.fc20.src.rpm kdecoration.x86_64: W: spelling-error Summary(en_US) libraty -> library, Libra kdecoration.x86_64: W: spelling-error %description -l en_US libraty -> library, Libra kdecoration-devel.x86_64: W: only-non-binary-in-usr-lib kdecoration-devel.x86_64: W: no-documentation kdecoration.src: W: spelling-error Summary(en_US) libraty -> library, Libra kdecoration.src: W: spelling-error %description -l en_US libraty -> library, Libra 3 packages and 0 specfiles checked; 0 errors, 6 warnings. 1) You have a typo in description 2) Wrong url No other issue spotted and none from mentioned issues is blocking, APPROVED.
New Package SCM Request ======================= Package Name: kdecoration Short Description: Plugin-based library to create window decorations Upstream URL: https://projects.kde.org/projects/kde/workspace/kdecoration Owners: group::kde-sig Branches: InitialCC:
Git done (by process-git-requests).