Description of problem: Running rpmlint on upstream master spec file giving two errors. Refer below for errors. lmohanty@localhost glusterfs]$ rpmlint glusterfs.spec glusterfs.spec:69: W: macro-in-comment %global glusterfs.spec:207: W: unversioned-explicit-obsoletes hekafs glusterfs.spec:210: W: unversioned-explicit-obsoletes %{name}-ufo glusterfs.spec:427: W: non-standard-group Productivity/Clustering/HA glusterfs.spec:432: E: hardcoded-library-path in %{_prefix}/lib/ocf/resource.d glusterfs.spec:703: W: macro-in-comment %post glusterfs.spec:779: W: macro-in-comment %preun glusterfs.spec:800: W: macro-in-comment %postun glusterfs.spec:817: W: macro-in-comment %files glusterfs.spec:948: E: hardcoded-library-path in %{_prefix}/lib/ocf/resource.d/glusterfs glusterfs.spec: W: invalid-url Source0: glusterfs-3.7dev.tar.gz 0 packages and 1 specfiles checked; 2 errors, 9 warnings. Version-Release number of selected component (if applicable): git tag on master branch: v3.7dev How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Behavior with glusterfs-6dev glusterfs.spec:281: W: unversioned-explicit-obsoletes hekafs glusterfs.spec:284: W: unversioned-explicit-obsoletes %{name}-ufo glusterfs.spec:285: W: unversioned-explicit-obsoletes %{name}-ganesha glusterfs.spec:553: E: hardcoded-library-path in %{_prefix}/lib/ocf/resource.d glusterfs.spec:1201: E: hardcoded-library-path in %{_prefix}/lib/ocf/resource.d/glusterfs glusterfs.spec:1351: E: hardcoded-library-path in %{_prefix}/lib/firewalld/services/glusterfs.xml glusterfs.spec: W: invalid-url Source0: glusterfs-6dev.tar.gz 0 packages and 1 specfiles checked; 3 errors, 4 warnings.
REVIEW: https://review.gluster.org/23039 (build: fix rpmlint errors and warnings in specfile) posted (#1) for review on master by Shwetha K Acharya
REVIEW: https://review.gluster.org/23039 (build: fix rpmlint warnings in specfile) merged (#5) on master by Amar Tumballi