Spec URL: https://git.nj0y.ch/rpms/ykfde/ykfde.spec SRPM URL: https://git.nj0y.ch/rpms/ykfde/ykfde-0.5.1-2.el7.centos.src.rpm Description: The Package provides the ability to open a LUKS encrypted drive with the Yubikey in challenge response mode (HMAC-SHA1) Fedora Account System Username: nj0y Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8645842 (F21)
Hi, A few notes : - you should use macro for various path ( /usr/lib/systemd/system for example ) - i would recommand having 1 buildRequires per line, since that's easier to review on git when there is a change ( ie, in the diff ) - if it install a service, it should run some scriplet for systemd, no ?
Hi, Thank you for your notes. I updated the spec file. > you should use macro for various path ( /usr/lib/systemd/system for example ) I have the problem, that ex. _libdir is translated to /usr/lib64 on x86_64 systems. no I have changed it to %{_usr}/lib. Is there another way? > i would recommand having 1 buildRequires per line, since that's easier to review on git when there is a change ( ie, in the diff ) I changed it that way. > i would recommand having 1 buildRequires per line, since that's easier to review on git when there is a change ( ie, in the diff ) this case the systemd-service is not required. if you want to change the challenges, then you should.
> if it install a service, it should run some scriplet for systemd, no ? this case the systemd-service is not required. if you want to change the challenges, then you should.
hi! Why don't you use the base source? > URL: https://github.com/nj0y/ykfde > Source: https://git.nj0y.ch/download/ykfde-%{version}.tar.gz %{URL} is a fork from https://github.com/eworm-de/mkinitcpio-ykfde without advantages as far as I can say now. There is also no advantage in using %{Source} from an private git server, which seems like another fork from https://github.com/eworm-de/mkinitcpio-ykfde . Cheers, Flo
Hi! > Why don't you use the base source? No problem with that. it's a fork, just to implement the fedora things, which were merged into upstream. Changed it.
I added a Copr Repository for that: https://copr.fedoraproject.org/coprs/nj0y/ykfde/
Benjamin - Are you still interested in packaging this?