Bug 1183294 - Review Request: perl-Compress-Snappy - Perl interface to Google's Snappy (de)compressor
Summary: Review Request: perl-Compress-Snappy - Perl interface to Google's Snappy (de)...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-18 08:05 UTC by David Dick
Modified: 2015-02-17 18:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-02-17 18:58:07 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Dick 2015-01-18 08:05:50 UTC
Spec URL: https://ddick.fedorapeople.org/packages/perl-Compress-Snappy.spec
SRPM URL: https://ddick.fedorapeople.org/packages/perl-Compress-Snappy-0.23-1.fc20.src.rpm
Description: Perl interface to Google's Snappy (de)compressor
Fedora Account System Username: ddick

Comment 1 David Dick 2015-01-18 08:07:32 UTC
koji builds 

rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=8655290

Comment 2 Petr Pisar 2015-02-11 10:04:21 UTC
URL and Source0 are usable. Ok.
Source archive is original (SHA-256: 9c4280009001902966393372d06a657b0d239291791cdedd9a284a847fee2270). Ok.
The patch is good. Ok
Summary verified from lib/Compress/Snappy.pm. Ok.
Description verified from lib/Compress/Snappy.pm. Ok.
License verified from README, ppport.h, lib/Compress/Snappy.pm. Bundled csnappy code is not used. Ok.
XS code is used. Architecture specific binary RPM is Ok.

TODO: You can use plain `perl' commands instead of the `%{__perl}' macros.

Bundled sources are removed before building. Ok.

TODO: Constrain `perl(ExtUtils::MakeMaker)' build-dependency with `>= 6.52' (Makefile.PL:4).

All tests pass. Ok.

$ rpmlint perl-Compress-Snappy.spec ../SRPMS/perl-Compress-Snappy-0.23-1.fc22.src.rpm ../RPMS/x86_64/perl-Compress-Snappy-* 
perl-Compress-Snappy.src: W: spelling-error Summary(en_US) de -> DE, ed, d
perl-Compress-Snappy.src: W: spelling-error %description -l en_US de -> DE, ed, d
perl-Compress-Snappy.x86_64: W: spelling-error Summary(en_US) de -> DE, ed, d
perl-Compress-Snappy.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d
3 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/x86_64/perl-Compress-Snappy-0.23-1.fc22.x86_64.rpm 
drwxr-xr-x    2 root    root                        0 Feb 11 10:56 /usr/lib64/perl5/vendor_perl/Compress
-rw-r--r--    1 root    root                     4340 Feb  8  2014 /usr/lib64/perl5/vendor_perl/Compress/Snappy.pm
drwxr-xr-x    2 root    root                        0 Feb 11 10:56 /usr/lib64/perl5/vendor_perl/auto/Compress
drwxr-xr-x    2 root    root                        0 Feb 11 10:56 /usr/lib64/perl5/vendor_perl/auto/Compress/Snappy
-rwxr-xr-x    1 root    root                    11160 Feb 11 10:56 /usr/lib64/perl5/vendor_perl/auto/Compress/Snappy/Snappy.so
drwxr-xr-x    2 root    root                        0 Feb 11 10:56 /usr/share/doc/perl-Compress-Snappy
-rw-r--r--    1 root    root                     3123 Feb  8  2014 /usr/share/doc/perl-Compress-Snappy/Changes
-rw-r--r--    1 root    root                      556 Feb  8  2014 /usr/share/doc/perl-Compress-Snappy/README
drwxr-xr-x    2 root    root                        0 Feb 11 10:56 /usr/share/doc/perl-Compress-Snappy/ex
-rw-r--r--    1 root    root                     4242 Sep 11  2012 /usr/share/doc/perl-Compress-Snappy/ex/benchmark.pl
-rw-r--r--    1 root    root                     2710 Feb 11 10:56 /usr/share/man/man3/Compress::Snappy.3pm.gz
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-Compress-Snappy-0.23-1.fc22.x86_64.rpm | sort -f | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libcsnappy.so()(64bit)
      1 libperl.so.5.20()(64bit)
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Exporter) >= 5.57
      1 perl(strict)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/x86_64/perl-Compress-Snappy-0.23-1.fc22.x86_64.rpm | sort -f | uniq -c
      1 perl(Compress::Snappy) = 0.23
      1 perl-Compress-Snappy = 0.23-1.fc22
      1 perl-Compress-Snappy(x86-64) = 0.23-1.fc22
Binary requires are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-Compress-Snappy-0.23-1.fc22.x86_64.rpm 
Binary dependencies resolvable. Ok.

Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8893793). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Please consider fixing all `TODO' items before building this package.
Resolution: Package APPROVED.

Comment 3 David Dick 2015-02-11 10:26:13 UTC
Thanks Petr!

New Package SCM Request
=======================
Package Name: perl-Compress-Snappy
Short Description: Perl interface to Google's Snappy (de)compressor
Upstream URL: http://search.cpan.org/dist/Compress-Snappy/
Owners: ddick
Branches: el6, epel7
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2015-02-11 12:42:14 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.