Bug 1183463 - Deleting a volume should follow ref counting mechanism
Summary: Deleting a volume should follow ref counting mechanism
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Atin Mukherjee
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-19 07:16 UTC by Atin Mukherjee
Modified: 2015-05-14 17:45 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 17:29:01 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Atin Mukherjee 2015-01-19 07:16:56 UTC
Description of problem:

In the glusterd codebase its found that deletion of a volume doesn't follow the ref counting mechanism which is an incorrect design as volume creation falls under the ref counting mechanism.

Comment 1 Anand Avati 2015-01-19 07:18:11 UTC
REVIEW: http://review.gluster.org/9462 (glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Anand Avati 2015-01-19 09:31:15 UTC
REVIEW: http://review.gluster.org/9462 (glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref) posted (#2) for review on master by Atin Mukherjee (amukherj)

Comment 3 Anand Avati 2015-01-20 10:01:36 UTC
REVIEW: http://review.gluster.org/9462 (glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref) posted (#3) for review on master by Atin Mukherjee (amukherj)

Comment 4 Anand Avati 2015-01-22 14:57:36 UTC
REVIEW: http://review.gluster.org/9462 (glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref) posted (#4) for review on master by Atin Mukherjee (amukherj)

Comment 5 Anand Avati 2015-01-27 14:13:32 UTC
REVIEW: http://review.gluster.org/9462 (glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref) posted (#5) for review on master by Atin Mukherjee (amukherj)

Comment 6 Anand Avati 2015-01-27 14:30:15 UTC
REVIEW: http://review.gluster.org/9462 (glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref) posted (#6) for review on master by Atin Mukherjee (amukherj)

Comment 7 Anand Avati 2015-03-03 08:31:28 UTC
REVIEW: http://review.gluster.org/9462 (glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref) posted (#7) for review on master by Atin Mukherjee (amukherj)

Comment 8 Anand Avati 2015-03-03 08:32:14 UTC
REVIEW: http://review.gluster.org/9462 (glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref) posted (#8) for review on master by Atin Mukherjee (amukherj)

Comment 9 Anand Avati 2015-03-30 05:33:47 UTC
REVIEW: http://review.gluster.org/9462 (glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref) posted (#9) for review on master by Atin Mukherjee (amukherj)

Comment 10 Anand Avati 2015-03-30 09:43:41 UTC
COMMIT: http://review.gluster.org/9462 committed in master by Kaushal M (kaushal) 
------
commit 7b3db6df564f1af1845b7f436e74ac6e838cd5b6
Author: Atin Mukherjee <amukherj>
Date:   Fri Jan 16 14:28:09 2015 +0530

    glusterd: replace glusterd_volinfo_delete calls with glusterd_volinfo_unref
    
    volinfo has its own ref counting mechanism. While deleting a
    volinfo object its always wiser to check there is 0 reference
    to it and then delete it.
    
    Change-Id: I446bd83432bd94aa19e29c6026367dfc1231786f
    BUG: 1183463
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/9462
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 11 Niels de Vos 2015-05-14 17:29:01 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 12 Niels de Vos 2015-05-14 17:35:49 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 13 Niels de Vos 2015-05-14 17:38:11 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 14 Niels de Vos 2015-05-14 17:45:37 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.