Bug 1184472 - Review Request: bats - Bash Automated Testing System
Summary: Review Request: bats - Bash Automated Testing System
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Florian "der-flo" Lehner
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2015-01-21 13:39 UTC by François Cami
Modified: 2015-06-29 18:40 UTC (History)
2 users (show)

Fixed In Version: bats-0.4.0-1.20141016git3b33a5a.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2015-02-13 02:23:15 UTC
dev: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description François Cami 2015-01-21 13:39:53 UTC
Spec URL: https://fcami.fedorapeople.org/srpms/bats.spec

SRPM URL: https://fcami.fedorapeople.org/srpms/bats-0.4.0-1.20141016git3b33a5a.fc21.src.rpm

Bats is a TAP-compliant testing framework for Bash.
It provides a simple way to verify that the UNIX programs
you write behave as expected.
Bats is most useful when testing software written in Bash,
but you can use it to test any UNIX program.

Fedora Account System Username: fcami

Comment 1 François Cami 2015-01-21 23:31:43 UTC
New version with some cleanup fixes:

Spec URL: https://fcami.fedorapeople.org/srpms/bats.spec

SRPM URL: https://fcami.fedorapeople.org/srpms/bats-0.4.0-2.20141016git3b33a5a.fc21.src.rpm

Comment 2 Florian "der-flo" Lehner 2015-01-22 20:42:57 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 1 files have unknown license. 
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
   ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=8703371
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: bats-0.4.0-2.20141016git3b33a5a.fc22.noarch.rpm
bats.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Rpmlint (installed packages)
Cannot parse rpmlint output:

bats (rpmlib, GLIBC filtered):


Source checksums
https://github.com/sstephenson/bats/archive/3b33a5ac6afd7f01ff4120659e2a72b851081178/bats-0.4.0-3b33a5a.tar.gz :
  CHECKSUM(SHA256) this package     : 18af20734d769bfb8c43f08eb65fe56cbac082437413d69f68b34f233e6b1446
  CHECKSUM(SHA256) upstream package : 18af20734d769bfb8c43f08eb65fe56cbac082437413d69f68b34f233e6b1446

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1184472
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

===== Solution =====

Comment 3 François Cami 2015-01-22 20:52:17 UTC
New Package SCM Request
Package Name: bats
Short Description: Bash Automated Testing System
Upstream URL: https://github.com/sstephenson/bats
Owners: fcami
Branches: f21 epel7 el6

Comment 4 Gwyn Ciesla 2015-01-22 20:57:28 UTC
Git done (by process-git-requests).

Comment 5 François Cami 2015-01-22 21:03:59 UTC
Thank you Florian & Jon.

Comment 6 Fedora Update System 2015-01-22 21:34:41 UTC
bats-0.4.0-1.20141016git3b33a5a.el6 has been submitted as an update for Fedora EPEL 6.

Comment 7 Fedora Update System 2015-01-22 21:35:59 UTC
bats-0.4.0-1.20141016git3b33a5a.el7 has been submitted as an update for Fedora EPEL 7.

Comment 8 Fedora Update System 2015-01-22 21:37:28 UTC
bats-0.4.0-1.20141016git3b33a5a.fc21 has been submitted as an update for Fedora 21.

Comment 9 Fedora Update System 2015-01-26 02:28:47 UTC
bats-0.4.0-1.20141016git3b33a5a.fc21 has been pushed to the Fedora 21 testing repository.

Comment 10 Fedora Update System 2015-02-13 02:23:15 UTC
bats-0.4.0-1.20141016git3b33a5a.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2015-06-29 18:38:51 UTC
bats-0.4.0-1.20141016git3b33a5a.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 12 Fedora Update System 2015-06-29 18:40:17 UTC
bats-0.4.0-1.20141016git3b33a5a.el7 has been pushed to the Fedora EPEL 7 stable repository.

Note You need to log in before you can comment on or make changes to this bug.