Bug 1184508 - cabal-tweak-flag: "CABALFILE does have flag"
Summary: cabal-tweak-flag: "CABALFILE does have flag"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: ghc-rpm-macros
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-21 15:01 UTC by Ian Collier
Modified: 2016-06-14 02:27 UTC (History)
2 users (show)

Fixed In Version: ghc-rpm-macros-1.2.19-1.fc21 ghc-rpm-macros-1.0.7.5-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-01-26 09:38:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ian Collier 2015-01-21 15:01:30 UTC
Confusing error message in cabal-tweak-flag, as follows:

if ! grep -q -i "^flag *$FLAG" $CABALFILE; then
   echo "$CABALFILE does have flag $FLAG"
   exit 1
fi

It seems this should rather say "does not have flag".

Observed in: ghc-rpm-macros-1.0.7.4-1.fc20.x86_64

Comment 1 Jens Petersen 2015-01-22 01:33:42 UTC
Oops, good catch! Thanks for reporting this.

I committed a fix to the master branch

http://pkgs.fedoraproject.org/cgit/ghc-rpm-macros.git/commit/?id=1107962ad8dbbe25edf291614eccac8b3de04086

and built it for f22 rawhide.

It should get backported to current releases later.

Comment 2 Fedora Update System 2015-01-22 08:29:10 UTC
ghc-rpm-macros-1.2.19-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/ghc-rpm-macros-1.2.19-1.fc21

Comment 3 Fedora Update System 2015-01-26 02:33:44 UTC
Package ghc-rpm-macros-1.2.19-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ghc-rpm-macros-1.2.19-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-1109/ghc-rpm-macros-1.2.19-1.fc21
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2015-02-20 08:33:40 UTC
ghc-rpm-macros-1.2.19-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2015-10-09 01:22:19 UTC
ghc-rpm-macros-1.0.7.5-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-5eff081c6c

Comment 6 Fedora Update System 2015-10-09 22:53:40 UTC
ghc-rpm-macros-1.0.7.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update ghc-rpm-macros'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-5eff081c6c

Comment 7 Jan Kurik 2015-12-22 11:29:52 UTC
This bug is currently assigned to an unsupported release. If you think this bug is still valid and should remain open, please re-assign it to a supported release (F22, F23) or to rawhide.

Bugs which will be assigned to an unsupported release are going to be closed as EOL (End Of Life) on January 26th, 2016.

Comment 8 Fedora Update System 2016-02-10 11:14:10 UTC
ghc-rpm-macros-1.0.7.5-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Jens Petersen 2016-06-14 02:27:45 UTC
Already fixed in later releases.


Note You need to log in before you can comment on or make changes to this bug.