Bug 1185793 - AttributeError: 'NoneType' object has no attribute 'name'
Summary: AttributeError: 'NoneType' object has no attribute 'name'
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 24
Hardware: x86_64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Brian Lane
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:2877a264eb6d7b248196e2bd9ae...
Depends On:
Blocks: 1315414
TreeView+ depends on / blocked
 
Reported: 2015-01-26 10:03 UTC by Jonathan Dieter
Modified: 2016-06-16 00:09 UTC (History)
5 users (show)

Fixed In Version: anaconda-25.3-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1315414 (view as bug list)
Environment:
Last Closed: 2016-06-16 00:09:38 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: anaconda-tb (257.95 KB, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: anaconda.log (10.18 KB, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: environ (459 bytes, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: ks.cfg (4.86 KB, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: lsblk_output (940 bytes, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: nmcli_dev_list (1.06 KB, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: os_info (377 bytes, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: program.log (17.21 KB, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: storage.log (45.68 KB, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: syslog (82.13 KB, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: ifcfg.log (1.39 KB, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
File: packaging.log (313.64 KB, text/plain)
2015-01-26 10:03 UTC, Jonathan Dieter
no flags Details
Don't update repos while they're already updating (1.35 KB, patch)
2015-01-28 08:28 UTC, Jonathan Dieter
no flags Details | Diff

Description Jonathan Dieter 2015-01-26 10:03:09 UTC
Description of problem:
I'm doing a kickstart install over the network for several desktops and this problem is coming up intermittentally.  On this particular system, it happens every time I try to do the install.  The repositories all exist and on most of the desktops, everything installs just fine on the fist attempt.  This is the first desktop that has required a second (and third) attempt.

Version-Release number of selected component:
anaconda-21.48.21-1

The following was filed automatically by anaconda:
anaconda 21.48.21-1 exception report
Traceback (most recent call first):
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/source.py", line 1146, in _reset_repoStore
    ks_repo = self.data.RepoData(name=repo.name,
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/source.py", line 717, in _initialize
    self._reset_repoStore()
  File "/usr/lib64/python2.7/threading.py", line 766, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 227, in run
    threading.Thread.run(self, *args, **kwargs)
AttributeError: 'NoneType' object has no attribute 'name'

Additional info:
addons:         com_redhat_kdump
cmdline:        /usr/bin/python  /sbin/anaconda
cmdline_file:   ks=http://local.lesbg.com/rpms/f21/x86_64/unattended.cfg
executable:     /sbin/anaconda
hashmarkername: anaconda
kernel:         3.17.4-301.fc21.x86_64
product:        Fedora"
release:        Cannot get release name.
type:           anaconda
version:        Fedora

Comment 1 Jonathan Dieter 2015-01-26 10:03:15 UTC
Created attachment 984138 [details]
File: anaconda-tb

Comment 2 Jonathan Dieter 2015-01-26 10:03:17 UTC
Created attachment 984139 [details]
File: anaconda.log

Comment 3 Jonathan Dieter 2015-01-26 10:03:18 UTC
Created attachment 984140 [details]
File: environ

Comment 4 Jonathan Dieter 2015-01-26 10:03:20 UTC
Created attachment 984141 [details]
File: ks.cfg

Comment 5 Jonathan Dieter 2015-01-26 10:03:21 UTC
Created attachment 984142 [details]
File: lsblk_output

Comment 6 Jonathan Dieter 2015-01-26 10:03:23 UTC
Created attachment 984143 [details]
File: nmcli_dev_list

Comment 7 Jonathan Dieter 2015-01-26 10:03:32 UTC
Created attachment 984144 [details]
File: os_info

Comment 8 Jonathan Dieter 2015-01-26 10:03:33 UTC
Created attachment 984145 [details]
File: program.log

Comment 9 Jonathan Dieter 2015-01-26 10:03:35 UTC
Created attachment 984146 [details]
File: storage.log

Comment 10 Jonathan Dieter 2015-01-26 10:03:38 UTC
Created attachment 984147 [details]
File: syslog

Comment 11 Jonathan Dieter 2015-01-26 10:03:39 UTC
Created attachment 984148 [details]
File: ifcfg.log

Comment 12 Jonathan Dieter 2015-01-26 10:03:44 UTC
Created attachment 984149 [details]
File: packaging.log

Comment 13 Brian Lane 2015-01-28 00:41:52 UTC
I'm not sure what's going on here -- it looks like the repo vanished from the dataList, but that shouldn't happen. You say it is intermittent so it may be timing related or may be your local repos.

One thing you can try is kickstarting it in text mode, the code path there is somewhat different than with GUI, and see if it is more reliable.

Comment 14 Jonathan Dieter 2015-01-28 08:28:47 UTC
Created attachment 985017 [details]
Don't update repos while they're already updating

Text mode does work fine, so I started poking around in pyanaconda/ui/gui/spokes/sources.py.  I tracked it down to a race between _reset_repoStore populating the repoStore from the payload and _update_payload_repos trying to clear the payload of any repos not in the repoStore.

I've hacked up a solution by adding a lock variable that _reset_repoStore sets while it's running.  When it's set, _update_payload_repos doesn't attempt to touch the payload.

I don't know if this is the best way to fix the problem.

Comment 15 Jonathan Dieter 2015-01-28 08:29:34 UTC
Just to clarify, I've rebuilt squashfs.img and tested this patch, and it does fix the bug.

Comment 16 Fedora End Of Life 2015-11-04 13:55:05 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 17 Brian Lane 2015-11-06 01:22:54 UTC
If this still happens with F23/rawhide please reopen with new logs. We are now using DNF instead of yum so the repo code has changed considerably.

Comment 18 Brian Lane 2016-03-08 22:25:41 UTC
Now I realize what's going on. Here's a patch using Lock():

https://github.com/rhinstaller/anaconda/pull/544


Note You need to log in before you can comment on or make changes to this bug.