Bug 1186036 - routing-daemon will create broken nginx config file when app fail to be created and roll back.
Summary: routing-daemon will create broken nginx config file when app fail to be creat...
Keywords:
Status: CLOSED EOL
Alias: None
Product: OKD
Classification: Red Hat
Component: Pod
Version: 2.x
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: ---
Assignee: Miciah Dashiel Butler Masters
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks: 1168994
TreeView+ depends on / blocked
 
Reported: 2015-01-26 21:28 UTC by Miciah Dashiel Butler Masters
Modified: 2019-03-22 07:34 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1168994
Environment:
Last Closed: 2017-01-25 06:38:43 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 1 Miciah Dashiel Butler Masters 2015-01-27 16:59:22 UTC
Hm, I'm pretty sure I posted a comment here earlier, but I don't see it now.  Also, I thought openshift-bot should have posted this commit here when it merged:

    Routing SPI: Send notifications on rollbacks
    
    Add rollback methods to NotifyAliasAddOp, NotifyAppCreateOp, and
    NotifySslCertAddOp.  These rollback methods invoke the notify_remove_alias,
    notify_delete_application, and notify_ssl_cert_remove methods,
    respectively, of the routing service.
    
    This change causes the ActiveMQ routing plug-in to send :remove_alias,
    :delete_application, and :remove_ssl notifications when an application
    creation fails so that anything listening for these notifications (such as
    the OpenShift routing daemon) can properly clean up any configuration that
    it may have done in response to the earlier corresponding :add_alias,
    :create_application, and :add_ssl notifications during the application's
    creation.
    
    This commit fixes bug 1186036.

https://github.com/openshift/origin-server/commit/51dbfedca1bfd3d939e89dadd261225b14479bee

https://github.com/openshift/origin-server/pull/6058


Note You need to log in before you can comment on or make changes to this bug.