Top left of the UI should have the Red Hat logo, not the Inktank one.
I had trouble finding the Inktank logo anywhere in the calamari-clients package. Was this already fixed upstream (maybe by http://tracker.ceph.com/issues/8408?) Assuming that 'Inktank' is still in there somewhere, and we can identify the proper logo file to replace... This involves a packaging change, so do we want to take this for Red Velvet or push it to a later version?
In ICE standup today, Dan pointed me at Gregory's "wip-logo" branch in calamari-clients, specifically this commit: https://github.com/ceph/calamari-clients/commit/d14f61afc2a73f90787a53f653e092fd33ec5e52 Note that this patch is not replacing the Inktank logo - it's just the Ceph logo. So there's no references to "Inktank" in the images any more. Those were fixed upstream in http://tracker.ceph.com/issues/8408 a while ago. Neil and Tamil, please clarify if this particular bug should block the Red Velvet release. If so, Boris or I will unlock our errata out of the QE state to attach a new calamari-clients package. If not, we'll keep it as is (in QE, with the calamari-clients-1.2.3-2 package).
On IRC Tamil told me that she would prefer to get an ack from Ian, John or Neil on this. Adding Ian and John to the CC here.
Also, if it's not a problem to have the RH logo in the upstream source, it seems like the efficiency/self-documenting would be worth having them both available and just have the patch switch a symlink, rather than the patch containing the whole image file.
I have a branch in calamari that swaps ceph community logos for Red Hat shadowman logo. I had to make a change to navbar height so there is a code change too. branch is called: https://github.com/ceph/calamari-clients/tree/wip-change-logo There relevant commits are: https://github.com/ceph/calamari-clients/compare/1.2.3...wip-change-logo
We should probably check with someone in Red Hat Legal to verify that we are permitted to distribute the Red Hat logo upstream.
Forget my comment 4; that's not going to be workable. But I suppose this will need to be maintained as a downstream patch.
Yes. I will not/do not plan to merge this upstream. I would prefer for this to be a patch for the short term, I will happily take the branch down once we have the patch for the red-velvet release. I think we should be creating a downstream repo soon. Ken would you please make such a patch?
Discussed this in ICE bug scrub today. Can we clarify that this bug should block the RHEL release? (are we willing to slip the Red Velvet schedule for this?)
We can just ship the Ceph logo (ie the default upstream logo) for now if completing this BZ is going to add delay. So no, I don't want this to be blocker - we can always fix it in an async update straight after Red Velvet comes out. JohnP: this is a good candidate for that quick, lightweight async update to help embed the process that we discussed yesterday. However, for my info I am still confused about how we maintain patches to upstream code in the downstream product. Is there a distinct downstream git branch as Kanagaraj states? Changing logos is surely the most common (and presumably least invasive) modification that all products with a UI require?
Yes. The downstream repo is known as "dist-git". It contains just the spec file, patches, and a reference to the upstream source tarball.
To be clear, not a blocker on non-RHEL 1.2.3 for non-RHEL platforms. Can we make this ticket specific to RHEL 1.2.3 and get this patch included?
There are no blocker bugs open that would cause us to rebuild calamari-server for other reasons, so my inclination is to ship the calamari-server package that we have right now.
OK. If we do get a blocker bug on Calamari-server then let's add this in then.
I'd like the Red Hat logo properly everywhere in 1.3. Adding target.
will this be fixed in 1.3.0?
currently the target release is marked as 1.2.4. If this is going to be fixed in 1.3.0, can you please change the target release accordingly?
Redhat logo is displayed in GUI and Login screen in 1.3.0. Marking this defect as verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2015:1183