Spec URL: https://tc01.fedorapeople.org/tilp2/gfm.spec SRPM URL: https://tc01.fedorapeople.org/tilp2/gfm-1.07-0.fc21.src.rpm Description: The GFM is an application allowing for the manipulation of single/group/tigroup files from all Texas Instruments handhelds. It can create a new file, open an existing file, save file, rename variables, remove variables, create folders, group files into a group/tigroup file, and ungroup a group/tigroup file into single files. Fedora Account System Username: tc01
- Use %global - Start from release 1, so 1%{?dist} - 'configure' provides interesting various options, among which --disable-rpath --with-xinerama --with-kde - desktop file(s) with MimeType entry in gfm See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database - License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Why is %find_lang not used? - appdata file is missing. See http://fedoraproject.org/wiki/Packaging:Guidelines#AppData_files
Fixed all of those, and I wrote an appdata file that I'll send upstream. I've added --disable-rpath --with-xinerama to configure and added libXinerama-devel as a dependency. I have *not* turned on --with-kde; configure failed when I ran it with that option and I strongly suspect that the KDE support in gfm (and probably tilp2) predates KDE4 and hasn't been touched by upstream in a long time. It might still work with some tweaking (but it refers to "kde-config" instead of "kde4-config", so). Spec URL: https://tc01.fedorapeople.org/tilp2/gfm.spec SRPM URL: https://tc01.fedorapeople.org/tilp2/gfm-1.07-1.fc21.src.rpm
- In the build-log i see: + appstream-util validate-relax --nonet /builddir/build/BUILDROOT/gfm-1.07-1.fc23.x86_64//usr/share/appdata/gfm.appdata.xml /builddir/build/BUILDROOT/gfm-1.07-1.fc23.x86_64//usr/share/appdata/gfm.appdata.xml: GLib-GIO-Message: Using the 'memory' GSettings backend. Your settings will not be saved or shared with other applications. OK It seems that by installing 'dconf', above message disappears. - Remove Requires(post): desktop-file-utils Requires(postun): desktop-file-utils Your package needs: BuildRequires: desktop-file-utils Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/sagitter/1186558-gfm/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in gfm [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [?]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gfm-1.07-1.fc23.x86_64.rpm gfm-1.07-1.fc23.src.rpm gfm.x86_64: W: spelling-error Summary(en_US) handheld -> handhold, hand held, hand-held gfm.x86_64: W: spelling-error %description -l en_US tigroup -> ti group, ti-group, Citigroup gfm.x86_64: W: spelling-error %description -l en_US handhelds -> handholds, handhold gfm.x86_64: W: spelling-error %description -l en_US ungroup -> grouping, group, roundup gfm.src: W: spelling-error Summary(en_US) handheld -> handhold, hand held, hand-held gfm.src: W: spelling-error %description -l en_US tigroup -> ti group, ti-group, Citigroup gfm.src: W: spelling-error %description -l en_US handhelds -> handholds, handhold gfm.src: W: spelling-error %description -l en_US ungroup -> grouping, group, roundup 2 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: gfm-debuginfo-1.07-1.fc23.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- gfm (rpmlib, GLIBC filtered): /bin/sh desktop-file-utils libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglade-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libstdc++.so.6()(64bit) libticables2.so.6()(64bit) libticalcs2.so.11()(64bit) libticonv.so.7()(64bit) libtifiles2.so.9()(64bit) libxml2.so.2()(64bit) rtld(GNU_HASH) Provides -------- gfm: appdata() appdata(gfm.appdata.xml) application() application(gfm.desktop) gfm gfm(x86-64) mimehandler(application/x-tilp) Source checksums ---------------- http://sourceforge.net/projects/tilp/files/tilp2-linux/tilp2-1.17/gfm-1.07.tar.bz2 : CHECKSUM(SHA256) this package : 5356769f5d874aed3fe138161ae628af6a74551b992c954f64d155493fc07f71 CHECKSUM(SHA256) upstream package : 5356769f5d874aed3fe138161ae628af6a74551b992c954f64d155493fc07f71 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1186558 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Oh, I misread the guidelines about desktop-file-utils. Whoops. Added dconf as a BuildRequires. That seems to make that warning go away, as you say. Spec URL: https://tc01.fedorapeople.org/tilp2/gfm.spec SRPM URL: https://tc01.fedorapeople.org/tilp2/gfm-1.07-2.fc21.src.rpm
Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/sagitter/1186558-gfm/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in gfm [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gfm-1.07-2.fc24.x86_64.rpm gfm-1.07-2.fc24.src.rpm gfm.x86_64: W: spelling-error Summary(en_US) handheld -> handhold, hand held, hand-held gfm.x86_64: W: spelling-error %description -l en_US tigroup -> ti group, ti-group, Citigroup gfm.x86_64: W: spelling-error %description -l en_US handhelds -> handholds, handhold gfm.x86_64: W: spelling-error %description -l en_US ungroup -> grouping, group, roundup gfm.src: W: spelling-error Summary(en_US) handheld -> handhold, hand held, hand-held gfm.src: W: spelling-error %description -l en_US tigroup -> ti group, ti-group, Citigroup gfm.src: W: spelling-error %description -l en_US handhelds -> handholds, handhold gfm.src: W: spelling-error %description -l en_US ungroup -> grouping, group, roundup 2 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: gfm-debuginfo-1.07-2.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- gfm (rpmlib, GLIBC filtered): /bin/sh libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglade-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libstdc++.so.6()(64bit) libticables2.so.6()(64bit) libticalcs2.so.11()(64bit) libticonv.so.7()(64bit) libtifiles2.so.9()(64bit) libxml2.so.2()(64bit) rtld(GNU_HASH) Provides -------- gfm: appdata() appdata(gfm.appdata.xml) application() application(gfm.desktop) gfm gfm(x86-64) mimehandler(application/x-tilp) Source checksums ---------------- http://sourceforge.net/projects/tilp/files/tilp2-linux/tilp2-1.17/gfm-1.07.tar.bz2 : CHECKSUM(SHA256) this package : 5356769f5d874aed3fe138161ae628af6a74551b992c954f64d155493fc07f71 CHECKSUM(SHA256) upstream package : 5356769f5d874aed3fe138161ae628af6a74551b992c954f64d155493fc07f71 https://tc01.fedorapeople.org/tilp2/gfm.appdata.xml : CHECKSUM(SHA256) this package : 3f7c09bbe2d451c943b0d16bb21ac34cbd67d5b51d3f3495dd1ab65d82f0957f CHECKSUM(SHA256) upstream package : 3f7c09bbe2d451c943b0d16bb21ac34cbd67d5b51d3f3495dd1ab65d82f0957f Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1186558 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
New Package SCM Request ======================= Package Name: gfm Short Description: Texas Instruments handheld(s) file manipulation program Upstream URL: https://sourceforge.net/projects/tilp/ Owners: tc01 Branches: f21 f22 f23 InitialCC:
Git done (by process-git-requests).
gfm-1.07-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/gfm-1.07-3.fc21
gfm-1.07-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gfm-1.07-3.fc22
gfm-1.07-3.fc22 has been pushed to the Fedora 22 testing repository.
gfm-1.07-3.fc21 has been pushed to the Fedora 21 stable repository.
gfm-1.07-3.fc22 has been pushed to the Fedora 22 stable repository.