Created attachment 985108 [details]
remove quotes around daemon() parameters

Description of problem:

/etc/init.d/numad calls

    daemon "$exec -i $INTERVAL"

upon start().

This confuses daemon() and subsequently __pids_var_run() function and leads to bogus error messages:

Starting numad: /usr/bin/dirname: extra operand `-i'
Try `/usr/bin/dirname --help' for more information.


Version-Release number of selected component (if applicable):

numad-0.5-11.20140620git.el6.x86_64
initscripts-9.03.46-1.el6.x86_64

How reproducible:

Always

Steps to Reproduce:
1. # service numad (re)?start


Actual results:

Starting numad: /usr/bin/dirname: extra operand `-i'
Try `/usr/bin/dirname --help' for more information.
                                                           [  OK  ]

Expected results:

Starting numad:                                            [  OK  ]

Additional info:

Doesn't reproduce with initscripts-9.03.40-2.el6_5.4, bug is triggered by patch:

- init.d/functions: check parent dir of pid file for accessibility

 __pids_var_run() {
 	local base=${1##*/}
 	local pid_file=${2:-/var/run/$base.pid}
-	local pid_dir=$(/usr/bin/dirname $pid_file)
 	local binary=$3
 
-	[ -d "$pid_dir" -a ! -r "$pid_dir" ] && return 4
-
 	pid=
 	if [ -f "$pid_file" ] ; then
 	        local line p

Patch removing quotes attached. I'll check the initscripts package, daemon() and __pids_var_run() functions should be more robust IMHO as well.