Bug 1187175 - Review Request: perl-Cwd-utf8 - Fully UTF-8 aware Cwd
Summary: Review Request: perl-Cwd-utf8 - Fully UTF-8 aware Cwd
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1180497
TreeView+ depends on / blocked
 
Reported: 2015-01-29 13:32 UTC by Petr Pisar
Modified: 2015-01-30 14:35 UTC (History)
2 users (show)

Fixed In Version: perl-Cwd-utf8-0.007-1.fc22
Clone Of:
Environment:
Last Closed: 2015-01-30 14:35:33 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2015-01-29 13:32:12 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Cwd-utf8/perl-Cwd-utf8.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Cwd-utf8/perl-Cwd-utf8-0.007-1.fc22.src.rpm
Description:
While the original Cwd functions are capable of handling UTF-8 quite well,
they expects and return all data as bytes, not as characters. This Cwd::utf8
Perl module replaces all the Cwd functions with fully UTF-8 aware versions,
both expecting and returning characters.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2015-01-30 09:48:57 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Cwd-utf8-0.007-1.fc22.noarch.rpm | sort | uniq -c
      1 perl >= 1:5.010
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Carp)
      1 perl(Cwd)
      1 perl(Encode)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Cwd-utf8-0.007-1.fc22.noarch.rpm | sort | uniq -c
      1 perl(Cwd::utf8) = 0.007
      1 perl-Cwd-utf8 = 0.007-1.fc22
Binary provides are Ok.

$ rpmlint ./perl-Cwd-utf8.spec ./perl-Cwd-utf8-0.007-1.fc22.*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Package APPROVED.

Comment 2 Petr Pisar 2015-01-30 10:10:29 UTC
New Package SCM Request
=======================
Package Name: perl-Cwd-utf8
Short Description: Fully UTF-8 aware Cwd
Upstream URL: http://search.cpan.org/dist/Cwd-utf8/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-01-30 13:59:39 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2015-01-30 14:35:33 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.