Bug 1187629 - Review Request: devassistant-dap-tito - Tito snippet to use in other assistants
Summary: Review Request: devassistant-dap-tito - Tito snippet to use in other assistants
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1186748
TreeView+ depends on / blocked
 
Reported: 2015-01-30 14:13 UTC by Tomas 'Sheldon' Radej
Modified: 2015-03-18 11:28 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-18 11:28:33 UTC
Type: ---
Embargoed:
mhroncok: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Tomas 'Sheldon' Radej 2015-01-30 14:13:53 UTC
Spec URL: https://tradej.fedorapeople.org/reviews/daps/devassistant-dap-tito/0/devassistant-dap-tito.spec
SRPM URL: https://tradej.fedorapeople.org/reviews/daps/devassistant-dap-tito/0/devassistant-dap-tito-0.10.0dev-3.fc21.src.rpm
Description: Snippet that runs tito init in assistants, where you want it

Fedora Account System Username: tradej

Comment 2 Miro Hrončok 2015-02-03 20:04:41 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues
======

[!]: Package complies to the Packaging Guidelines
     Note: This is just the consequence of the next point
[!]: Package does not contain duplicates in %files.

rpmlint:

     devassistant-dap-tito.src:38: W: macro-in-%changelog %license
     
     Use %%license ore drop pre-git changelog entries when importing to git.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
     Note: In this case, I consider the DevAssistant packages as "notable
     exception to this packaging model" as mentioned in guidelines
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
     Note: See other issues for explanation.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[!]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: devassistant-dap-tito-0.10.0dev-4.fc22.noarch.rpm
          devassistant-dap-tito-0.10.0dev-4.fc22.src.rpm
devassistant-dap-tito.noarch: W: spelling-error %description -l en_US init -> unit, int, nit
devassistant-dap-tito.src: W: spelling-error %description -l en_US init -> unit, int, nit
devassistant-dap-tito.src:38: W: macro-in-%changelog %license
2 packages and 0 specfiles checked; 0 errors, 3 warnings.


Seem OK, except the macro in changelog.

Requires
--------
devassistant-dap-tito (rpmlib, GLIBC filtered):
    devassistant-ui



Provides
--------
devassistant-dap-tito:
    devassistant-dap-tito



Source checksums
----------------
https://dapi.devassistant.org/download/tito-0.10.0dev.dap :
  CHECKSUM(SHA256) this package     : 7af6d8a1d28a9615383ad1c6f30d540b9dfd43fd4e1122bebb28d2e0997dd50c
  CHECKSUM(SHA256) upstream package : 7af6d8a1d28a9615383ad1c6f30d540b9dfd43fd4e1122bebb28d2e0997dd50c

Package NOT APPROVED.

Comment 4 Miro Hrončok 2015-02-04 13:15:01 UTC
Fixed. APPROVED.

Comment 5 Tomas 'Sheldon' Radej 2015-02-04 15:43:49 UTC
New Package SCM Request
=======================
Package Name: devassistant-dap-tito
Short Description: Tito snippet to use in other assistants
Upstream URL: https://github.com/devassistant/dap-tito
Owners: bkabrda
Branches:
InitialCC:

Comment 6 Gwyn Ciesla 2015-02-04 19:48:22 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.