Bug 1187718 - please update netty3 to 3.9.3 (or maybe higher)
Summary: please update netty3 to 3.9.3 (or maybe higher)
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: netty3
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Marek Goldmann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1187710 1187713
Blocks: Elasticsearch
TreeView+ depends on / blocked
 
Reported: 2015-01-30 18:05 UTC by jiri vanek
Modified: 2015-02-17 09:36 UTC (History)
11 users (show)

Fixed In Version: netty3-3.9.3-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-12 17:54:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
minimal work to update (sources already uploaded in lookaside cache) (6.23 KB, patch)
2015-01-30 18:06 UTC, jiri vanek
no flags Details | Diff
same patch, wrapped as git export (8.27 KB, patch)
2015-02-12 13:40 UTC, jiri vanek
no flags Details | Diff

Description jiri vanek 2015-01-30 18:05:06 UTC
The 3.9.3 is in sync with elastic search. But higher may work to.

The built packages are avaiable :  https://jvanek.fedorapeople.org/elasticsearch/v4/netty3-master-3.9.3/

It was quite pain to update - one new package neede (netty-tcnative - fork2) and one need to ne updated (gpars). Also I'm feeling uneasy about removal of NPN it should be fixed before update, but during quick looking I did not figured out how.

Comment 1 jiri vanek 2015-01-30 18:06:31 UTC
Created attachment 986122 [details]
minimal work to update (sources already uploaded in lookaside cache)

Comment 2 jiri vanek 2015-01-30 18:18:03 UTC
Waiting for new pakage:
https://bugzilla.redhat.com/show_bug.cgi?id=1187713
And locked on versions with gpars:
https://bugzilla.redhat.com/show_bug.cgi?id=1187710

Comment 3 Marek Goldmann 2015-02-02 11:41:47 UTC
Added a few people that maintain packages that may be affected by this update. Do you guys have any objections to update netty3 package in Rawhide to 3.9.3?

Comment 4 Mikolaj Izdebski 2015-02-02 11:44:39 UTC
No objection from me, as long as it is rawhide only.

Comment 5 Petr Machata 2015-02-02 12:29:32 UTC
I am not aware of any package that I own that should depend on netty3.  Can you be explicit, please?

Comment 6 Mikolaj Izdebski 2015-02-02 12:32:39 UTC
For reference, packages that require netty3: akka avro bookkeeper gpars gradle hadoop hbase hive littleproxy pig thermostat zookeeper

Comment 7 Petr Machata 2015-02-02 12:42:19 UTC
OK, I don't think I own any of these, but I touched zookeeper and bookkeeper in the past.  Maybe CC-ing "PKGNAME-owner" is a better approach, but not sure it would work--those are not bugzilla accounts, presumably.

Comment 8 Michal Srb 2015-02-02 12:44:35 UTC
Fine by me, go ahead.

Comment 9 jiri vanek 2015-02-02 12:48:41 UTC
(In reply to Mikolaj Izdebski from comment #4)
> No objection from me, as long as it is rawhide only.

yes.

Comment 10 Robert Rati 2015-02-02 13:19:37 UTC
What kind of compatibility is expected?  The version of netty that is packaged as a compat is that version because it works for packages that need netty 3.x.  Unless there is a high degree of confidence that updating to 3.9 will not break those that need the current 3.x package, I would recommend a different compat package if something needs 3.9.

Comment 11 jiri vanek 2015-02-02 13:25:09 UTC
So you wont to have netty32 netty39 or even better netty393 and netty396  netty310 and so on?

I think we can expect backward compatibility during any netty3* , so unless there is proof against, I would rather keep only one netty3

Comment 12 Mikolaj Izdebski 2015-02-02 13:36:08 UTC
I agree with Jiri, we should try to update to 3.9 before adding new compat package.

Comment 13 Robert Rati 2015-02-02 13:43:57 UTC
The java community has not shown a strong inclination to keep compatibility between any versions.  I would prefer that packages try to be compiled against a new compat package to verify compatibility before just upgrading the compat package.  Again, this is a compat package that exists at the current version because that is what is known to work by those packages that need it.

What is the source of the request to upgrade to 3.9?

Comment 14 jiri vanek 2015-02-02 13:54:08 UTC
I think the block flag is pretty clear.

However - netty3 is little bit non standard compact package. Netty v3 is living version of netty. Api changed when netty updated form 3.x to 4.

Some packages were impossible to adapt to 4, so netty3 compact was created. compact packages should not held minor versions updates.

Comment 15 Pete MacKinnon 2015-02-02 17:47:02 UTC
As Rob, says I would need to time to assess the impact on my packages. Minor updates (Y) don't always provide back compat assurances.

Comment 16 jiri vanek 2015-02-12 11:39:21 UTC
Hi, dependence built.
http://koji.fedoraproject.org/koji/taskinfo?taskID=8906958
Marek, may you update netty3 now (both rawhide and f22) Or make me co-maintainer   and I will do.

Comment 17 jiri vanek 2015-02-12 13:40:58 UTC
Created attachment 990937 [details]
same patch, wrapped as git  export

Scratch
 http://koji.fedoraproject.org/koji/taskinfo?taskID=8908140
passed

Comment 18 jiri vanek 2015-02-12 13:57:15 UTC
Once built, guys, mnay you double check you work with it?
akka  willb 
avro   ricardo 
zookeeper, bookkeeper  tstclair
gpars, gradle  mizdebsk 
hbase, hadoop  rrati 
pig, hive   pmackinn
littleproxy    gil
thermostat  omajid

Comment 19 Marek Goldmann 2015-02-12 17:54:34 UTC
New package has been built, thanks Jiri!

Comment 20 Severin Gehwolf 2015-02-17 09:36:48 UTC
(In reply to jiri vanek from comment #18)
> thermostat  omajid

Thermostat rebuilt using updated netty:
F22: http://koji.fedoraproject.org/koji/buildinfo?buildID=611836
Rawhide: http://koji.fedoraproject.org/koji/buildinfo?buildID=611791


Note You need to log in before you can comment on or make changes to this bug.