Compiling dht-common.c with shows warnings: CC dht-common.lo dht-common.c:2997:57: warning: size argument in 'strncmp' call is a comparison [-Wmemsize-comparison] strlen (GF_XATTR_LOCKINFO_KEY) != 0))) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ dht-common.c:2996:17: note: did you mean to compare the result of 'strncmp' instead? && (strncmp (key, GF_XATTR_LOCKINFO_KEY, ^ dht-common.c:2997:26: note: explicitly cast the argument to size_t to silence this warning strlen (GF_XATTR_LOCKINFO_KEY) != 0))) { ^ (size_t)( ) I believe that the a parentes is misplaced, so the code is doing strncmp(key, GF_XATTR_LOCKINFO_KEY, 0) instead of strncmp(key, GF_XATTR_LOCKINFO_KEY, strlen(GF_XATTR_LOCKINFO_KEY) )
REVIEW: http://review.gluster.org/9518 (Compare key with GF_XATTR_LOCKINFO_KEY with length of GF_XATTR_LOCKINFO_KEY instead of length of 0) posted (#1) for review on master by Dennis Schafroth (dennis)
REVIEW: http://review.gluster.org/9544 (Compare key with GF_XATTR_LOCKINFO_KEY with length of GF_XATTR_LOCKINFO_KEY instead of length of 1) posted (#1) for review on master by Dennis Schafroth (dennis)
REVIEW: http://review.gluster.org/9518 (Compare key with GF_XATTR_LOCKINFO_KEY with length of GF_XATTR_LOCKINFO_KEY instead of length of 0) posted (#164) for review on master by Vijay Bellur (vbellur)
COMMIT: http://review.gluster.org/9518 committed in master by Vijay Bellur (vbellur) ------ commit f9e6f25fb5576c0b0cf9377d49c9896fa8278c00 Author: Dennis Schafroth <dennis> Date: Sat Jan 31 19:23:16 2015 +0100 Compare key with GF_XATTR_LOCKINFO_KEY with length of GF_XATTR_LOCKINFO_KEY instead of length of 0 BUG: 1187952 Change-Id: I0a97c553e85a0f9260ab01d4b48c64831bf67c18 Signed-off-by: Dennis Schafroth <dennis> Reviewed-on: http://review.gluster.org/9518 Reviewed-by: Joe Julian <joe> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Pranith Kumar Karampuri <pkarampu> Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Raghavendra G <rgowdapp> Reviewed-by: Vijay Bellur <vbellur> Tested-by: Vijay Bellur <vbellur>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user