Bug 1188204 - [GSS] (6.4.z) Invalid ?wsdl response with relative imports/includes when using jaxws-catalog.xml
Summary: [GSS] (6.4.z) Invalid ?wsdl response with relative imports/includes when usin...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: Web Services
Version: 6.4.1
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: CR1
: EAP 6.4.4
Assignee: Tomas Hofman
QA Contact: Rostislav Svoboda
URL:
Whiteboard:
Depends On:
Blocks: 1234813 1235744
TreeView+ depends on / blocked
 
Reported: 2015-02-02 10:35 UTC by Mustafa Musaji
Modified: 2019-08-15 04:13 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1267676 (view as bug list)
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)
Reproducer (15.64 KB, application/zip)
2015-02-02 10:36 UTC, Mustafa Musaji
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Apache JIRA CXF-6234 0 None None None Never
Apache JIRA CXF-6392 0 None None None Never

Description Mustafa Musaji 2015-02-02 10:35:36 UTC
Description of problem:
Invalid ?wsdl response with relative imports/includes when using jaxws-catalog.xml

https://issues.apache.org/jira/browse/CXF-6234

Version-Release number of selected component (if applicable):


How reproducible:
Everytime

Steps to Reproduce:
1. Deploy reproduce to JBoss EAP 
2. http://localhost:8080/test_schema_validation/service_v1/ServiceBean?wsdl
3. Check included schemaLocation from the imported schema's in the WSDL. The URL is not resolveable.

Actual results:
<include schemaLocation="test_included_1a.xsd"/>

Expected results:
<include schemaLocation="http://localhost:8080/test_schema_validation/service_v1/ServiceBean?xsd=http://www.tno.nl/xsd/test/messages/test_included_1a.xsd"/>

Additional info:

Comment 1 Mustafa Musaji 2015-02-02 10:36:38 UTC
Created attachment 987054 [details]
Reproducer

See reproducer zip for instructions and proposed patch which I've opened CXF-6234 for.

Comment 7 Rostislav Svoboda 2015-04-27 11:14:50 UTC
SET/GSS - please provide automated test (as discussed on triage) to increase CP throughput.
I will qa_ack afterwards or when the scope of CP01 is clear and we have enough seats.

Comment 19 Tomas Hofman 2015-05-06 15:17:28 UTC
I opened new upstream issue for this with implemented test case and new proposed fix: https://issues.apache.org/jira/browse/CXF-6392

Upstream PRs:

master: https://github.com/apache/cxf/pull/68
2.7.x-fixes: https://github.com/apache/cxf/pull/69

Comment 21 Jan Blizňák 2015-06-23 09:43:46 UTC
If I understand it correctly, this is what should I check:

1) deploy service from https://bugzilla.redhat.com/attachment.cgi?id=987054
2) check http://localhost:8080/test_schema_validation/service_v1/ServiceBean?wsdl
3) check http://localhost:8080/test_schema_validation/service_v1/ServiceBean?xsd=http://www.tno.nl/xsd/test/messages/test.xsd

Expected results:
2)
<xsd:import namespace="http://www.tno.nl/xsd/test/messages" schemaLocation="http://localhost:8080/test_schema_validation/service_v1/ServiceBean?xsd=http://www.tno.nl/xsd/test/messages/test.xsd"/>

3)
<include schemaLocation="http://localhost:8080/test_schema_validation/service_v1/ServiceBean?xsd=test_included_1a.xsd"/>
<include schemaLocation="http://localhost:8080/test_schema_validation/service_v1/ServiceBean?xsd=test_included_1b.xsd"/>


Results with 6.4.2.CP.CR1
2) OK, wsdl contains:
<xsd:import namespace="http://www.tno.nl/xsd/test/messages" schemaLocation="http://localhost:8080/test_schema_validation/service_v1/ServiceBean?xsd=http://www.tno.nl/xsd/test/messages/test.xsd"/>


3) FAIL, xsd contains:
<include schemaLocation="test_included_1a.xsd"/>
<include schemaLocation="test_included_1b.xsd"/>


So the fix is not there. Which is quite expected because https://issues.apache.org/jira/browse/CXF-6392 has fix version 2.7.17.
Just for sure I decompiled cxf-rt-frontend-simple-2.7.16.redhat-1.jar and the fix https://github.com/apache/cxf/commit/d8121567d916b7bfccb1ded997b825b81ba8449f is not included.

Comment 22 Jan Blizňák 2015-09-22 13:15:21 UTC
Check on 6.4.4.CP.CR3:

1) deploy service from https://bugzilla.redhat.com/attachment.cgi?id=987054

2) check http://localhost:8080/test_schema_validation/service_v1/ServiceBean?wsdl
--> OK, wsdl contains:
<xsd:import namespace="http://www.tno.nl/xsd/test/messages" schemaLocation="http://localhost:8080/test_schema_validation/service_v1/ServiceBean?xsd=http://www.tno.nl/xsd/test/messages/test.xsd"/>


3) check http://localhost:8080/test_schema_validation/service_v1/ServiceBean?xsd=http://www.tno.nl/xsd/test/messages/test.xsd
--> FAIL, xsd contains:
<include schemaLocation="test_included_1a.xsd"/>
<include schemaLocation="test_included_1b.xsd"/>


So results with 6.4.4.CP.CR3 are the same as with 6.4.2.CP.CR1, ie. it is still not fixed, even with CXF-6392 fix in place in cxf-rt-frontend-simple-2.7.17.redhat-1.jar.

Comment 23 Romain Pelisse 2015-09-28 13:25:49 UTC
As Tomas is off today, I've take an other look at this issue. First of all, I confims Jan test, the fix still appears to be missing. It also missing from the "community" jar (cxf-rt-frontend-simple-2.7.17.jar) as I've swap the cxf-rt-frontend-simple-2.7.17.redhat-1.jar for it, just to check.

However, code wise, it seems that the fix is in the mainteance branch:

$ git branch -r --contains d8121567d916b7bfccb1ded997b825b81ba8449f
  origin/2.7.x-fixes
$

I've build and tried cxf-rt-frontend-simple-2.7.18-SNAPSHOT.jar, but with this one the reproducer throws some validation exception on deployment. So finally, I've cherry pick the commit on the 2.7.17 tag but no changes, confirming, if needed, that the the commit is indeed part of the 2.7.17 releases.

Thus, it seems that the proposed fix does NOT solve item 3). I'm going to look if I can come up with a fix, and synchronise, if needed with Tomas tomorrow.

Comment 24 Tomas Hofman 2015-09-29 15:21:32 UTC
I believe I should have upstream commit during tomorrow.

Comment 25 Tomas Hofman 2015-09-29 15:21:52 UTC
Meaning PR, not commit.

Comment 27 Tomas Hofman 2015-09-30 16:00:03 UTC
Cloned to #1267676.

Comment 28 Rostislav Svoboda 2015-10-05 12:50:50 UTC
EAP 6.4.4 CR4 status:
 - case 1) and 2) from comment 22 are working
 - case 3) from comment 22 is not working, follow up issue created - see BZ 1267676
 - this BZ didn't solve originally reported problem, it solves CXF-6392 and CXF-6234 issues
 - original customer problem will be solved in BZ 1267676

Comment 29 Petr Penicka 2017-01-17 10:50:54 UTC
Retroactively bulk-closing issues from released EAP 6.4 cumulative patches.

Comment 30 Petr Penicka 2017-01-17 10:51:11 UTC
Retroactively bulk-closing issues from released EAP 6.4 cumulative patches.


Note You need to log in before you can comment on or make changes to this bug.