Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1188218

Summary: [RFE] - Add of exit code for client termination.
Product: Red Hat Enterprise Virtualization Manager Reporter: Yaniv Lavi <ylavi>
Component: mingw-virt-viewerAssignee: Default Assignee for SPICE Bugs <rh-spice-bugs>
Status: CLOSED WONTFIX QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: cfergeau, dblechte, ecohen, gklein, lsurette, marcandre.lureau, michal.skrivanek, rbalakri, tjelinek, yeylon, ylavi
Target Milestone: ---Keywords: FutureFeature
Target Release: 3.6.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: spice
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-19 13:05:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Spice RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1188212    

Description Yaniv Lavi 2015-02-02 11:09:02 UTC
Description of problem:
Currently in virt-viewer there is no way to know why client terminated. We currently have this functionality in xpi and activex plugin and we need this to fully support virt-viewer.

Comment 1 Marc-Andre Lureau 2015-02-02 11:57:19 UTC
(In reply to Yaniv Dary from comment #0)
> Description of problem:
> Currently in virt-viewer there is no way to know why client terminated. We
> currently have this functionality in xpi and activex plugin and we need this
> to fully support virt-viewer.

I am surprised I never heard of this feature before. What is the error code used for? I can see the following errors could be reported by XPI:
- SUCCESS
- HOST_NOT_FOUND, WINSOCK_CONNECT_FAILED:
  => this error is displayed in client already
- CODE_INTERNAL_ERROR, WINSOCK_FAILED, OUT_OF_MEMORY, CODE_TIMEOUT, CODE_INTERNAL_ERROR
  => what can you do with that but log?

Imho, we should reconsider if those errors are really useful: virt-viewer never reported such codes, so applet probably returned SUCCESS or INTERNAL_ERROR. What RHEVM can do about this?

Comment 2 Tomas Jelinek 2015-02-03 08:47:13 UTC
We currently expect that the XPI/ActiveX returns some return code and if it is an error code (>100) than we translate it to error message and display it.
We have the SPICE and RDP error messages in one property file and I'm not sure which is which so attaching the whole property file:

E1028=WinSock recv call failed
E1030=Invalid Security Data
E1032=Internal error (code 1032)
E1286=Invalid Encryption Method
E1288=DNS Lookup failed
E1540=GetHostByName call failed
E1542=Invalid server security data
E1544=Internal Error (timer error)
E1796=Timeout occurred
E1798=Failed to unpack server certificate
E2052=Bad IP address specified
E2054=Internal Security Error
E2308=Socket closed
E2310=Internal Security Error
E2566=Internal Security Error
E260=DNS Lookup Failed
E262=Out of memory condition
E264=Connection Timed Out
E2822=Encryption error
E3078=Decryption error
E516=The client could not connect to the remote computer.\nRemote connections might not be enabled or a network problem is preventing your connection.
E518=Out of memory condition
E520=The specified remote computer could not be found.
E772=WinSock send call failed
E774=Out of memory condition
E776=Invalid IP address specified
E2824=Unexpected RDP disconnection
E107=SPICE encountered an SSL error while trying to connect to the Virtual Machine. This may happen due to:\n- SSL certificate errors, when the Host certificate does not match its Name, or is not valid, time-wise.\n- Errors during the establishment of the SSL channel.\nVerify the Host is properly resolvable and that time is correctly configured on both client and host and retry.
E110=SPICE guest agent reported an error
E111=SPICE Version mismatch
E112=Permission Denied