Bug 1188304 - rabbit: more precise iterconsume timeout
Summary: rabbit: more precise iterconsume timeout
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-oslo-messaging
Version: 6.0 (Juno)
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 6.0 (Juno)
Assignee: Flavio Percoco
QA Contact: Udi Shkalim
URL:
Whiteboard:
: 1230134 (view as bug list)
Depends On:
Blocks: 1214764
TreeView+ depends on / blocked
 
Reported: 2015-02-02 15:05 UTC by John Eckersberg
Modified: 2023-02-22 23:02 UTC (History)
10 users (show)

Fixed In Version: python-oslo-messaging-1.4.1-4.el7ost
Doc Type: Bug Fix
Doc Text:
Previously, oslo.messaging could enter a loop while waiting for messages, if RabbitMQ had died. This update adds a more precise timeout handling for message consumption, allowing the poll operations on specific connections to end whenever such scenarios occur.
Clone Of:
Environment:
Last Closed: 2015-08-24 14:48:29 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 161119 0 'None' 'MERGED' 'Fix _poll_connection not timeout issue (1/2)' 2019-12-09 03:42:21 UTC
Red Hat Product Errata RHBA-2015:1659 0 normal SHIPPED_LIVE Red Hat Enterprise Linux OpenStack Platform Bug Fix and Enhancement Advisory 2015-08-24 18:47:56 UTC

Description John Eckersberg 2015-02-02 15:05:15 UTC
There are several ways that oslo.messaging can get hung when trying to reconnect to RabbitMQ.  This upstream change, pending Juno backport, addresses this:

https://review.openstack.org/#/c/143805/

It would be good to get this backport into RHOS-6.0.

Comment 5 Alan Pevec 2015-04-09 09:39:56 UTC
Please use RDO patches branch, I've now rebased it on top of stable/juno:
https://github.com/redhat-openstack/oslo.messaging/commits/juno-patches

Does that include all required patches or we need to cherry-pick something not backported to upstream stable/juno yet?

Comment 6 hguemar 2015-04-09 09:43:36 UTC
@Alan: good enough for me.

Comment 7 Flavio Percoco 2015-04-16 09:29:09 UTC
@Alan, it does provide the patch.

@hguemar, this now needs to be built.

Thank you, both

Comment 19 Udi Shkalim 2015-08-18 13:39:36 UTC
Verified using the following procedure:

 * Start a service that uses oslo.messaging with rabbitmq e.g. nova-compute

 * Stop rabbitmq while tail-F /var/log/nova/nova-compute.log

 * Observe that nova-compute amqp times out and it is trying to reconnect

 * Restart rabbitmq

 * Observe that rabbitmq connection has re-established

Without the fix a reoccurring message in rabbitmq log was showing:
=ERROR REPORT==== 18-Aug-2015::16:15:54 ===
closing AMQP connection <0.792.0> (10.35.160.37:42202 -> 10.35.160.37:5672):
{handshake_timeout,handshake}

Version:
2014.2.3
python-oslo-messaging-1.4.1-5.el7ost.noarch

Comment 20 John Eckersberg 2015-08-18 13:48:57 UTC
(In reply to ushkalim from comment #19)
> Verified using the following procedure:
> 
>  * Start a service that uses oslo.messaging with rabbitmq e.g. nova-compute
> 
>  * Stop rabbitmq while tail-F /var/log/nova/nova-compute.log
> 
>  * Observe that nova-compute amqp times out and it is trying to reconnect
> 
>  * Restart rabbitmq
> 
>  * Observe that rabbitmq connection has re-established
> 
> Without the fix a reoccurring message in rabbitmq log was showing:
> =ERROR REPORT==== 18-Aug-2015::16:15:54 ===
> closing AMQP connection <0.792.0> (10.35.160.37:42202 -> 10.35.160.37:5672):
> {handshake_timeout,handshake}
> 
> Version:
> 2014.2.3
> python-oslo-messaging-1.4.1-5.el7ost.noarch

Awesome news.  I've seen that handshake_timeout before and was wondering what was causing it from the client side.  If this makes that go away, I will be extra happy.

Comment 21 Flavio Percoco 2015-08-19 08:32:14 UTC
*** Bug 1230134 has been marked as a duplicate of this bug. ***

Comment 23 errata-xmlrpc 2015-08-24 14:48:29 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1659.html


Note You need to log in before you can comment on or make changes to this bug.