Spec URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-byebug.spec SRPM URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-byebug-3.5.1-3.fc.src.rpm Description: Byebug is a Ruby 2 debugger. It's implemented using the Ruby 2 TracePoint C API for execution control and the Debug Inspector C API for call stack navigation. The core component provides support that front-ends can build on. It provides breakpoint handling and bindings for stack frames among other things and it comes with an easy to use command line interface. Fedora Account System Username: mtasaka Copr: http://copr-fe.cloud.fedoraproject.org/coprs/mtasaka/byebug/
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 115 files have unknown license. byebug/1188537-rubygem-byebug/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems, /usr/share/gems/doc [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [x]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Package does not contain Requires: ruby(abi). ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files Note: in the generated docs [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. OK: ruby -e "require 'byebug'; p Byebug::VERSION" [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [x]: Specfile should use macros from rubygem-devel package. [x]: Gem package should exclude cached Gem. [x]: Gem should use %gem_install macro. [x]: Test suite should not be run by rake. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-byebug-3.5.1-3.fc22.x86_64.rpm rubygem-byebug-doc-3.5.1-3.fc22.noarch.rpm rubygem-byebug-3.5.1-3.fc22.src.rpm rubygem-byebug.x86_64: W: spelling-error %description -l en_US breakpoint -> breakpoints, break point, break-point rubygem-byebug.x86_64: E: zero-length /usr/lib64/gems/ruby/byebug-3.5.1/gem.build_complete rubygem-byebug.x86_64: W: no-manual-page-for-binary byebug rubygem-byebug.src: W: spelling-error %description -l en_US breakpoint -> breakpoints, break point, break-point 3 packages and 0 specfiles checked; 1 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- rubygem-byebug (rpmlib, GLIBC filtered): /usr/bin/env /usr/bin/ruby libc.so.6()(64bit) libcrypt.so.1()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libruby.so.2.2()(64bit) rtld(GNU_HASH) ruby(rubygems) rubygem(columnize) rubygem(debugger-linecache) rubygem(slop) rubygem-byebug-doc (rpmlib, GLIBC filtered): rubygem-byebug Provides -------- rubygem-byebug: rubygem(byebug) rubygem-byebug rubygem-byebug(x86-64) rubygem-byebug-doc: rubygem-byebug-doc Unversioned so-files -------------------- rubygem-byebug: /usr/lib64/gems/ruby/byebug-3.5.1/byebug/byebug.so Source checksums ---------------- https://rubygems.org/gems/byebug-3.5.1.gem : CHECKSUM(SHA256) this package : 56358e944d1cdb83151d4400631306eb2539b5fdf1b5e784cdd984b14016ac51 CHECKSUM(SHA256) upstream package : 56358e944d1cdb83151d4400631306eb2539b5fdf1b5e784cdd984b14016ac51 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1188537 -L /home/valtri/fedora2-scm/REVIEWS/rubygem-byebug/RAW Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Ruby, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Built with local dependencies: /home/valtri/fedora2-scm/REVIEWS/rubygem-byebug/RAW/rubygem-debugger-linecache-1.2.0-2.fc22.noarch.rpm ======== The failed tests could be reported upstream (with versions of used dependencies), but that's not a blocker. The simplecov dependency is removable by simple sed on test/test_helper.rb. But I guess it's not worth it? I couldn't find any real issue. :-) Package APPROVED!
Wow, very quick review, thank you, thank you! I will definitely review your package. simplecov dependency does not seem useful so I will try removing. New Package SCM Request ======================= Package Name: rubygem-byebug Short Description: Ruby 2.0 fast debugger - base + CLI Upstream URL: http://github.com/deivid-rodriguez/byebug Owners: mtasaka Branches: f21 InitialCC:
Git done (by process-git-requests).
simplecov BR dependency removed. Built successfully on F-22/21, push request for F-21 on bodhi, closing. Thank you for review and git procedure.