Spec URL: https://anishpatil.fedorapeople.org/nodejs-keygrip.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-keygrip-1.0.1-1.fc21.src.rpm Description: Keygrip is a node.js module for signing and verifying data through a rotating credential system Fedora Account System Username: anishpatil
please add BR: nodejs-packaging and rewrap the description to 80 chars.
Hi Piotr, Thank you for package review, please find updated Spec and SRPM on Spec URL: https://anishpatil.fedorapeople.org/nodejs-keygrip.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-keygrip-1.0.1-2.fc21.src.rpm
Hi Anish, Could you enable the tests? package.json says tests should be executed by: 'node test.js' while the specfile uses mocha
HI Piotr, Thank you for your review comments Please find new Spec and SRPM on Spec URL: https://anishpatil.fedorapeople.org/nodejs-keygrip.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-keygrip-1.0.1-3.fc21
Hi Anish, nodejs packages should symlink the dependencies in the %install section, please see: https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Symlinking_Dependencies Could you update all your nodejs packages to include the %nodejs_symlink macro?
Hi Piotr, Thank you for your review comments, please find new rpms and sprms on Spec URL: https://anishpatil.fedorapeople.org/nodejs-keygrip.spec SRPM URL: https://anishpatil.fedorapeople.org/nodejs-keygrip-1.0.1-3.fc21.src.rpm
- update Source0 to comply with github source guidelines: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github - set correct test as specified in package.json and enable test or explain why they are disabled - please remove trailing space at end of line on line 8 - move LICENSE.txt from %doc to %license https://fedoraproject.org/wiki/Packaging:LicensingGuidelines https://fedorahosted.org/fpc/ticket/411 - please use BuildRequires npm(scmp) instead of nodejs-scmp
anish, any updates on this?
This seems stalled, closing bug in one week. https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
In the interest of moving things along here, and keeping the package review from stalling, I've created my own Spec and SRPMs that I think address all of the concerns raised in this review. Piotr, would you mind continuing the review with my spec/SRPM? Anish, I hope you don't mind me doing this to continue to get this package into Fedora. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-keygrip/nodejs-keygrip.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-keygrip/nodejs-keygrip-1.0.1-1.fc24.src.rpm
Hi Jared, The official process would be that you open a new review request bug and than close this one as duplicate [1]. I will review your new request. Unless Anish still want's to continue? [1] https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding
I think this is safe to close. If you still want to continue with the review, open a new bug and close this as a duplicate.
Jared, if you want to continue with the review, please open a new bug and mark this as duplicate, thank you.
*** This bug has been marked as a duplicate of bug 1495299 ***