Bug 1188648 - Review Request: perl-Palm - Palm OS utility functions
Summary: Review Request: perl-Palm - Palm OS utility functions
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-03 13:27 UTC by Emmanuel Seyman
Modified: 2015-02-10 10:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-10 10:41:37 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2015-02-03 13:27:53 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Palm/perl-Palm.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Palm/perl-Palm-1.014-1.fc21.src.rpm
Description:
This module provides functions and handlers to manipulate files used
by Palm PDAs (AddressBook, ToDo, Memo, ...).

Fedora Account System Username: eseyman
Rpmlint output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Note that this is a re-review for a package rename. The perl-Palm package is a renaming of the perl-p5-Palm one, upstream having decided to do a name-change.

Comment 1 Petr Šabata 2015-02-03 13:45:19 UTC
The standalone spec differs from the one included in the SRPM.

Comment 2 Emmanuel Seyman 2015-02-03 13:54:46 UTC
(In reply to Petr Šabata from comment #1)
> The standalone spec differs from the one included in the SRPM.

Wow, I'm off to a great start on this one. Source RPM rebuilt.

Comment 3 Petr Šabata 2015-02-03 14:46:47 UTC
(In reply to Emmanuel Seyman from comment #2)
> (In reply to Petr Šabata from comment #1)
> > The standalone spec differs from the one included in the SRPM.
> 
> Wow, I'm off to a great start on this one. Source RPM rebuilt.

Indeed.

This is not a simple rename.  The distribution got split into two, at least -- this one and Palm::PDB.  The latter needs to be packaged before this one as it's your (and lbdb's) dependency.

Wrong lettercase on the Obsoletes line.

Mark the LICENSE file with %license; this is now mandatory.

Missing BR: perl

The minimum required version of EU::MM should be 6.76.  That's when support for NO_PACKLIST was introduced.

You can substitute PERL_INSTALL_ROOT with DESTDIR.

The URL still points to p5-Palm.

Comment 4 Emmanuel Seyman 2015-02-03 15:13:53 UTC
(In reply to Petr Šabata from comment #3)
> 
> This is not a simple rename.  The distribution got split into two, at least
> -- this one and Palm::PDB.  The latter needs to be packaged before this one
> as it's your (and lbdb's) dependency.

Yup, perl-Palm-PDB was reviewed in bug #1187873 and hit rawhide on 2015-02-02.

> Wrong lettercase on the Obsoletes line.
> Mark the LICENSE file with %license; this is now mandatory.
> Missing BR: perl
> The minimum required version of EU::MM should be 6.76.  That's when support
> for NO_PACKLIST was introduced.
> You can substitute PERL_INSTALL_ROOT with DESTDIR.
> The URL still points to p5-Palm.

All fixed.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Palm/perl-Palm.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Palm/perl-Palm-1.014-2.fc21.src.rpm

Comment 5 Petr Šabata 2015-02-04 13:33:48 UTC
(In reply to Emmanuel Seyman from comment #4)
> (In reply to Petr Šabata from comment #3)
> > 
> > This is not a simple rename.  The distribution got split into two, at least
> > -- this one and Palm::PDB.  The latter needs to be packaged before this one
> > as it's your (and lbdb's) dependency.
> 
> Yup, perl-Palm-PDB was reviewed in bug #1187873 and hit rawhide on
> 2015-02-02.

I see.  Totally missed that.

> > Wrong lettercase on the Obsoletes line.
> > Mark the LICENSE file with %license; this is now mandatory.
> > Missing BR: perl
> > The minimum required version of EU::MM should be 6.76.  That's when support
> > for NO_PACKLIST was introduced.
> > You can substitute PERL_INSTALL_ROOT with DESTDIR.
> > The URL still points to p5-Palm.
> 
> All fixed.
> 
> Spec URL: http://people.parinux.org/~seyman/fedora/perl-Palm/perl-Palm.spec
> SRPM URL:
> http://people.parinux.org/~seyman/fedora/perl-Palm/perl-Palm-1.014-2.fc21.
> src.rpm

Ack, everything fixed.  Approving.

Comment 6 Emmanuel Seyman 2015-02-04 16:16:41 UTC
(In reply to Petr Šabata from comment #5)
>
> Ack, everything fixed.  Approving.

Thanks, Petr.

New Package SCM Request
=======================
Package Name: perl-Palm
Short Description: Palm OS utility functions
Upstream URL: http://search.cpan.org/dist/Palm/
Owners: eseyman
Branches:
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2015-02-04 19:48:55 UTC
Git done (by process-git-requests).

Comment 8 Emmanuel Seyman 2015-02-10 10:41:37 UTC
Built for rawhide and mashed.


Note You need to log in before you can comment on or make changes to this bug.