RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1189065 - Endian bug in authentication code
Summary: Endian bug in authentication code
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: freeipmi
Version: 7.1
Hardware: Unspecified
OS: Unspecified
high
urgent
Target Milestone: rc
: ---
Assignee: Ales Ledvinka
QA Contact: Rachel Sibley
URL:
Whiteboard:
Depends On: 1022178
Blocks: 993793 1032963 1133060 1154125
TreeView+ depends on / blocked
 
Reported: 2015-02-04 11:32 UTC by Denys Vlasenko
Modified: 2018-12-04 18:01 UTC (History)
11 users (show)

Fixed In Version: freeipmi-1.2.9-7.el7
Doc Type: Bug Fix
Doc Text:
Cause: Code stores name length in specific byte order non-compatible with big-endian. Consequence: The code does not work on big-endian. Fix: Replaced the code storing the length with a portable one. Result: Works on big-endian.
Clone Of: 1022178
Environment:
Last Closed: 2015-11-19 12:48:15 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:2408 0 normal SHIPPED_LIVE freeipmi bug fix update 2015-11-19 11:11:24 UTC

Comment 2 Denys Vlasenko 2015-02-04 11:58:05 UTC
I suspect that just reusing freeipmi-1.2.1-bigendauth.patch from freeipmi-1.2.1-4.el6.src.rpm will work here.

Comment 4 Rachel Sibley 2015-08-19 12:58:57 UTC
ALL TESTS PASSED

After speaking with dev, since this a trivial fix, SanityOnly verification is sufficient.

[rasibley@localhost freeipmi]$ git log --oneline --grep=1189065
3b87ff7 Resolves: #1189065

Verified the fix is in the source code for freeipmi:

commit 3b87ff7ee4686d3ab6d2a8efa13be73d366921cf
Author: Ales Ledvinka <aledvink>
Date:   Mon Jul 6 12:11:20 2015 +0200

    Resolves: #1189065

diff --git a/freeipmi-1.2.1-bigendauth.patch b/freeipmi-1.2.1-bigendauth.patch
new file mode 100644
index 0000000..03db1e8
--- /dev/null
+++ b/freeipmi-1.2.1-bigendauth.patch
@@ -0,0 +1,32 @@
+diff -urpN freeipmi-1.3.2.orig/libfreeipmi/util/ipmi-rmcpplus-util.c freeipmi-1.3.2.fixed/libfreeipmi/util/ipmi-rmcpplus-util.c
+--- freeipmi-1.3.2.orig/libfreeipmi/util/ipmi-rmcpplus-util.c  2013-09-11 01:23:16.000000000 +0200
++++ freeipmi-1.3.2.fixed/libfreeipmi/util/ipmi-rmcpplus-util.c 2013-10-22 17:56:59.439103790 +0200
+@@ -157,15 +157,8 @@ ipmi_calculate_sik (uint8_t authenticati
+     priv_byte |= 0x10;
+   priv_byte |= (requested_privilege_level & 0xF);
+ 
+-  memcpy (hash_data + hash_data_len,
+-          (void *)&priv_byte,
+-          sizeof (uint8_t));
+-  hash_data_len += sizeof (uint8_t);
+-
+-  memcpy (hash_data + hash_data_len,
+-          (void *)&user_name_len,
+-          sizeof (uint8_t));
+-  hash_data_len += sizeof (uint8_t);
++  hash_data[hash_data_len++] = priv_byte;
++  hash_data[hash_data_len++] = user_name_len;
+ 
+   if (user_name && user_name_len > 0)
+     {
+@@ -1257,8 +1250,8 @@ ipmi_rmcpplus_check_rakp_4_integrity_che
+ 
+   rv = memcmp (digest, integrity_check_value, compare_len) ? 0 : 1;
+  cleanup:
+-  secure_memset (buf, '\0', IPMI_MAX_KEY_DATA_LENGTH);
+-  secure_memset (buf, '\0', IPMI_MAX_KEY_EXCHANGE_AUTHENTICATION_CODE_LENGTH);
++  secure_memset (buf, '\0', sizeof(buf));
++  secure_memset (digest, '\0', sizeof(digest));
+   return (rv);
+ }
+

Comment 5 errata-xmlrpc 2015-11-19 12:48:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2408.html


Note You need to log in before you can comment on or make changes to this bug.