Bug 1190142 - New Template dialog to narrow when quota is enabled
Summary: New Template dialog to narrow when quota is enabled
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-3.6.6
: 3.6.6
Assignee: Doron Fediuck
QA Contact: Shira Maximov
URL:
Whiteboard:
Depends On:
Blocks: 1220128
TreeView+ depends on / blocked
 
Reported: 2015-02-06 12:52 UTC by Jiri Belka
Modified: 2016-05-25 12:08 UTC (History)
18 users (show)

Fixed In Version: 3.6.0-9
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1220128 (view as bug list)
Environment:
Last Closed: 2016-05-25 12:08:14 UTC
oVirt Team: SLA
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (34.20 KB, image/png)
2015-02-06 12:52 UTC, Jiri Belka
no flags Details
add template screenshot (194.58 KB, image/png)
2015-10-13 11:25 UTC, Shira Maximov
no flags Details
New Template dialog with Quota enabled (31.75 KB, image/png)
2015-11-09 15:56 UTC, Daniel Erez
no flags Details
Screenshot of the template window before the change (29.35 KB, image/png)
2016-01-05 09:14 UTC, Tomer Saban
no flags Details
Screenshot of the template window before the change (29.35 KB, image/png)
2016-01-05 09:15 UTC, Tomer Saban
no flags Details
Screenshot of the template window after the change (24.14 KB, image/png)
2016-01-05 09:17 UTC, Tomer Saban
no flags Details
video capture (1.01 MB, video/mp4)
2016-02-07 09:47 UTC, Shira Maximov
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1119 0 normal SHIPPED_LIVE Red Hat Enterprise Virtualization Manager (rhevm) bug fix 3.6.6 2016-05-25 16:07:50 UTC
oVirt gerrit 38071 0 master MERGED userportal: Fixed New Template dialog size Never
oVirt gerrit 42723 0 None None None Never
oVirt gerrit 51225 0 master MERGED userportal,webadmin: Fixed New Template dialog size 2016-01-17 14:27:24 UTC
oVirt gerrit 51226 0 ovirt-engine-3.6 MERGED userportal: Fixed New Template dialog size 2016-01-18 16:15:00 UTC
oVirt gerrit 52369 0 ovirt-engine-3.6.2 MERGED userportal: Fixed New Template dialog size 2016-01-18 16:15:57 UTC
oVirt gerrit 54453 0 master MERGED userportal: Fixed New Template dialog size 2016-03-28 11:16:08 UTC
oVirt gerrit 54456 0 ovirt-engine-3.6 MERGED userportal: Fixed New Template dialog size 2016-03-30 09:00:34 UTC

Description Jiri Belka 2015-02-06 12:52:22 UTC
Created attachment 988852 [details]
screenshot

Description of problem:
when quota is enabled then new template dialog is too narrow and there are ugly scrollbars...

see screenshot

Version-Release number of selected component (if applicable):
rhevm-userportal-3.5.0-0.31.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. be logged in Userportal-Extended view (have some admin rights to create template - TemplateCreator)
2. have quota enabled on DC
3. create new template and see dialog

Actual results:
too narrow - ugly

Expected results:
more wide not to see ugly scrollbars

Additional info:
firefox-31.2.0-3.el6_6.x86_64

Comment 2 Eyal Edri 2015-08-13 10:36:47 UTC
moving old bug fixed before ovirt alpha release as fixed in current beta2, 
3.6.0-9.

Comment 3 Shira Maximov 2015-10-13 11:25:15 UTC
Created attachment 1082353 [details]
add template screenshot

Comment 4 Shira Maximov 2015-10-13 11:29:30 UTC
try to verify on: 
Red Hat Enterprise Virtualization Manager Version: 3.6.0-0.18.el6
 
but the window is still too narrow.. 
the print screen is attached above

Comment 5 Sandro Bonazzola 2015-10-26 12:36:02 UTC
this is an automated message. oVirt 3.6.0 RC3 has been released and GA is targeted to next week, Nov 4th 2015.
Please review this bug and if not a blocker, please postpone to a later release.
All bugs not postponed on GA release will be automatically re-targeted to

- 3.6.1 if severity >= high
- 4.0 if severity < high

Comment 6 Shira Maximov 2015-11-05 15:20:30 UTC
try to verify again on :
Red Hat Enterprise Virtualization Manager Version: 3.6.0.3-0.1.el6

but the window is still too narrow..

Comment 7 Daniel Erez 2015-11-09 15:53:13 UTC
(In reply to Shira Maximov from comment #6)
> try to verify again on :
> Red Hat Enterprise Virtualization Manager Version: 3.6.0.3-0.1.el6
> 
> but the window is still too narrow..

Sorry, moved to MODIFIED too early.
@Shira - can you please upload a screenshot of the issue on latest 3.6 build?
(attached is a screenshot of new template dialog in 3.6 in which it looks OK).

Comment 8 Daniel Erez 2015-11-09 15:56:10 UTC
Created attachment 1091820 [details]
New Template dialog with Quota enabled

Comment 9 Roy Golan 2015-11-11 14:56:33 UTC
looks solved on 3.6

Comment 10 Red Hat Bugzilla Rules Engine 2015-11-16 14:11:20 UTC
This bug is flagged for 3.6, yet the milestone is for 4.0 version, therefore the milestone has been reset.
Please set the correct milestone or add the flag.

Comment 11 Yaniv Lavi 2015-11-16 14:13:33 UTC
What is the status of this bug?

Comment 12 Red Hat Bugzilla Rules Engine 2015-11-16 14:13:36 UTC
Fixed bug tickets must have target milestone set prior to fixing them. Please set the correct milestone and move the bugs back to the previous status after this is corrected.

Comment 13 Red Hat Bugzilla Rules Engine 2015-11-17 13:43:45 UTC
Fixed bug tickets must have version flags set prior to fixing them. Please set the correct version flags and move the bugs back to the previous status after this is corrected.

Comment 14 Shira Maximov 2015-11-24 12:12:53 UTC
i tried to verify the bug again on latest version 3.6.0-20 and the bug still exists. 
(the window is still too narrow) 

version : 
Red Hat Enterprise Virtualization Manager Version: 3.6.0.3-0.1.el6

Comment 15 Tomer Saban 2015-11-24 12:33:27 UTC
This bug failed QA on 3.6 branch because the changes were overwritten by another patch with commit-hash: 284dd001

Git web link:
https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=284dd001bb751951981df1c9815720049c6f16ba

Comment 16 Tomer Saban 2016-01-05 09:14:20 UTC
Created attachment 1111765 [details]
Screenshot of the template window before the change

That is intended for derez following his comment in the patch:https://gerrit.ovirt.org/#/c/51225/

Comment 17 Tomer Saban 2016-01-05 09:15:31 UTC
Created attachment 1111767 [details]
Screenshot of the template window before the change

Comment 18 Tomer Saban 2016-01-05 09:17:37 UTC
Created attachment 1111768 [details]
Screenshot of the template window after the change

Comment 19 Doron Fediuck 2016-01-10 08:45:09 UTC
Daniel,
see relevant screenshots in comment 16 and after.

Comment 20 Daniel Erez 2016-01-10 08:55:30 UTC
(In reply to Doron Fediuck from comment #19)
> Daniel,
> see relevant screenshots in comment 16 and after.

Already discussed with Tomer. The concern was about the disks panel which should be enlarged as well to properly accommodate the new size of the dialog.

@Tomer - can you please upload the new patch set with the proper change (and verify both in UserPortal and WebAdmin).

Comment 22 Eyal Edri 2016-01-27 13:11:20 UTC
its in the last build, it didn't move to ON_QA since the bug wasn't on modified at the build time.

Comment 23 Shira Maximov 2016-01-28 16:03:11 UTC
tried to verify on :  Red Hat Enterprise Virtualization Manager Version: 3.6.3-0.1.el6 

The verification failed.. 
verification steps:
1. be logged in Userportal-Extended view (have some admin rights to create template - TemplateCreator)
2. have quota enabled on DC
3. create new template and see dialog - the dialog is fine. but when i mark  "Create as a Template Sub Version" the ugly scroll-bars appears.

Tomer, should i move it back to assign?

Comment 24 Tomer Saban 2016-02-04 12:41:36 UTC
Daniel Erez, said it sounds like an infrastructure problem. So I think that as long as the frame seems OK (I also checked it with disks). Then, it should be marked verify.

Daniel, What do you think?

Comment 25 Daniel Erez 2016-02-04 12:44:46 UTC
(In reply to Tomer Saban from comment #24)
> Daniel Erez, said it sounds like an infrastructure problem. So I think that
> as long as the frame seems OK (I also checked it with disks). Then, it
> should be marked verify.
> 
> Daniel, What do you think?

Not sure. Need to see a screenshot, or preferably a video capture.

Comment 26 Tomer Saban 2016-02-04 12:56:21 UTC
Shira, Can you please produce a screenshot for derez

Comment 27 Shira Maximov 2016-02-07 09:47:55 UTC
Created attachment 1121864 [details]
video capture

Comment 28 Daniel Erez 2016-02-07 10:32:50 UTC
(In reply to Shira Maximov from comment #27)
> Created attachment 1121864 [details]
> video capture

Seems like the dialog is a bit too small to accommodate the 'Create as a Template Sub Version' widgets.

@Tomas - should we simply enlarge the height of 'New Template' dialog?

Comment 29 Shira Maximov 2016-02-11 08:10:58 UTC
move the bug back to assigned after I spoke with rgolan.

Comment 30 Tomas Jelinek 2016-02-11 08:25:43 UTC
@Daniel: yes, I think it would be enough.

Comment 31 Mike McCune 2016-03-28 23:40:50 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 33 Shira Maximov 2016-05-05 10:42:43 UTC
verified on :
Red Hat Enterprise Virtualization Manager Version: 3.6.6-0.1.el6


verification steps:
1. logged in Userportal-Extended view (have some admin rights to create template - TemplateCreator)
2. have quota enabled on DC
3. create new template and see dialog - the dialog is fine.

Comment 35 errata-xmlrpc 2016-05-25 12:08:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1119.html


Note You need to log in before you can comment on or make changes to this bug.