Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1190224 - Incorrect error message on docker repository creation
Summary: Incorrect error message on docker repository creation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Hammer
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: David Davis
QA Contact: sthirugn@redhat.com
URL:
Whiteboard:
Depends On:
Blocks: 1190289
TreeView+ depends on / blocked
 
Reported: 2015-02-06 17:16 UTC by sthirugn@redhat.com
Modified: 2017-02-23 20:34 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-12 05:23:53 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:1592 0 normal SHIPPED_LIVE Important: Red Hat Satellite 6.1.1 on RHEL 6 2015-08-12 09:04:35 UTC

Description sthirugn@redhat.com 2015-02-06 17:16:03 UTC 
Description of problem:
Incorrect error message on docker repository creation

Version-Release number of selected component (if applicable):
Version: Satellite-6.1.0-RHEL-7-20150205.0

How reproducible:
Always

Steps to Reproduce:
hammer> repository create --name='dockerrepo4' --content-type='docker' --url='https://registry.hub.docker.com' --product='testproduct3' --organization-id=1
Could not create the repository:
  Validation failed: Repository URL and Upstream Name cannot be empty. Both are required for syncing from the upstream.


Actual results:
As shown above

Expected results:
Could not create the repository:
  Validation failed: Upstream Name cannot be empty.

Additional info:
Comment 2 David Davis 2015-02-11 17:23:55 UTC 
This is the intended behavior I believe. To create a docker repo you must supply either both the upstream name and url:

h repository create --name='dockerrepo4' --content-type='docker' --url='https://registry.hub.docker.com' --product='testproduct3' --organization-id=1 --docker-upstream-name=centos

Or neither:

h repository create --name='dockerrepo4' --content-type='docker' -product='testproduct3' --organization-id=1
Comment 3 sthirugn@redhat.com 2015-02-11 17:30:25 UTC 
I expected a more smarter error message for usability:

Current error message for the scenario I mentioned in the bug is:
"Could not create the repository:
  Validation failed: Repository URL and Upstream Name cannot be empty. Both are required for syncing from the upstream."

Note that I already provided Repository URL.  So I expected error message to be something like:
"Could not create the repository:
  Validation failed: Upstream Name cannot be empty when Repository URL is provided. Both are required for syncing from the upstream."
Comment 4 David Davis 2015-02-18 20:37:19 UTC 
Talked with sthirugn. The latest compose should say this:

"Validation failed: Docker upstream name cannot be blank. Either provide all or no sync information. Repository URL or Upstream Name is empty. Both are required for syncing from the upstream."
Comment 5 David Davis 2015-02-18 20:38:38 UTC 
FYI, it was added here:

https://github.com/Katello/katello/pull/4978/files#diff-7bfb4ceeca67af50fe464d5451281e40R497
Comment 6 sthirugn@redhat.com 2015-02-18 20:54:21 UTC 
Verified.

Version Tested:
Satellite-6.1.0-RHEL-6-20150217.0

hammer> repository create --name='dockerrepo1' --content-type='docker' --product='testproduct1' --organization-id=1 --docker-upstream-name='fedora/ssh'
Could not create the repository:
  Validation failed: Url cannot be blank. Either provide all or no sync information., Repository URL or Upstream Name is empty. Both are required for syncing from the upstream.



hammer> repository create --name='dockerrepo4' --content-type='docker' --url='https://registry.hub.docker.com' --product='testproduct1' --organization-id=1
Could not create the repository:
  Validation failed: Docker upstream name cannot be blank. Either provide all or no sync information., Repository URL or Upstream Name is empty. Both are required for syncing from the upstream.
Comment 7 Bryan Kearney 2015-08-11 13:30:16 UTC 
This bug is slated to be released with Satellite 6.1.
Comment 8 errata-xmlrpc 2015-08-12 05:23:53 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:1592
Note You need to log in before you can comment on or make changes to this bug.