Bug 1190361 - Review Request: clutter-gst3 - GStreamer integration library for Clutter
Summary: Review Request: clutter-gst3 - GStreamer integration library for Clutter
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1194995 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-07 15:03 UTC by David King
Modified: 2015-03-05 12:35 UTC (History)
2 users (show)

Fixed In Version: clutter-gst3-3.0.4-1.fc21
Clone Of:
Environment:
Last Closed: 2015-03-05 12:35:11 UTC
Type: ---
Embargoed:
kalevlember: fedora-review+
puiterwijk: fedora-cvs+


Attachments (Terms of Use)

Description David King 2015-02-07 15:03:58 UTC
Spec URL: https://amigadave.fedorapeople.org/clutter-gst3.spec
SRPM URL: https://amigadave.fedorapeople.org/clutter-gst3-3.0.4-1.fc22.src.rpm
Description: Clutter is an open source software library for creating fast, visually rich and animated graphical user interfaces. Clutter GStreamer enables the use of GStreamer with Clutter.
Fedora Account System Username: amigadave

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8858398
Required for newer builds of Totem and (in the next release) Cheese.

Comment 1 David King 2015-02-22 00:08:52 UTC
*** Bug 1194995 has been marked as a duplicate of this bug. ***

Comment 2 Kalev Lember 2015-02-22 14:33:14 UTC
$ rpmlint clutter-gst3-3.0.4-1.fc22.src.rpm \
          clutter-gst3 \
          clutter-gst3-debuginfo \
          clutter-gst3-devel
clutter-gst3.src: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
clutter-gst3.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 4)
clutter-gst3.x86_64: W: spelling-error Summary(en_US) GStreamer -> G Streamer, Streamer, Steamer
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libcogl-path.so.20
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libatk-1.0.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libcogl-pango.so.20
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libjson-glib-1.0.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libgdk-3.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libpangocairo-1.0.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libpango-1.0.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libcairo-gobject.so.2
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libcairo.so.2
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libwayland-cursor.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libxkbcommon.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libXi.so.6
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libgmodule-2.0.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libwayland-egl.so.1
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libwayland-client.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libgbm.so.1
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libdrm.so.2
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libwayland-server.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libEGL.so.1
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libXext.so.6
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libXdamage.so.1
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libXfixes.so.3
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libXcomposite.so.1
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libXrandr.so.2
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libgstbase-1.0.so.0
clutter-gst3.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libclutter-gst-3.0.so.0.4.0 /lib64/libpthread.so.0
clutter-gst3-devel.x86_64: W: spelling-error %description -l en_US gst -> gs, gt, st
clutter-gst3-devel.x86_64: W: only-non-binary-in-usr-lib
4 packages and 0 specfiles checked; 0 errors, 31 warnings.

Would be nice to fix up the mixed-use-of-spaces-and-tabs warning to reduce the rpmlint spew a little bit.

Comment 3 Kalev Lember 2015-02-22 14:34:49 UTC
Fedora review clutter-gst3-3.0.4-1.fc22.src.rpm 2015-02-22

+ OK
! needs attention

+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (COPYING) is included in %license 
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
  0b4283e6ccf5ee5d9f5fb635230fc714  clutter-gst-3.0.4.tar.xz
  0b4283e6ccf5ee5d9f5fb635230fc714  Download/clutter-gst-3.0.4.tar.xz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
+ ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8

Looks good to me.

APPROVED

Comment 4 David King 2015-02-22 14:38:19 UTC
Thanks for the quick review! I fixed the tabs-vs-spaces warning in-place.

Comment 5 David King 2015-02-22 14:40:51 UTC
New Package SCM Request
=======================
Package Name: clutter-gst3
Short Description: GStreamer integration library for Clutter
Upstream URL: https://developer.gnome.org/clutter-gst/stable/
Owners: amigadave
Branches: f21 f22
InitialCC:

Comment 6 Kalev Lember 2015-02-22 16:17:29 UTC
Shouldn't it be F22+ ? Nothing in GNOME 3.14 that's in F21 used clutter-gst 3.0.

Comment 7 David King 2015-02-23 08:27:37 UTC
I don't see why it shouldn't be packaged for F21, especially as F22 won't be out for quite a while still. As a developer, it would be nice to play with this on the stable branch (and it should not impact other packages, as nothing depends on it).

Comment 8 Patrick Uiterwijk 2015-02-24 09:29:29 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2015-02-24 11:16:12 UTC
clutter-gst3-3.0.4-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/clutter-gst3-3.0.4-1.fc21

Comment 10 Fedora Update System 2015-02-25 13:27:03 UTC
clutter-gst3-3.0.4-1.fc21 has been pushed to the Fedora 21 testing repository.

Comment 11 Fedora Update System 2015-03-05 12:35:11 UTC
clutter-gst3-3.0.4-1.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.