Spec URL: http://www.zkusebnidomena.czweb.org/rpms/forbiddenapis/forbiddenapis.spec SRPM URL: http://www.zkusebnidomena.czweb.org/rpms/forbiddenapis/forbiddenapis-1.7-1.fc22.src.rpm Description: Project which implemnts Ant task. It checks Java byte code against a list of "forbidden" API signatures. It is optional build dependency of elasticsearch.
I'm taking this one.
As an initial comment it's always good to match upstream name as closely as possible - so renaming from forbiddenapis to forbidden-apis would make it easier for people following upstrame name to find the fedora package. Detailed review to follow when this one is fixed.
Here reneamed: Spec URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis.spec SRPM URL: www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis-1.7-1.fc22.src.rpm
Spec URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis.spec SRPM URL: www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis-1.7-1.fc22.src.rpm
One more comment to make srpm actual url: Spec URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis.spec SRPM URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/forbidden-apis-1.7-1.fc22.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/akurtakov/tmp/1190728-forbidden- apis/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/java/forbidden-apis, /usr/share/maven- poms/forbidden-apis [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/maven-poms/forbidden- apis, /usr/share/java/forbidden-apis [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. Note: Test run failed [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [x]: Packages must not store files under /srv, /opt or /usr/local Note: Test run failed [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. Java: [x]: Bundled jar/class files should be removed before build Note: Test run failed [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in forbidden- apis-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Test run failed [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: forbidden-apis-1.7-1.fc21.noarch.rpm forbidden-apis-javadoc-1.7-1.fc21.noarch.rpm forbidden-apis-1.7-1.fc21.src.rpm forbidden-apis.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/forbidden-apis/README.txt forbidden-apis.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/forbidden-apis/NOTICE.txt forbidden-apis.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/forbidden-apis/LICENSE.txt forbidden-apis-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/forbidden-apis-javadoc/NOTICE.txt forbidden-apis-javadoc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/forbidden-apis-javadoc/LICENSE.txt 3 packages and 0 specfiles checked; 0 errors, 5 warnings. TODO: * Fix wrong-file-end-of-line-encoding * Not a blocker just FYI but please report to upstream that forbiddenapis-1.7/src/main/java/de/thetaphi/forbiddenapis/CheckMojo.java forbiddenapis-1.7/src/main/java/de/thetaphi/forbiddenapis/TestCheckMojo.java forbiddenapis-1.7/src/tools/java/de/thetaphi/forbiddenapis/DeprecatedGen.java don't have license as the very first thing in the files.
Please when requesting for repo, request both f22 and rawhide.
Spec URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/v2/forbidden-apis.spec SRPM URL: http://www.zkusebnidomena.czweb.org/rpms/forbidden-apis/v2/forbidden-apis-1.7-1.fc23.src.rpm
Thanks, THIS PACKAGE IS APPROVED.
Sponsored now. Please request scm.
New Package SCM Request ======================= Package Name: forbidden-apis Short Description: Checks Java byte code against a list of "forbidden" API signatures. Upstream URL: https://code.google.com/p/forbidden-apis/ Owners: zzambers jvanek Branches: f22 InitialCC:
Git done (by process-git-requests).