Bug 1191042 - Review Request: perl-MouseX-App-Cmd - Mashes up MouseX::Getopt and App::Cmd
Summary: Review Request: perl-MouseX-App-Cmd - Mashes up MouseX::Getopt and App::Cmd
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-10 10:52 UTC by Emmanuel Seyman
Modified: 2015-02-24 10:13 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-02-24 10:13:53 UTC
Type: ---
Embargoed:
psabata: fedora-review+
puiterwijk: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2015-02-10 10:52:52 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-MouseX-App-Cmd/perl-MouseX-App-Cmd.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-MouseX-App-Cmd/perl-MouseX-App-Cmd-0.30-1.fc21.src.rpm
Description:
This module marries App::Cmd with MouseX::Getopt.

Fedora Account System Username: eseyman
Rpmlint output: 
perl-MouseX-App-Cmd.src: W: spelling-error Summary(en_US) Getopt -> Get opt, Get-opt, Treetop
perl-MouseX-App-Cmd.src: W: spelling-error %description -l en_US Getopt -> Get opt, Get-opt, Treetop
1 packages and 1 specfiles checked; 0 errors, 2 warnings.

MouseX-App-Cmd was split off in its own distribution in version 0.30 of MooseX-App-Cmd. Before updating to that version, I'ld like to add this package so that Fedora installations do not stop working.

Comment 1 Petr Šabata 2015-02-10 14:29:37 UTC
Missing BRs:
- base, t/build_emulates_new.t:10
- English, lib/MouseX/App/Cmd.pm:5
- File::Basename, lib/MouseX/App/Cmd.pm:6
- lib, t/basic.t:8, t/configfile.t:19, t/moose.t:11
- MouseX::Getopt, t/moose.t:7
- strict, Makefile.PL:3
- warnings, Makefile.PL:4

Many missing dependencies from the resulting binary RPM.  This is mostly from Moose-like keywords.

- App::Cmd (0.321+, as mandated by META files)
- App::Cmd::Command
- Mouse::Object
- MouseX::Getopt

Explicitly require Getopt::Long::Descriptive 0.091+ and filter out the underspecified autogenerated dependency.

Comment 2 Emmanuel Seyman 2015-02-23 16:55:03 UTC
Sorry about the delay,I got distracted by other stuff.

(In reply to Petr Šabata from comment #1)
>
> Missing BRs:

Fixed.

> Many missing dependencies from the resulting binary RPM.  This is mostly
> from Moose-like keywords.

Added.

> Explicitly require Getopt::Long::Descriptive 0.091+ and filter out the
> underspecified autogenerated dependency.

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-MouseX-App-Cmd/perl-MouseX-App-Cmd.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-MouseX-App-Cmd/perl-MouseX-App-Cmd-0.30-2.fc21.src.rpm

Comment 3 Petr Šabata 2015-02-23 17:27:07 UTC
Indeed, all fixed.  Approving.

Comment 4 Emmanuel Seyman 2015-02-23 22:20:30 UTC
Thanks, Petr.

New Package SCM Request
=======================
Package Name: Review Request: perl-MouseX-App-Cmd
Short Description: Mashes up MouseX::Getopt and App::Cmd
Upstream URL: http://search.cpan.org/dist/MouseX-App-Cmd/
Owners: eseyman
Branches:
InitialCC: perl-sig

Comment 5 Patrick Uiterwijk 2015-02-24 09:33:12 UTC
Git done (by process-git-requests).

Comment 6 Emmanuel Seyman 2015-02-24 10:13:53 UTC
Built for rawhide. I'll update perl-MooseX-App-Cmd to 0.30 tomorrow.


Note You need to log in before you can comment on or make changes to this bug.