Bug 11911 - setgid directory mode lost with 2.0.7
setgid directory mode lost with 2.0.7
Status: CLOSED RAWHIDE
Product: Red Hat Raw Hide
Classification: Retired
Component: samba (Show other bugs)
1.0
All Linux
high Severity medium
: ---
: ---
Assigned To: Trond Eivind Glomsrxd
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2000-06-05 03:56 EDT by Michael Tokarev
Modified: 2008-05-01 11:37 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2000-06-05 05:11:07 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
patch that removes last (2.0.7) changes around mkdir() call (420 bytes, patch)
2000-06-05 04:07 EDT, Michael Tokarev
no flags Details | Diff
patch that removes last (2.0.7) changes around mkdir() call (420 bytes, patch)
2000-06-05 04:08 EDT, Michael Tokarev
no flags Details | Diff
patch for .spec file to use previous patch -- oops, forget to add changelog entry:) (490 bytes, patch)
2000-06-05 05:00 EDT, Michael Tokarev
no flags Details | Diff
patch for .spec file to use previous patch -- oops, forget to add changelog entry:) (490 bytes, patch)
2000-06-05 05:04 EDT, Michael Tokarev
no flags Details | Diff
patch for .spec file to use previous patch -- oops, forget to add changelog entry:) (490 bytes, patch)
2000-06-05 05:08 EDT, Michael Tokarev
no flags Details | Diff
patch for .spec file to use previous patch -- oops, forget to add changelog entry:) (490 bytes, patch)
2000-06-05 05:08 EDT, Michael Tokarev
no flags Details | Diff

  None (edit)
Description Michael Tokarev 2000-06-05 03:56:16 EDT
With 2.0.7, the standard unix setgid mode behavor
was lost.  Samba does mkdir() and chmod(), while all
previous versions uses mkdir() only:

/*******************************************************************
 Mkdir() that calls dos_to_unix.
 Cope with UNIXes that don't allow high order mode bits on mkdir.
 Patch from gcarter@lanier.com.
********************************************************************/

int dos_mkdir(char *dname,mode_t mode)
{
  int ret = mkdir(dos_to_unix(dname,False),mode);
  if(!ret)                               <<<<
    return(dos_chmod(dname,mode));       <<<<
  else                                   <<<<
    return ret;
}

Should remove marked lines from lib/doscalls.c.

I know about "inherit permissions" -- this is a dangerous
parameter.
Comment 1 Michael Tokarev 2000-06-05 04:07:55 EDT
Created attachment 298 [details]
patch that removes last (2.0.7) changes around mkdir() call
Comment 2 Michael Tokarev 2000-06-05 04:08:01 EDT
Created attachment 299 [details]
patch that removes last (2.0.7) changes around mkdir() call
Comment 3 Michael Tokarev 2000-06-05 05:00:50 EDT
Created attachment 300 [details]
patch for .spec file to use previous patch -- oops, forget to add changelog entry:)
Comment 4 Michael Tokarev 2000-06-05 05:04:11 EDT
Created attachment 301 [details]
patch for .spec file to use previous patch -- oops, forget to add changelog entry:)
Comment 5 Michael Tokarev 2000-06-05 05:08:14 EDT
Created attachment 302 [details]
patch for .spec file to use previous patch -- oops, forget to add changelog entry:)
Comment 6 Michael Tokarev 2000-06-05 05:08:43 EDT
Created attachment 303 [details]
patch for .spec file to use previous patch -- oops, forget to add changelog entry:)
Comment 7 Michael Tokarev 2000-06-05 05:10:41 EDT
Wow!  Bugzilla seemed to be broken today :)
When I press "attach file" button, it times out.
So I pressed this button more times, and we see a funny result.
Use the first and last patches please :)
Comment 8 Bill Nottingham 2001-01-18 19:45:30 EST
Added in 2.0.7-24. Apologies for the delay.

Note You need to log in before you can comment on or make changes to this bug.