Bug 1191158 - [Admin Portal] Upgrade/Install Host dialog too narrow, can't fully display current version
Summary: [Admin Portal] Upgrade/Install Host dialog too narrow, can't fully display cu...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ovirt-3.6.0-rc
: 3.6.0
Assignee: Alexander Wels
QA Contact: Jiri Belka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-10 15:02 UTC by Jiri Belka
Modified: 2016-04-20 01:28 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-20 01:28:06 UTC
oVirt Team: Infra
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot (56.38 KB, image/png)
2015-02-10 15:02 UTC, Jiri Belka
no flags Details
screenshot after fix (33.86 KB, image/png)
2015-11-04 16:19 UTC, Jiri Belka
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 46016 0 master MERGED webadmin: host install current version Never
oVirt gerrit 46322 0 ovirt-engine-3.6 MERGED webadmin: host install current version Never

Description Jiri Belka 2015-02-10 15:02:13 UTC
Created attachment 990119 [details]
screenshot

Description of problem:
Upgrade/Install Host dialog too narrow, can't fully display current version

see screenshot

Version-Release number of selected component (if applicable):
rhevm-webadmin-portal-3.5.0-0.31.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. see dialog, have same rhevh (host) and rpm (on engine) installed
2.
3.

Actual results:
too narrow dialog, can't see fully current version in the dialog

Expected results:
should be fully displayed

Additional info:

Comment 1 Einav Cohen 2015-02-11 16:25:40 UTC
need to apply something like the "text-overflow: ellipsis" to the 'Current Version' value label, and make sure that a tool-tip containing the full string is displayed upon hovering on the label, in case it is displayed only partially.

Comment 2 Einav Cohen 2015-02-11 16:28:38 UTC
while at it, worth adding a little vertical space between the 'SSH Publickey' radio button + text-box and the 'Current Version' field - right now, their values are too close together, I initially thought (wrongfully) that the 'Current Version' value is just an overflowing continuance of the 'SSH Publickey' value.

Comment 3 Alexander Wels 2015-09-10 14:30:30 UTC
Since the value is an input box like in all the general sub tabs, I won't be able to add the ellipsis part unless bz1205309 is solved as well. I increases the width and height of the popup a little as well as giving the field more room to display the value. This may or may not be enough space.

Comment 4 Einav Cohen 2015-09-15 18:32:31 UTC
(In reply to Alexander Wels from comment #3)
> Since the value is an input box like in all the general sub tabs, I won't be
> able to add the ellipsis part unless bz1205309 is solved as well. I
> increases the width and height of the popup a little as well as giving the
> field more room to display the value. This may or may not be enough space.

in Bug 1205309 we want to introduce tool-tips for cropped texts but not ellipsis, because we want the user to be able to highlight the text in order to e.g. copy/paste it and we don't want en ellipsis ("...") to be part of the highlighted value. 
I believe that this is the same situation here (I assume that we want the user to be able to highlight the "Current Version" value for e.g. copy/paste purposes), so I take back what I wrote in Comment #1 - I don't think that an ellipsis makes sense here - for now, a tool-tip should be enough.

Comment 5 Jiri Belka 2015-11-04 16:19:14 UTC
ok, rhevm-webadmin-portal-3.6.0.2-0.1.el6.noarch

Comment 6 Jiri Belka 2015-11-04 16:19:46 UTC
Created attachment 1089755 [details]
screenshot after fix


Note You need to log in before you can comment on or make changes to this bug.