Bug 1191161 - gstreamer1-vaapi FTBS on s390
Summary: gstreamer1-vaapi FTBS on s390
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gstreamer1-vaapi
Version: 23
Hardware: s390
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Jakub Čajka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ZedoraTracker
TreeView+ depends on / blocked
 
Reported: 2015-02-10 15:07 UTC by Jakub Čajka
Modified: 2015-08-04 05:24 UTC (History)
4 users (show)

Fixed In Version: gstreamer1-vaapi-0.5.10-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-04 05:24:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Bugzilla 744559 0 None None None Never

Description Jakub Čajka 2015-02-10 15:07:00 UTC
Package fails to build for (f21, f22) on s390 with:
.
.
.
  CC       libgstvaapi_1.4_la-gstvaapiobject.lo
  CC       libgstvaapi_1.4_la-gstvaapiparser_frame.lo
  CC       libgstvaapi_1.4_la-gstvaapipixmap.lo
  CC       libgstvaapi_1.4_la-gstvaapiprofile.lo
  CC       libgstvaapi_1.4_la-gstvaapisubpicture.lo
  CC       libgstvaapi_1.4_la-gstvaapisurface.lo
  CC       libgstvaapi_1.4_la-gstvaapisurface_drm.lo
  CC       libgstvaapi_1.4_la-gstvaapisurfacepool.lo
  CC       libgstvaapi_1.4_la-gstvaapisurfaceproxy.lo
  CC       libgstvaapi_1.4_la-gstvaapitexture.lo
  CC       libgstvaapi_1.4_la-gstvaapiutils.lo
  CC       libgstvaapi_1.4_la-gstvaapiutils_core.lo
  CC       libgstvaapi_1.4_la-gstvaapiutils_h264.lo
  CC       libgstvaapi_1.4_la-gstvaapiutils_mpeg2.lo
  CC       libgstvaapi_1.4_la-gstvaapivalue.lo
  CC       libgstvaapi_1.4_la-gstvaapivideopool.lo
  CC       libgstvaapi_1.4_la-gstvaapiwindow.lo
  CC       libgstvaapi_1.4_la-video-format.lo
  CC       libgstvaapi_1.4_la-gstvaapidecoder_jpeg.lo
gstvaapiwindow.c:78:1: error: conflicting types for 'gst_vaapi_window_new_internal'
 gst_vaapi_window_new_internal (const GstVaapiWindowClass * window_class,
 ^
In file included from gstvaapiwindow.c:32:0:
gstvaapiwindow_priv.h:113:1: note: previous declaration of 'gst_vaapi_window_new_internal' was here
 gst_vaapi_window_new_internal (const GstVaapiWindowClass * window_class,
 ^
Makefile:1407: recipe for target 'libgstvaapi_1.4_la-gstvaapiwindow.lo' failed
make[5]: *** [libgstvaapi_1.4_la-gstvaapiwindow.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
.
.
.

failing koji builds:

http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1729453
http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1727088

It seems that function is declared with incompatible type(on s390 types are incompatible). Implementation declaration(gstvaapiwindow.c) should probably match the function prototype (gstvaapiwindow_priv.h). 
Changing in gstvaapiwindow.c:

GstVaapiWindow *
gst_vaapi_window_new_internal (const GstVaapiWindowClass * window_class,
    GstVaapiDisplay * display, GstVaapiID id, guint width, guint height)
 
to: 

GstVaapiWindow *
gst_vaapi_window_new_internal (const GstVaapiWindowClass * window_class,
    GstVaapiDisplay * display, GstVaapiID id, guint width, guint height)

makes build pass on s390(and seems to build fine on all other archs too).

Could you please check this and/or forward it to upstream.

Thanks!
  
Jakub

Comment 1 Simon Farnsworth 2015-02-15 15:29:43 UTC
Upstream bug at https://bugzilla.gnome.org/show_bug.cgi?id=744559

I'm testing that my patched SRPM builds on x86_64, then I'll commit for Rawhide. Once upstream have accepted the patch or fixed it differently, I'll apply the fix to all active branches.

Comment 2 Simon Farnsworth 2015-02-15 15:59:12 UTC
Rawhide build at http://koji.fedoraproject.org/koji/taskinfo?taskID=8939012 - hopefully, the s390x secondary arch processes will pick this up automatically.

Once upstream respond to the bug report, I'll backport the patch as needed for older branches.

Comment 3 Simon Farnsworth 2015-02-17 20:51:40 UTC
I believe that 0.5.10-2 will fix this for you - build task at http://koji.fedoraproject.org/koji/taskinfo?taskID=8971336

Comment 4 Dan Horák 2015-03-13 08:58:13 UTC
Simon, please push the new builds to updates, otherwise we can't get them on secondary arches. All fixes for secondary arches must go through bodhi.

Comment 5 Simon Farnsworth 2015-03-13 10:01:57 UTC
Dan,

Can someone first test the build on s390x, to confirm that I've actually fixed the problem?

Neither koji nor fedpkg have documented options to let me do a scratch build on s390x, and both a Google Search and a fedoraproject.org Wiki search have failed to turn up instructions on building on a secondary arch.

Comment 6 Dan Horák 2015-03-13 10:09:15 UTC
yes, it is fixed now - http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1751903

The procedure for submitting scratch builds is documented eg. at
https://fedoraproject.org/wiki/Architectures/s390x#Submitting_builds

generally ${arch}-koji wrapper exists for all secondary arches, where arch is arm, ppc, s390

Comment 7 Fedora Update System 2015-03-13 10:18:12 UTC
gstreamer1-vaapi-0.5.10-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/gstreamer1-vaapi-0.5.10-2.fc21

Comment 8 Fedora Update System 2015-03-14 09:19:31 UTC
Package gstreamer1-vaapi-0.5.10-2.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gstreamer1-vaapi-0.5.10-2.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-3878/gstreamer1-vaapi-0.5.10-2.fc21
then log in and leave karma (feedback).

Comment 9 Jan Kurik 2015-07-15 14:34:48 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 10 Fedora Update System 2015-08-04 05:24:22 UTC
gstreamer1-vaapi-0.5.10-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.