Spec URL: http://ralph.fedorapeople.org//python-re2.spec SRPM URL: http://ralph.fedorapeople.org//python-re2-0.2.20-1.fc21.src.rpm Description: python-re2 is a Python extension that wraps Google's RE2 regular expression library. This version of python-re2 is similar to the one you'd find at facebook's github repository except that the stated goal of this version is to be a drop-in replacement for the stdlib re module.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8904545
Just FYI: https://github.com/axiak/pyre2/issues/12 Something that might be worth considering to include: https://github.com/axiak/pyre2/pull/22 As for the review: * License is clean and compatible ! setup.py does not list python 2.7 ? Should we consider calling the package python2-re2 (as py3 is now around the corner)? * Spec is clean and understandable ? Why are the tests not running? ! You can consider drop the declaration of python2_sitelib since it's not used anywhere ! Beware that the last commit from upstream is from August 2013 * Builds fine on all arches on rawhide ! Fails to build locally from your src.rpm on F21: http://fpaste.org/184571/73139114/ (rpaths error) * sha512 src.rpm: b68c377df136c6d71f50f4dde1b6c0e3793838226d165dfd4c71760d12ca8c09fac37e0718903ff5fe4ff4ef3fc69126891cf819ecc7f6d7e26214f3076d0b74 ../SOURCES/re2-0.2.20.tar.gz * sha512 upstream: b68c377df136c6d71f50f4dde1b6c0e3793838226d165dfd4c71760d12ca8c09fac37e0718903ff5fe4ff4ef3fc69126891cf819ecc7f6d7e26214f3076d0b74 re2-0.2.20.tar.gz ! rpmlint (using the RPMs from koji): $ rpmlint python-re2-* python-re2.src: W: spelling-error %description -l en_US facebook's -> Facebook's, face book's, face-book's python-re2.src: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish python-re2.src: W: spelling-error %description -l en_US stdlib -> std lib, std-lib, stolid python-re2.x86_64: W: spelling-error %description -l en_US facebook's -> Facebook's, face book's, face-book's python-re2.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish python-re2.x86_64: W: spelling-error %description -l en_US stdlib -> std lib, std-lib, stolid python-re2.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/python2.7/site-packages/re2.so ['/usr/lib'] 3 packages and 0 specfiles checked; 1 errors, 6 warnings. That last error about rpath is annoying. I would like to get the build fixed on F21 and rpmlint cleared before approving this package.
In response to review items: - I think the setup.py trove classifiers are just outdated. It works fine for all use-cases I've tried on python-2.7 here. - The python packaging guidelines don't mention anything about naming packages python2-NAME yet, so I'd hold off until we have a definite -> http://fedoraproject.org/wiki/Packaging:Python - I'm not sure why they're not running, but they seem to just be in disrepair. - I'm aware upstream seems to have stopped working on it. - It builds fine on f21 in koji without modification: http://koji.fedoraproject.org/koji/taskinfo?taskID=8904169 I'll put out another release to deal with rpath and dropping python2_sitelib
OK, here's a new release that does a few things: - Drops python2_sitelib - Gets rid of rpath definition. - Builds from a git checkout. (There were bugfixes in git unreleased on pypi) - Switches to using Cython to build (which is a more complete build from scratch). Spec URL: http://threebean.org/rpm/SPECS/python-re2.spec SRPM URL: http://threebean.org/rpm/SRPMS/python-re2-0.2.20-2.20150211git382bb74.fc21.src.rpm
Successful f21 scratch build: https://kojipkgs.fedoraproject.org//work/tasks/9250/8909250/python-re2-0.2.20-2.20150211git382bb74.fc21.x86_64.rpm
And it now builds fine locally as well! :) rpmlint contains the same warnings as before, but nothing worrying Considering you are now using the github version, I'd change the URL to point to the project on github, but this is minor and up to you. This package is APPROVED
Thanks Pierre! New Package SCM Request ======================= Package Name: python-re2 Short Description: Python wrapper for Google's RE2 using Cython Upstream URL: http://pypi.python.org/pypi/re2 Owners: ralph Branches: f22 f21 f20 epel7 InitialCC:
Git done (by process-git-requests).
python-re2-0.2.20-2.20150211git382bb74.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-re2-0.2.20-2.20150211git382bb74.el7
python-re2-0.2.20-2.20150211git382bb74.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-re2-0.2.20-2.20150211git382bb74.fc21
python-re2-0.2.20-2.20150211git382bb74.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-re2-0.2.20-2.20150211git382bb74.fc20
python-re2-0.2.20-2.20150211git382bb74.fc21 has been pushed to the Fedora 21 stable repository.
python-re2-0.2.20-2.20150211git382bb74.fc20 has been pushed to the Fedora 20 stable repository.
python-re2-0.2.20-2.20150211git382bb74.el7 has been pushed to the Fedora EPEL 7 stable repository.