Bug 1192113 - Command hammer --version fails (for bootdisk module)
Summary: Command hammer --version fails (for bootdisk module)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Hammer
Version: Unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: Adam Price
QA Contact: Tazim Kolhar
URL: http://projects.theforeman.org/issues...
Whiteboard:
: 1176496 (view as bug list)
Depends On: 1190013
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-02-12 16:07 UTC by Lukas Pramuk
Modified: 2017-02-23 20:31 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-12 05:24:52 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 9538 0 None None None 2016-04-22 16:48:02 UTC
Red Hat Bugzilla 1196502 0 medium CLOSED Command hammer --version fails (for gutterball module) 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1198245 0 unspecified CLOSED Command hammer --version fails (for discovery module) 2021-02-22 00:41:40 UTC
Red Hat Product Errata RHSA-2015:1592 0 normal SHIPPED_LIVE Important: Red Hat Satellite 6.1.1 on RHEL 6 2015-08-12 09:04:35 UTC

Internal Links: 1196502 1198245

Description Lukas Pramuk 2015-02-12 16:07:32 UTC
Description of problem:
hammer --version fails with undefined method `version' for nil:NilClass
This time the error is caused by gutterball module.

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-7-20150210.0
rubygem-hammer_cli_gutterball-0.0.1.1-1.el7sat.noarch
rubygem-hammer_cli_foreman-0.1.4.3-1.el7sat.noarch
rubygem-hammer_cli-0.1.4.3-1.el7sat.noarch

How reproducible:
100'/.

Steps to Reproduce:
0.# sed -i 's|true|false|' /etc/hammer/cli.modules.d/[^g]*.yml
(Currently yet another module has issues with version method - foreman_bootdisk, we need to disable it in order to reproduce)

1.# hammer --version 
hammer (0.1.4)
Error: undefined method `version' for nil:NilClass


Actual results:
fails with an error

Expected results:
shows module versions

Comment 1 RHEL Program Management 2015-02-12 16:23:22 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Adam Price 2015-02-24 01:16:51 UTC
what hammer modules do you have installed?

i cannot reproduce this error.


$ hammer --version
hammer (0.1.4)
 * hammer_cli_foreman (0.1.4)
 * hammer_cli_gutterball (0.0.1)
 * hammer_cli_katello (0.0.7)

Comment 4 Adam Price 2015-02-24 21:34:32 UTC
this error was coming from hammer-cli-foreman-bootdisk

Comment 5 Adam Price 2015-02-24 21:42:28 UTC
Created redmine issue http://projects.theforeman.org/issues/9538 from this bug

Comment 7 Bryan Kearney 2015-03-02 09:05:14 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/9538 has been closed
-------------
Dominic Cleal
https://github.com/theforeman/hammer_cli_foreman_bootdisk/pull/3 merged.

Comment 10 Tazim Kolhar 2015-03-04 08:19:59 UTC
FAILEDQA

# hammer --version

hammer (0.1.4)
 * hammer_cli_foreman (0.1.4.6)
 * hammer_cli_foreman_bootdisk (0.1.2.5)
Error: undefined method `version' for HammerCLIForemanDiscovery:Module

# rpm -qa | grep foreman
foreman-1.7.2.8-1.el6_6sat.noarch
rubygem-hammer_cli_foreman_discovery-0.0.1.2-1.el6_6sat.noarch
foreman-compute-1.7.2.8-1.el6_6sat.noarch
ruby193-rubygem-foreman_docker-1.2.0.2-1.el6_6sat.noarch
ruby193-rubygem-foreman_hooks-0.3.7-2.el6_6sat.noarch
ruby193-rubygem-foreman-tasks-0.6.12.1-1.el6_6sat.noarch
foreman-proxy-1.7.2.3-1.el6_6sat.noarch
qe-sat6-rhel66.usersys.redhat.com-foreman-client-1.0-1.noarch
qe-sat6-rhel66.usersys.redhat.com-foreman-proxy-client-1.0-1.noarch
rubygem-hammer_cli_foreman_bootdisk-0.1.2.5-1.el6_6sat.noarch
foreman-vmware-1.7.2.8-1.el6_6sat.noarch
foreman-libvirt-1.7.2.8-1.el6_6sat.noarch
ruby193-rubygem-foreman_abrt-0.0.5-2.el6_6sat.noarch
qe-sat6-rhel66.usersys.redhat.com-foreman-proxy-1.0-2.noarch
rubygem-hammer_cli_foreman-0.1.4.6-1.el6_6sat.noarch
foreman-selinux-1.7.2.8-1.el6_6sat.noarch
foreman-debug-1.7.2.8-1.el6_6sat.noarch
foreman-gce-1.7.2.8-1.el6_6sat.noarch
ruby193-rubygem-foreman-redhat_access-0.0.8-2.el6_6sat.noarch
ruby193-rubygem-foreman_discovery-2.0.0.5-1.el6_6sat.noarch
ruby193-rubygem-foreman_gutterball-0.0.1.9-1.el6_6sat.noarch
foreman-postgresql-1.7.2.8-1.el6_6sat.noarch
rubygem-hammer_cli_foreman_tasks-0.0.3.3-1.el6_6sat.noarch
foreman-ovirt-1.7.2.8-1.el6_6sat.noarch
ruby193-rubygem-foreman_bootdisk-4.0.2.8-1.el6_6sat.noarch

Comment 11 Lukas Pramuk 2015-03-05 16:22:18 UTC
Yes indeed.
...
 * hammer_cli_foreman (0.1.4.6)
 * hammer_cli_foreman_bootdisk (0.1.2.5)
Error: undefined method `version' for HammerCLIGutterball:Module
...

You have to disable foreman_discovery module (in /etc/hammer/cli.modules.d/foreman_discovery.yml) to get this PROPER error message (related to gutterball module)

Comment 12 Lukas Zapletal 2015-03-13 12:50:07 UTC
*** Bug 1176496 has been marked as a duplicate of this bug. ***

Comment 13 Adam Price 2015-03-24 13:57:55 UTC
fixed upstream: https://github.com/theforeman/hammer-cli/pull/165

this diff prevents hammer from throwing an error, but if a module doesn't have its version setup correctly, then said module will display "unknown version".

Please file new bugs for specific modules that display "unknown version".

Comment 14 Bryan Kearney 2015-04-15 19:43:02 UTC
commit d61d84c29dd46c917be5799ce360beb093cad5a4
Author: Tomas Strachota <tstrachota>
Date:   Fri Mar 13 10:17:54 2015 +0000

    Fixes #9742 - version fails with error
    
    (cherry picked from commit dbbbbcdb6d6358208d3c5cc4063567ee6dcdda64)

Comment 15 Tazim Kolhar 2015-04-24 07:38:56 UTC
VERIFIED :

#rpm -qa | grep foreman
foreman-libvirt-1.7.2.17-1.el6_6sat.noarch
ruby193-rubygem-foreman_bootdisk-4.0.2.10-1.el6_6sat.noarch
ruby193-rubygem-foreman_hooks-0.3.7-2.el6_6sat.noarch
rubygem-hammer_cli_foreman_tasks-0.0.3.3-1.el6_6sat.noarch
rubygem-hammer_cli_foreman_bootdisk-0.1.2.5-1.el6_6sat.noarch
foreman-postgresql-1.7.2.17-1.el6_6sat.noarch
foreman-debug-1.7.2.17-1.el6_6sat.noarch
foreman-1.7.2.17-1.el6_6sat.noarch
foreman-ovirt-1.7.2.17-1.el6_6sat.noarch
ruby193-rubygem-foreman-tasks-0.6.12.3-1.el6_6sat.noarch
foreman-proxy-1.7.2.4-1.el6_6sat.noarch
qe-sat6-rhel66.usersys.redhat.com-foreman-client-1.0-1.noarch
qe-sat6-rhel66.usersys.redhat.com-foreman-proxy-client-1.0-1.noarch
foreman-selinux-1.7.2.13-1.el6_6sat.noarch
rubygem-hammer_cli_foreman-0.1.4.9-1.el6_6sat.noarch
foreman-compute-1.7.2.17-1.el6_6sat.noarch
foreman-vmware-1.7.2.17-1.el6_6sat.noarch
ruby193-rubygem-foreman-redhat_access-0.1.0-1.el6_6sat.noarch
ruby193-rubygem-foreman_gutterball-0.0.1.9-1.el6_6sat.noarch
qe-sat6-rhel66.usersys.redhat.com-foreman-proxy-1.0-2.noarch
ruby193-rubygem-foreman_docker-1.2.0.9-1.el6_6sat.noarch
rubygem-hammer_cli_foreman_discovery-0.0.1.7-1.el6_6sat.noarch
foreman-gce-1.7.2.17-1.el6_6sat.noarch
ruby193-rubygem-foreman_discovery-2.0.0.9-1.el6_6sat.noarch


steps:
# hammer --version
hammer (0.1.4.8)
 * hammer_cli_foreman (0.1.4.9)
 * hammer_cli_foreman_bootdisk (0.1.2.5)
 * hammer_cli_foreman_discovery (0.0.1.7)
 * hammer_cli_gutterball (unknown version)
 * hammer_cli_import (0.10.6.5)
 * hammer_cli_katello (0.0.7.8)

Comment 16 Bryan Kearney 2015-08-11 13:27:37 UTC
This bug is slated to be released with Satellite 6.1.

Comment 17 errata-xmlrpc 2015-08-12 05:24:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:1592


Note You need to log in before you can comment on or make changes to this bug.