Bug 1192504 - rubygem-rest-client: plain text passwords are being logged
Summary: rubygem-rest-client: plain text passwords are being logged
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Red Hat Product Security
QA Contact:
URL:
Whiteboard:
Depends On: 1192505 1192506 1192507 1240983
Blocks: 1192509
TreeView+ depends on / blocked
 
Reported: 2015-02-13 15:03 UTC by Vasyl Kaigorodov
Modified: 2021-02-17 05:39 UTC (History)
55 users (show)

Fixed In Version: rubygem-rest-client 1.7.3
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-04-01 20:34:25 UTC
Embargoed:

Attachments (Terms of Use)

Description Vasyl Kaigorodov 2015-02-13 15:03:52 UTC 
It was reported [1] that when logging is enabled,  ... puts passwords to the log file in plaintext.
Suggested fix:
https://github.com/rest-client/rest-client/issues/352

[1]: https://github.com/rest-client/rest-client/issues/349
Comment 2 Vasyl Kaigorodov 2015-02-13 15:05:11 UTC 
Created rubygem-rest-client tracking bugs for this issue:

Affects: fedora-all [bug 1192505]
Affects: epel-all [bug 1192506]
Comment 3 Ján Rusnačko 2015-02-24 16:20:43 UTC 
Technical analysis:

This vulnerability affects all known versios of rest-client.

The accepted fix is to redact password part of the URL:

sanitized_url = begin
  uri = URI.parse(url)
  uri.password = "REDACTED" if uri.password
  uri.to_s

The fix is done by commit 60ae4a5373e574bdeacd7b526c72f4e7d0ca858f and is included in 1.7.3 release.

References:
https://github.com/xaviershay/rest-client/commit/60ae4a5373e574bdeacd7b526c72f4e7d0ca858f
Note You need to log in before you can comment on or make changes to this bug.